Received-SPF: pass (google.com: domain of linux-kernel+bounces-98270-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Precedence: bulk
MIME-Version: 1.0
References: <tencent_32C3AEB0599DF0A0010A862439636CDA2707@qq.com> <20240310113306.GF12921@unreal>
In-Reply-To: <20240310113306.GF12921@unreal>
From: Greg Sword <gregsword0@gmail.com>
Date: Mon, 11 Mar 2024 01:02:18 +0800
Message-ID: <CAEz=Lcvm9a0Zg-V8O5xPZ0t3BHNj8+H-wSdSn0i4eZfZgsqRNw@mail.gmail.com>
Subject: Re: [PATCH] RDMA/siw: Reuse value read using READ_ONCE instead of
 re-reading it
To: Leon Romanovsky <leon@kernel.org>
Cc: linke li <lilinke99@qq.com>, Bernard Metzler <bmt@zurich.ibm.com>, Jason Gunthorpe <jgg@ziepe.ca>, 
	linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Sun, Mar 10, 2024 at 7:33=E2=80=AFPM Leon Romanovsky <leon@kernel.org> w=
rote:
>
> On Sat, Mar 09, 2024 at 08:27:16PM +0800, linke li wrote:
> > In siw_orqe_start_rx, the orqe's flag in the if condition is read using
> > READ_ONCE, checked, and then re-read, voiding all guarantees of the
> > checks. Reuse the value that was read by READ_ONCE to ensure the
> > consistency of the flags throughout the function.
>
> Please read include/asm-generic/rwonce.h comments when READ_ONCE() is use=
d.
> There is no value in caching the output of READ_ONCE().

Agree. Read the link
https://www.kernel.org/doc/Documentation/memory-barriers.txt, too

>
> Thanks
>