Received-SPF: pass (google.com: domain of linux-kernel+bounces-98280-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
From: David Laight <David.Laight@ACULAB.COM>
To: 'Roman Smirnov' <r.smirnov@omp.ru>, Jaegeuk Kim <jaegeuk@kernel.org>,
	"Chao Yu" <chao@kernel.org>
CC: Sergey Shtylyov <s.shtylyov@omp.ru>, Karina Yankevich
	<k.yankevich@omp.ru>, "linux-f2fs-devel@lists.sourceforge.net"
	<linux-f2fs-devel@lists.sourceforge.net>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>, "lvc-project@linuxtesting.org"
	<lvc-project@linuxtesting.org>
Subject: RE: [PATCH] f2fs: Cast expression type to unsigned long in
 __count_extent_cache()
Thread-Topic: [PATCH] f2fs: Cast expression type to unsigned long in
 __count_extent_cache()
Thread-Index: AQHabtSs8qQLngIY8Ey8WBtnYc/JqbExQp7Q
Date: Sun, 10 Mar 2024 17:46:14 +0000
Message-ID: <b4f9780714e243a6af9f77ab00593ec1@AcuMS.aculab.com>
References: <20240305080943.6922-1-r.smirnov@omp.ru>
In-Reply-To: <20240305080943.6922-1-r.smirnov@omp.ru>
Accept-Language: en-GB, en-US
Precedence: bulk
MIME-Version: 1.0
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

From: Roman Smirnov
> Sent: 05 March 2024 08:10
>=20
> Cast expression type to unsigned long in __count_extent_cache()
> to prevent integer overflow.
>=20
> Found by Linux Verification Center (linuxtesting.org) with Svace.

Another broken analysis tool :-)

> Signed-off-by: Roman Smirnov <r.smirnov@omp.ru>
> Reviewed-by: Sergey Shtylyov <s.shtylyov@omp.ru>
> ---
>  fs/f2fs/shrinker.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/fs/f2fs/shrinker.c b/fs/f2fs/shrinker.c
> index 83d6fb97dcae..bb86a06c5d5e 100644
> --- a/fs/f2fs/shrinker.c
> +++ b/fs/f2fs/shrinker.c
> @@ -33,7 +33,7 @@ static unsigned long __count_extent_cache(struct f2fs_s=
b_info *sbi,
>  {
>  =09struct extent_tree_info *eti =3D &sbi->extent_tree[type];
>=20
> -=09return atomic_read(&eti->total_zombie_tree) +
> +=09return (unsigned long)atomic_read(&eti->total_zombie_tree) +
>  =09=09=09=09atomic_read(&eti->total_ext_node);

Makes diddly-squit difference.

Both total_zombie_tree and totat_ext_node are 'int'.
If they are large enough that their sum wraps then the values
can individually wrap (to negative values).

You really don't want to cast 'int' to 'unsigned long' here
at all - implicitly or explicitly.
The cast will first promote 'int' to 'signed long'.
So a negative value will get sign extended to a very big value.

The best you can hope for is a 33bit result from wrapped 32bit
signed counters.
To get that you need to convert 'int' =3D> 'unsigned int' =3D> 'unsigned lo=
ng'.
One way would be:
=09return (atomic_read(&eti->total_zombie_tree) + 0u + 0ul) +
=09=09(atomic_read(&eti->total_ext_node) + 0u);

Although changing the return type to 'unsigned int' would probably
be better.
I don't know what the values are, but if they are stats counters
then that would give a value that nicely wraps at 2^32 rather
that the strange wrap that the sum of two wrapping 32bit counters
has.

OTOH it may be that they are counts - and just can't get any where
near that big.

=09David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1=
PT, UK
Registration No: 1397386 (Wales)