Received-SPF: pass (google.com: domain of linux-kernel+bounces-98292-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <96a938d4-f5c4-4eb9-8406-94102d4b3312@gmx.de>
Date: Sun, 10 Mar 2024 19:26:50 +0100
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] hwmon: (dell-smm) Add Dell G5 5505 to DMI table
To: tjakobi@math.uni-bielefeld.de, =?UTF-8?Q?Pali_Roh=C3=A1r?=
 <pali@kernel.org>, Jean Delvare <jdelvare@suse.com>,
 Guenter Roeck <linux@roeck-us.net>
Cc: linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20240310174144.859510-1-tjakobi@math.uni-bielefeld.de>
Content-Language: en-US
From: Armin Wolf <W_Armin@gmx.de>
In-Reply-To: <20240310174144.859510-1-tjakobi@math.uni-bielefeld.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:yUMZ9XzHdA0=;kD6XaqyNTLIqde9GX+C8Mua0j84
 1fyDC0miOcrKVtdkSR0G8hs5e0xRPWxgnBpAxh7CTrHfFa1SHwy2RGxOZy0aKOvD4L7ficaYK
 IMPGupxhcOqmeIrNJMMNh7fFe26bl/Q05rTpiZ03L5iwh7eHWD9MR3io0DXK3pcRSt956J+Xk
 5uJlV0w8zvP69c8JuPzqjG/5u5YUHAseHpdOW/FjzGpNr3fkTrCK6oKMqdpSGab1Nu4PSsaza
 5q7sH/hqisxzqJ1WqRb9m+wz4nKdYTm01Qc0EMFK9r26dz9LI5k2a9G49mUWP6jGOzUm1D7Kl
 zRbVpzapOCmDiL4Q+zf+iuUktNMcjRbaLYBEh4A0AbtgbtYJmozjpYv6lOVGmJI9yfbwoU+8A
 6/ZHbsoeguN+AlI1tpE6eYCcTOSGsmMEZafgUMbhk/2PLumtiXrbrMX6WopyVVtCfRi9NiRbr
 Y6GBDJjfDsKDp7J8T3w097IcyQ4LU3A9ZRcu5SoZPuNjnxHyF5+RcpuBjRWAlxHFiqq1ef2Ee
 QT+mP8KPWPxi212eYfA0O736Wz5KrpPzvuyb9nE8+R8D1XTVKsFvczXUUgGC+PJS2jStU38xC
 jYWetNCj+w+4JKCE+DneOaSjCS8GKAGxlkx78LfbZUbMiFmvrKv7yaxSxkLLLU4aaPOrEMqTb
 a0uCgYIlrMbZMWLjuaLIidXaSaJldMF14fLBDjBnA3hWo2H6Ixz7rUW/8tnJvV+EYvkDMwutx
 OtLt31uQr+eekmVff2C//AArlx3hebsEaXa9sCRUX57o5PKIxYzL1LeNz6Glk0ecWEUz2d9dm
 OW/eSc10edpnCgF8O80xexensG0VFG3W7MnW2YDlKk9Qw=

Am 10.03.24 um 18:41 schrieb tjakobi@math.uni-bielefeld.de:

> From: Tobias Jakobi <tjakobi@math.uni-bielefeld.de>
>
> Enables reading the speed of the CPU and GPU fan on the G5.
>
> Signed-off-by: Tobias Jakobi <tjakobi@math.uni-bielefeld.de>
> ---
>   drivers/hwmon/dell-smm-hwmon.c | 8 ++++++++
>   1 file changed, 8 insertions(+)
>
> diff --git a/drivers/hwmon/dell-smm-hwmon.c b/drivers/hwmon/dell-smm-hwm=
on.c
> index 44aaf9b9191d..bee9cca2f768 100644
> --- a/drivers/hwmon/dell-smm-hwmon.c
> +++ b/drivers/hwmon/dell-smm-hwmon.c
> @@ -1192,6 +1192,14 @@ static const struct dmi_system_id i8k_dmi_table[]=
 __initconst =3D {
>   			DMI_MATCH(DMI_PRODUCT_NAME, "XPS"),
>   		},
>   	},
> +	{
> +		.ident =3D "Dell G5 5505",
> +		.matches =3D {
> +			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> +			DMI_MATCH(DMI_PRODUCT_FAMILY, "GSeries"),

Hi,

i think you can omit the match of DMI_PRODUCT_FAMILY. Also we already have=
 another G5-series machine
in the DMI list (somewhere at the top). Maybe you can put this entry close=
 to this entry?

Thanks,
Armin Wolf

> +			DMI_MATCH(DMI_PRODUCT_NAME, "G5 5505"),
> +		},
> +	},
>   	{ }
>   };
>