Received-SPF: pass (google.com: domain of linux-kernel+bounces-98339-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Sun, 10 Mar 2024 22:25:21 +0100
From: Borislav Petkov <bp@alien8.de>
To: Tom Lendacky <thomas.lendacky@amd.com>
Cc: linux-kernel@vger.kernel.org, x86@kernel.org,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	"H. Peter Anvin" <hpa@zytor.com>, Andy Lutomirski <luto@kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Dan Williams <dan.j.williams@intel.com>,
	Michael Roth <michael.roth@amd.com>,
	Ashish Kalra <ashish.kalra@amd.com>
Subject: Re: [PATCH v2 01/14] x86/sev: Rename snp_init() in the
 boot/compressed/sev.c file
Message-ID: <20240310212521.GBZe4lQWwIQSBsaCLc@fat_crate.local>
References: <cover.1709922929.git.thomas.lendacky@amd.com>
 <d558343480a78b53ac419ce67fc9f13d631672a4.1709922929.git.thomas.lendacky@amd.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <d558343480a78b53ac419ce67fc9f13d631672a4.1709922929.git.thomas.lendacky@amd.com>

On Fri, Mar 08, 2024 at 12:35:16PM -0600, Tom Lendacky wrote:
> @@ -478,7 +557,7 @@ void sev_enable(struct boot_params *bp)
>  	 * Setup/preliminary detection of SNP. This will be sanity-checked
>  	 * against CPUID/MSR values later.
>  	 */
> -	snp = snp_init(bp);
> +	snp = snp_setup(bp);

So if you call the compressed/sev.c version early_snp_init() or
boot_snp_init() or something similar, you know immediately when it is
called vs having to grep the tree to figure out which is which - was
snp_setup() early or was it in the kernel proper.  And so on...

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette