Received: by 2002:ab2:710b:0:b0:1ef:a325:1205 with SMTP id z11csp86384lql; Sun, 10 Mar 2024 15:29:37 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUs7ncQSXxr4qXIZaCdn0+E/0es/3vI2qtzhDDQheB9egISGL8TiwEXO9LozWUKlrXMjbcB43PVmT5nQliOyV8vcMrKDrslW42k9Z0u6w== X-Google-Smtp-Source: AGHT+IFG9IUd817yBWrekc7kk1YfbEbLS6XAcoLa/c8YBUNsjzSIFLtJVkRMmdndSFeiiiJXAyy4 X-Received: by 2002:a50:d51c:0:b0:565:cf:2566 with SMTP id u28-20020a50d51c000000b0056500cf2566mr4675650edi.12.1710109777185; Sun, 10 Mar 2024 15:29:37 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1710109777; cv=pass; d=google.com; s=arc-20160816; b=fvVHlvrShVhtRU0WThBB3Bu6eLSUuKmbFrfXFPrJF3PIrBZkNWKJiFg/2+AKQGW+dI 6hN67BfRD7AXxMGYgv4xZqYOnqzeaLagXvDnYyD/GoZC7CdqggC6myOpdNrCvM3qYNqn 5OZ7kr3ADzRkVr13GA7R6a68xegeob500g9pvEhcGDWC/yqoSSnQhnalyWzIdjYYHG30 HAoXyeBTUHHRSKb+g68wxRLi5HLHSrrgenZNnSecqwZhT5Wj66GIkkIu76lnzCJNm+eL IuBCThXkaJMHf6bxjTlrlwTqGGPK//yJkBAD25tTEOSEe8Y+P1pQ4Uj4KneBrMf17iEQ mbzQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:mail-followup-to :message-id:subject:cc:to:from:date:dkim-signature; bh=HhfUU+4kL8hvl2D0ndWWX7dVBYB6Tpmgu3GonvIIoqs=; fh=Rkhmf+zXAIGBL7IR3KK6kyz42jJUZhol9W5j5AugSLg=; b=zOSl9olhK/Ibq4++BUnQgBn4jIjedO7HssUyEw6+nI34nO7xeqHie7xk7YbjzYhL82 kFIrIEQqHAUfh2Z8vLJZ+KbOpB9AgnUColzNW2AlNhj/rgbi5r+K1F5F/BS+Vs8vzwnZ 8vOLP4rpsHaR0YSG43uUFjOHZWvBPI63evSKEH/CRDpFEdSoiVOmq5VX0tL6ukpVU81s XEPzHxY378nDz38N+SVAQUrPbSsdh1NvEOroYNygb3iw+2DrKqI2fI/VZXuKh2FKifUT N1lYrqCA7qFLr1KVqHnhxW7ydvNW5I24X1QXaV4xFrr+RvXE+4jgxAFdyFUirK7Mnqx7 RooA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@xnux.eu header.s=mail header.b=GTkGpEn3; arc=pass (i=1 spf=pass spfdomain=xnux.eu dkim=pass dkdomain=xnux.eu dmarc=pass fromdomain=xnux.eu); spf=pass (google.com: domain of linux-kernel+bounces-98354-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-98354-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=xnux.eu Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id b6-20020a056402350600b005682b6ac21esi1918083edd.54.2024.03.10.15.29.37 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 10 Mar 2024 15:29:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-98354-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@xnux.eu header.s=mail header.b=GTkGpEn3; arc=pass (i=1 spf=pass spfdomain=xnux.eu dkim=pass dkdomain=xnux.eu dmarc=pass fromdomain=xnux.eu); spf=pass (google.com: domain of linux-kernel+bounces-98354-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-98354-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=xnux.eu Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id E1F961F2146E for ; Sun, 10 Mar 2024 22:29:36 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 3F3123B7A0; Sun, 10 Mar 2024 22:29:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=xnux.eu header.i=@xnux.eu header.b="GTkGpEn3" Received: from vps.xff.cz (vps.xff.cz [195.181.215.36]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 536E73B78D for ; Sun, 10 Mar 2024 22:29:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.181.215.36 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710109768; cv=none; b=W0YWEVn2Try9zFvql1nMy2Xwy4atjFMBZQvLkqXq/Ufv/dta9361vwEXidpso4ijL1qIbJvOi9Ahlebl+BrLkuUdAdwUvfj+qwpTYctdFLhvDbR+XJm2cHE+hrFB86VQiMFRhptHSlTm5/JD4pq23esAD68kvX9iTtu8Ymp7r8s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710109768; c=relaxed/simple; bh=0dh7I6BWcg7FvSd5QFiZfq+RVCTqyfeXWc/UPHa5atk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=BLzQTbIBlyn7brcK38JjFr8pLroDjwWT5p7Xb0rB8pyPD3wmUasD/x0WbQp4rf2oRZtjp0hkpz69Yj0CZTKU6v3/nBk16I8usLMCw5rQLCCJAAkII6xXpCWDDw9izyLCCZoQK9nUinL6cOO/ygokGxd1j8D/9NpFTFEfbMF5oZs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=xnux.eu; spf=pass smtp.mailfrom=xnux.eu; dkim=pass (1024-bit key) header.d=xnux.eu header.i=@xnux.eu header.b=GTkGpEn3; arc=none smtp.client-ip=195.181.215.36 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=xnux.eu Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=xnux.eu DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=xnux.eu; s=mail; t=1710109441; bh=0dh7I6BWcg7FvSd5QFiZfq+RVCTqyfeXWc/UPHa5atk=; h=Date:From:To:Cc:Subject:X-My-GPG-KeyId:References:From; b=GTkGpEn3N5HcVUAR98jLSZy17qzKnKu8TgBB3cjtDGJQwkOzKb2yJp+bqFI3joH8J uxgzo2F5cx7Ie2uyLtEtjQHwljMVm3T9ziyfDh8cfCjn0rjENGS4QXMOWjo56VdoDY MuQU5vWCEQULn3w6drNgNV6COrsqnjUR85xMS+IE= Date: Sun, 10 Mar 2024 23:23:57 +0100 From: =?utf-8?Q?Ond=C5=99ej?= Jirman To: Frank Oltmanns Cc: Maxime Ripard , Chen-Yu Tsai , Maarten Lankhorst , Thomas Zimmermann , David Airlie , Daniel Vetter , Jernej Skrabec , Samuel Holland , Icenowy Zheng , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm/sun4i: tcon: Support keeping dclk rate upon ancestor clock changes Message-ID: Mail-Followup-To: =?utf-8?Q?Ond=C5=99ej?= Jirman , Frank Oltmanns , Maxime Ripard , Chen-Yu Tsai , Maarten Lankhorst , Thomas Zimmermann , David Airlie , Daniel Vetter , Jernej Skrabec , Samuel Holland , Icenowy Zheng , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org X-My-GPG-KeyId: EBFBDDE11FB918D44D1F56C1F9F0A873BE9777ED References: <20240310-tcon_keep_stable_rate-v1-1-0296b0a85c02@oltmanns.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240310-tcon_keep_stable_rate-v1-1-0296b0a85c02@oltmanns.dev> Hello Frank, On Sun, Mar 10, 2024 at 02:32:29PM +0100, Frank Oltmanns wrote: > +static int sun4i_rate_reset_notifier_cb(struct notifier_block *nb, > + unsigned long event, void *data) > +{ > + struct sun4i_rate_reset_nb *rate_reset = to_sun4i_rate_reset_nb(nb); > + > + if (event == POST_RATE_CHANGE) > + schedule_delayed_work(&rate_reset->reset_rate_work, msecs_to_jiffies(100)); If you get multiple reset notifier calls within 100ms of the first one, the delay from the last one will not be 100ms, so this may violate expectations you're describing in the commit message. schedule_delayed_work doesn't re-schedule the work if it's already pending. Kind regards, o.