Received-SPF: pass (google.com: domain of linux-kernel+bounces-98391-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <296e1196-9572-4839-9298-002d6c52537c@intel.com>
Date: Mon, 11 Mar 2024 14:05:38 +1300
User-Agent: Mozilla Thunderbird
Subject: Re: [RFC PATCH 1/8] KVM: Document KVM_MAP_MEMORY ioctl
Content-Language: en-US
To: Isaku Yamahata <isaku.yamahata@linux.intel.com>, Sean Christopherson
	<seanjc@google.com>
CC: David Matlack <dmatlack@google.com>, "kvm@vger.kernel.org"
	<kvm@vger.kernel.org>, Isaku Yamahata <isaku.yamahata@intel.com>,
	"federico.parola@polito.it" <federico.parola@polito.it>,
	"pbonzini@redhat.com" <pbonzini@redhat.com>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>, "isaku.yamahata@gmail.com"
	<isaku.yamahata@gmail.com>, "michael.roth@amd.com" <michael.roth@amd.com>
References: <cover.1709288671.git.isaku.yamahata@intel.com>
 <c50dc98effcba3ff68a033661b2941b777c4fb5c.1709288671.git.isaku.yamahata@intel.com>
 <9f8d8e3b707de3cd879e992a30d646475c608678.camel@intel.com>
 <20240307203340.GI368614@ls.amr.corp.intel.com>
 <35141245-ce1a-4315-8597-3df4f66168f8@intel.com>
 <ZepiU1x7i-ksI28A@google.com> <ZepptFuo5ZK6w4TT@google.com>
 <20240308021941.GM368614@ls.amr.corp.intel.com>
From: "Huang, Kai" <kai.huang@intel.com>
In-Reply-To: <20240308021941.GM368614@ls.amr.corp.intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZmNrQXhwTkUwQVp4K1hHWFR0UzdoeDdYS3c4SHlBdWhyRWpJcFdwbnhtbnd3?=
 =?utf-8?B?SkJCY0Irc2svMXRzWVlxUFBOcTNkcEhFZHIzMHpHOWZmYkxmc1J5RnNJQ0VK?=
 =?utf-8?B?NDZ1NjRiaXhkV2Q2dmdBbU12bHI2RlVxRHR6NUg5UjBhUjVzSE5qbG9XWjRH?=
 =?utf-8?B?TW9yTEJHZDJGMS9iQ3hEcE5NTWIvNEdBQVNuUFRTaEx5eXlJQlRnZU42Yk1q?=
 =?utf-8?B?SzQ2MmxvRFdKU2N4dk0raUFxKzlQeXVkek16ajZaUGVuNGRqTUxVM2FUR00z?=
 =?utf-8?B?RDQ1cnhkdS9PL1JiV2ljU3JFRWdXdlozd0R5NFh6emxtWkY1cjFDM1FPVmpz?=
 =?utf-8?B?ZU9IZENBWXFka1RRdm1YbDBKUmdZVmF4cTZmNnNmdUlKK1dCdHZrZ1gyeEEw?=
 =?utf-8?B?Zm9teEwzMndVYzg0SWc1Z2IvSW9NdHRINThUekVxQTlJSTFNUDBWRnViYTFX?=
 =?utf-8?B?TkR5eG9tZFZwYWpiQytMOFp0N1Y4dmNneG91V2VibGx1ZjVoTkVlYjBTSytW?=
 =?utf-8?B?N1FFTVNPand5NWdXRFFGSE9tYy9Eemx6eTN0cTVDTXZ1YjVDdEJheUxNYXA5?=
 =?utf-8?B?YTVRYnF3SytCZFhWZ2NUYXppVWFmclg4WEVuMEhOd0V0aGFvYkFCVkRGc0dO?=
 =?utf-8?B?b0JKQkMzL1dOWnkvZ2VadmZXelUzRnpWR3Q3NzlrK3JoVHpRQmszOXZsUEhE?=
 =?utf-8?B?Q1BNZzhYQXRYQnVCT09EVCtveGZxMkVaYUJTZFliRUNXTzdqYUdwY0FyTzlS?=
 =?utf-8?B?V29zOExSMERrV2lPT2pYVHNVUlpWNVVLbm1lejFjdjNEMHVyS1cvRE9uemll?=
 =?utf-8?B?bkRTTndDTHBZV3k2RzUwMEFkc1IrNS92RTZjbTdjc2tNWVhhT29XRno3c1Fa?=
 =?utf-8?B?aUNjbXd5N1pNK3l6am1RQ3ZZRm1FYnd2bGE0MEJBOHp1dmYvVk9rOGdDR1hC?=
 =?utf-8?B?cnA2cXdFUkVsaUJhWVl4MlhaOTgyTm5paHRaVUQwTTg0RUJ5ZG1LMk55K045?=
 =?utf-8?B?cDJkcElDM3YrNkxlZ01vbE5GTzlLaGlXM3RaTDh2TUc5RnZxTG02YVAyQ1Fo?=
 =?utf-8?B?bkV6Y2pMWjhCcXlOVTdNL1ErbmVoUERwMDVDVkJpN2dqWjVOM3lEQm5hZ2sy?=
 =?utf-8?B?ZmpYMUJueGp1TUVkVGxJb28wYm1MREVVaWkrTllqQnAybHdNZno1RFg2b1pw?=
 =?utf-8?B?YkVBdjhpbmNBaGVrTjRnWngxT2lEdUFXU1p0ZTltOGZFN09OOWxwdGNmcmZt?=
 =?utf-8?B?L21LR3hpRU96RCt6UTYvV2NOdWJ2S2hYSXhqbzZPSG9kTFcrcGxjd29XNHdn?=
 =?utf-8?B?M1N0RlAwUm5lVTVsUVJIaFNmaEFMMmZ0Q3Fnams3WS9nZzREeEhRbkpMeXl6?=
 =?utf-8?B?ZlJWek1HZTQxN0RCOERsN0dXMjduZVgyT0U2N2VNaFAyYlpzN1RObFJMUzZG?=
 =?utf-8?B?ckNISDhCbzZwcXA4R3hRNCtLNTZhOXd6R3BlaTNvOUpYckJUbVdySWJpd2tL?=
 =?utf-8?B?eCtUTzI4TkpOa3RvTkN0QXJVMUgvS0tmSGNLcGhEQWFaUGFXYUVuSHRCMmNw?=
 =?utf-8?B?Z2FuYU1BdEZLaWpndlMwWXJlSHFudEFNSVNyUGNoaFNmY2o1dkhvWWR2WjVO?=
 =?utf-8?B?VjZLQVg5a1pDWENZUXNiZVQ5MnF0blhseEtxR0MybmUwQ0VEcXZrWTd6ampZ?=
 =?utf-8?B?dTQvdUR3WDV1V3NXOVNyUGFtRjFINXNoeFlPY3VXV2FDcjFzQ3VBaEN3MXpk?=
 =?utf-8?B?U0FMeS9vc0hjYzBzUzUyWElyNkR1a2dRNVM1THZERVdWazEzNDFqcFZNTlZi?=
 =?utf-8?B?eUdpRzJPUmZIUG5XQUhrd0dsOWxFYXE4dTU4WWZEOGkwNkJhY0cybXMwWEV0?=
 =?utf-8?B?RFRXM1JuaFkzYWxJcDZ4ZkFSVWVQMDBpRDl1NXhsa3BiSzVLUDF1Sm1UNW83?=
 =?utf-8?B?MGVWZHVsSW1XdFVkOUtnQlRvTlV3WFQ2Uzg5SE5PQ1hxNEFUWCtzTnIxcnk0?=
 =?utf-8?B?ZVVDZVFMQWsvNGJvVU9INllRcHRFR2lLSmxIOHhsQllUcGtGK0lqaUpIMDFo?=
 =?utf-8?B?RER0QUM2MlpKTXNyT25tWFRnRHRHOTFsVHpFWmlFN245aDJxY3VMblVPWmpL?=
 =?utf-8?Q?6u6I3Nlm4OJ6yDy98K3g7HLKv?=
X-MS-Exchange-CrossTenant-Network-Message-Id: e87fa1fb-d0d7-41f1-ef20-08dc41676416
X-MS-Exchange-CrossTenant-AuthSource: BL1PR11MB5978.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Mar 2024 01:05:49.8015
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: hBO4bEEihIJb7Qs+LGD+FR94rQiJu65+B5g9ZwcftZMLyOjZcgEQC+mZnvgewHgfin1ugUaaY/GVtqx6wBuIlw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB6441
X-OriginatorOrg: intel.com


> 
>    struct kvm_memory_mapping {
> 	__u64 base_gfn;
> 	__u64 nr_pages;
> 	__u64 flags;
> 	__u64 source;
>    };

 From your next patch the @source must be 4K aligned.  If it is intended 
please document this too.

[...]

The backend may encrypt
> it.  

To me the "backend" is a little bit confusing.  It doesn't mean the 
@source, correct?  Maybe just the "underlying physical pages may be 
encrypted" etc.  But it may be only my issue.