Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755402AbYAGHJh (ORCPT ); Mon, 7 Jan 2008 02:09:37 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752916AbYAGHJ2 (ORCPT ); Mon, 7 Jan 2008 02:09:28 -0500 Received: from miranda.se.axis.com ([193.13.178.8]:46189 "EHLO miranda.se.axis.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752042AbYAGHJ1 convert rfc822-to-8bit (ORCPT ); Mon, 7 Jan 2008 02:09:27 -0500 From: "Mikael Starvik" To: "'Sam Ravnborg'" , "'WANG Cong'" Cc: "Mikael Starvik" , "'LKML'" , , "'Andrew Morton'" , "dev-etrax" Subject: RE: [Patch 4/8] CRIS: Remove 'TOPDIR' from Makefiles Date: Mon, 7 Jan 2008 08:08:52 +0100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT X-Priority: 3 (Normal) X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook, Build 10.0.6626 X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2800.1106 Importance: Normal In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1644 Lines: 52 >PS. Mikael - should Jesper be mentioned in MAINTAINERS? Yes, that is a good idea. Down the road Jesper will take over maintainership I guess. -----Original Message----- From: Sam Ravnborg [mailto:sam@ravnborg.org] Sent: Tuesday, January 01, 2008 11:20 AM To: WANG Cong Cc: Mikael Starvik; LKML; linux-kbuild@vger.kernel.org; Andrew Morton; dev-etrax Subject: Re: [Patch 4/8] CRIS: Remove 'TOPDIR' from Makefiles On Tue, Jan 01, 2008 at 03:29:22PM +0800, WANG Cong wrote: > > TOPDIR is obsolete, use objtree instead. > This patch removes TOPDIR from all Cris Makefiles. > > Cc: Mikael Starvik > Cc: Sam Ravnborg > Signed-off-by: WANG Cong > > --- > > diff --git a/arch/cris/arch-v32/boot/compressed/Makefile b/arch/cris/arch-v32/boot/compressed/Makefile > index 9f77eda..8586922 100644 > --- a/arch/cris/arch-v32/boot/compressed/Makefile > +++ b/arch/cris/arch-v32/boot/compressed/Makefile > @@ -7,7 +7,7 @@ > target = $(target_compressed_dir) > src = $(src_compressed_dir) > > -CC = gcc-cris -mlinux -march=v32 -I $(TOPDIR)/include > +CC = gcc-cris -mlinux -march=v32 -I $(objtree)/include As in the mips case the right fix is to use: > +CC = gcc-cris -mlinux -march=v32 -Iinclude -Iinclude2 In this way we pick up the includes also in the O=.. case. PS. Mikael - should Jesper be mentioned in MAINTAINERS? Sam -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/