Received-SPF: pass (google.com: domain of linux-kernel+bounces-98408-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
From: "Tian, Kevin" <kevin.tian@intel.com>
To: Alex Williamson <alex.williamson@redhat.com>
CC: "kvm@vger.kernel.org" <kvm@vger.kernel.org>, "eric.auger@redhat.com"
	<eric.auger@redhat.com>, "clg@redhat.com" <clg@redhat.com>, "Chatre,
 Reinette" <reinette.chatre@intel.com>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>, "diana.craciun@oss.nxp.com"
	<diana.craciun@oss.nxp.com>, "stable@vger.kernel.org"
	<stable@vger.kernel.org>
Subject: RE: [PATCH v2 7/7] vfio/fsl-mc: Block calling interrupt handler
 without trigger
Thread-Topic: [PATCH v2 7/7] vfio/fsl-mc: Block calling interrupt handler
 without trigger
Thread-Index: AQHaca1RWvaU13rq+UiFS5yrw6Cg7bExyyBg
Date: Mon, 11 Mar 2024 01:56:07 +0000
Message-ID: <BN9PR11MB52768B392819FB724E70EC908C242@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <20240308230557.805580-1-alex.williamson@redhat.com>
 <20240308230557.805580-8-alex.williamson@redhat.com>
In-Reply-To: <20240308230557.805580-8-alex.williamson@redhat.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?8ciPD3QdzTQ0gNeafe2VHPWN4zCWPou+CrzbCTb720ob5LbMVJelz55k9yRA?=
 =?us-ascii?Q?rsdCcEuMMj9oNiWwqjSUQ1LTfrOfCXZD16nPz7u1nrHTT3k92d2491ouM9xW?=
 =?us-ascii?Q?o0BwkIdSPaiAvtnXHljsWkXhLEbaf3UWlIIN6fgv3ZLtHUutQjuJkHPt/P2m?=
 =?us-ascii?Q?OosgbgsBvp7p1C4A1uXMR01XgN5xlTNlllXh8YkoVEzohQo2C+zGNWYu1XXb?=
 =?us-ascii?Q?e2oP9F1ku+pURCEnP/w0IyDI1gyl3XcJMOkTWWuAlZMuZUTIV5divPizMQG0?=
 =?us-ascii?Q?+KtxUOR/rN8FnUn8fXANLtWG04jc22hxFtKrIqddIrR1B+ZGxTwuzflqZUVL?=
 =?us-ascii?Q?eTB7aPXisBsFI2yWI1fQ7Iut+DDfusxZGpoeDcvCau+ZFcrbny3HI/3P6UEJ?=
 =?us-ascii?Q?D0iN910o+64Nai77Ej88kyAznkBiQyjgFGNffA1PHitX3Q3fcOYuQ5/LBU36?=
 =?us-ascii?Q?V2mWXyjT6W1kUT3ibDzfqF0ZFhoa3RuYG5DS7qf/Ui2aeHFV6hr5GODTshFd?=
 =?us-ascii?Q?K/NS3uTjugjLDkfFBpZ0gHY80txywZ04MGLFckLVLrycVGEx/quoBvDPLvoe?=
 =?us-ascii?Q?jtZMaaeElZ8/wiOpwp2X0Wd3LfbL9P3/VX52UskcMpcbl1tQldEoJdr/JfKi?=
 =?us-ascii?Q?a14+S9JABS27dSqP9CcXx0Q1wOF3PAw06ly2bwMxeIaCPY41wpTou1wAPw42?=
 =?us-ascii?Q?W6D9/C4CPIK81hhxw6vgvviVhVsqc89LxFxtNJAIRLwzqD9pL8aAJ6fivKYc?=
 =?us-ascii?Q?Duogo2Y7oD8CesQHw9KFJHoTj5vc76mXy/N8bS3FZPmQGIO2cIZBCjEh5Ok0?=
 =?us-ascii?Q?OGP1n7ob6/U+bYNtVpqzScR+pmox/qXCJSxFGwwFJuoMwtYhF3aDjotqy2JY?=
 =?us-ascii?Q?7JYlMecpJ/V1B8Rkx6vF+M3Zl+iBna5Q/tUfRqffiQwbtxqeTSg6oNVUe1nd?=
 =?us-ascii?Q?ZdHxwhBhh79xeNZKBCTKRUBMCV5PiT49vgFDBo/6tWJfEKTgFupzMj4rIQ/7?=
 =?us-ascii?Q?nmJsLA4o1jdtWgG9XTna3hIFvgYFZJAnRckb5RtoMNOpXJ1QcIZYzS2Pdsfw?=
 =?us-ascii?Q?IOEq5AEDkdTUiIrGWHPQ4tLTflZIBg1/iqiMSifDTDL3/FUxa/IcpMkiYsFT?=
 =?us-ascii?Q?IdlCWWb57jH+5pqJcRy+cXG/LYdR3KqvSPfhZDEcVZsCu/jVCvKjIliuySSV?=
 =?us-ascii?Q?nwIJW8vCz/8arSItG56wRO8v8rRk5cQWgwozblBIEGmNdLjL7GKGimgE29QV?=
 =?us-ascii?Q?3DMR6cvjkzVgFRwXABjS1hKaNSx2mOExdsDwUM1WL/8OFxBjIpj7lmZzUMqW?=
 =?us-ascii?Q?38LFSWGrj5zLRy59oqDQVz5Z+mZU03h0liuphQ36ERkADYba1mNQpqEFmB1p?=
 =?us-ascii?Q?gvsy03MHZgjFahXRkY4cBjBhvrVPldTSHECHmpBBXP5WpikY7iRjY9jBazVT?=
 =?us-ascii?Q?D+ZCJERUlVkkQZecSdZKkLjJsNISVBmaRddW9WPKdgLD/k4UdILYdA+UFrdv?=
 =?us-ascii?Q?G32TyKUIiDN4hWd1Nic/K1DzMUh3b9IUvn1deMJSFbA+6lF3csAZC/lWuVGa?=
 =?us-ascii?Q?BOq9KvzemPNWfL8+vV0yeuvEEB3Dqlj3pNBGSswS?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 78594ecc-ec03-41d8-e8d8-08dc416e6b27
X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Mar 2024 01:56:07.9491
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: IaecbVPdeQ/theuYGyAFYYDra6+V1055xyNEoPLXPZUReVK0c3dakANkv3ZNLGZGcUmohONjExZMqR9O5eSN4Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR11MB4719
X-OriginatorOrg: intel.com

> From: Alex Williamson <alex.williamson@redhat.com>
> Sent: Saturday, March 9, 2024 7:05 AM
>=20
> The eventfd_ctx trigger pointer of the vfio_fsl_mc_irq object is
> initially NULL and may become NULL if the user sets the trigger
> eventfd to -1.  The interrupt handler itself is guaranteed that
> trigger is always valid between request_irq() and free_irq(), but
> the loopback testing mechanisms to invoke the handler function
> need to test the trigger.  The triggering and setting ioctl paths
> both make use of igate and are therefore mutually exclusive.
>=20
> The vfio-fsl-mc driver does not make use of irqfds, nor does it
> support any sort of masking operations, therefore unlike vfio-pci
> and vfio-platform, the flow can remain essentially unchanged.
>=20
> Cc: Diana Craciun <diana.craciun@oss.nxp.com>
> Cc: stable@vger.kernel.org
> Fixes: cc0ee20bd969 ("vfio/fsl-mc: trigger an interrupt via eventfd")
> Signed-off-by: Alex Williamson <alex.williamson@redhat.com>

Reviewed-by: Kevin Tian <kevin.tian@intel.com>