Received-SPF: pass (google.com: domain of linux-kernel+bounces-98446-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <087db56b-13c3-4624-b3a3-f02989aa5409@kernel.org>
Date: Mon, 11 Mar 2024 13:09:23 +0900
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v6] dt-bindings: imx-pata: Convert to dtschema
To: Animesh Agarwal <animeshagarwal28@gmail.com>,
 Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Rob Herring <robh+dt@kernel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
 Conor Dooley <conor+dt@kernel.org>, Shawn Guo <shawnguo@kernel.org>,
 Sascha Hauer <s.hauer@pengutronix.de>,
 Pengutronix Kernel Team <kernel@pengutronix.de>,
 Fabio Estevam <festevam@gmail.com>, NXP Linux Team <linux-imx@nxp.com>,
 linux-ide@vger.kernel.org, devicetree@vger.kernel.org,
 linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
References: <20240310175217.20981-1-animeshagarwal28@gmail.com>
 <448f9d20-8b45-4794-9440-89d6a6888aee@linaro.org>
 <011b7c4c-ae44-41eb-b7eb-1a71da669f26@linaro.org>
 <CAE3Oz82ZC5Vz125iLzjsdvZd1YLd4YgQsrGPgTRJ=ugEc=e=Ow@mail.gmail.com>
Content-Language: en-US
From: Damien Le Moal <dlemoal@kernel.org>
Organization: Western Digital Research
In-Reply-To: <CAE3Oz82ZC5Vz125iLzjsdvZd1YLd4YgQsrGPgTRJ=ugEc=e=Ow@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

On 3/11/24 12:33, Animesh Agarwal wrote:
> On Mon, Mar 11, 2024 at 2:03 AM Krzysztof Kozlowski
> <krzysztof.kozlowski@linaro.org> wrote:
>> BTW, If this was not clear, I am quite fed up with these patches, so
>> keep the rule of one version per day. You made quite a lot of changes
>> which were not necessary and I have impression that you should just
>> double check your code *before* sending next version.
> This was my first attempt at a contribution to the linux kernel. I
> have learned a lot, I feel like I have wasted a ton of your time.
> I always try to not make any mistakes before posting but it was
> clearly not a good try.
> Moving forward I'll be a lot more cautious and write better code and
> add proper explanation for the changes I made.

It is simple: the commit message should always explain *WHAT* you did and
*WHY*. This is to give some context to reviewers and to help with checking that
your code actually does what you explained. This also helps with potential
future issues with a change as the commit message remains in the git log history.

Regardless of the version of your patch, always have the what & why explained
in your commit message. This implies that the commit message must change if the
patch content changes between versions. Keep in mind that the changelog added
to a patch is lost when the patch is applied, but the commit message remains.

> 
> Thanks & Regards
> Animesh

-- 
Damien Le Moal
Western Digital Research