Received-SPF: pass (google.com: domain of linux-kernel+bounces-98457-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Mon, 11 Mar 2024 10:09:27 +0530
From: Dhruva Gole <d-gole@ti.com>
To: Saravana Kannan <saravanak@google.com>
CC: "Rafael J. Wysocki" <rafael@kernel.org>, Len Brown <len.brown@intel.com>,
        Pavel Machek <pavel@ucw.cz>, <kernel-team@android.com>,
        <linux-pm@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Documentation: power: Fix typo in suspend and interrupts
 doc
Message-ID: <20240311043927.il77znubaymo3rhd@dhruva>
References: <20240308224450.2327415-1-saravanak@google.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20240308224450.2327415-1-saravanak@google.com>

On Mar 08, 2024 at 14:44:50 -0800, Saravana Kannan wrote:
> Typos are bad. Fix them.

Maybe a little more description that you s/by/but would've also made
things more clear?

> 
> Signed-off-by: Saravana Kannan <saravanak@google.com>
> ---
>  Documentation/power/suspend-and-interrupts.rst | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/power/suspend-and-interrupts.rst b/Documentation/power/suspend-and-interrupts.rst
> index dfbace2f4600..f588feeecad0 100644
> --- a/Documentation/power/suspend-and-interrupts.rst
> +++ b/Documentation/power/suspend-and-interrupts.rst
> @@ -78,7 +78,7 @@ handling the given IRQ as a system wakeup interrupt line and disable_irq_wake()
>  turns that logic off.
>  
>  Calling enable_irq_wake() causes suspend_device_irqs() to treat the given IRQ
> -in a special way.  Namely, the IRQ remains enabled, by on the first interrupt
> +in a special way.  Namely, the IRQ remains enabled, but on the first interrupt
>  it will be disabled, marked as pending and "suspended" so that it will be
>  re-enabled by resume_device_irqs() during the subsequent system resume.  Also
>  the PM core is notified about the event which causes the system suspend in
> -- 

Anyway, changes LGTM!

Reviewed-by: Dhruva Gole <d-gole@ti.com>

-- 
Best regards,
Dhruva Gole <d-gole@ti.com>