Received-SPF: pass (google.com: domain of linux-kernel+bounces-98474-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Mon, 11 Mar 2024 10:56:51 +0530
From: Dhruva Gole <d-gole@ti.com>
To: Viresh Kumar <viresh.kumar@linaro.org>
CC: Sibi Sankar <quic_sibis@quicinc.com>, <dietmar.eggemann@arm.com>,
        <rafael@kernel.org>, <xuwei5@hisilicon.com>, <zhanjie9@hisilicon.com>,
        <sudeep.holla@arm.com>, <cristian.marussi@arm.com>,
        <linux-kernel@vger.kernel.org>, <linux-arm-msm@vger.kernel.org>,
        <quic_rgottimu@quicinc.com>, <linux-arm-kernel@lists.infradead.org>,
        <linux-pm@vger.kernel.org>
Subject: Re: [PATCH V2] cpufreq: Fix per-policy boost behavior on SoCs using
 cpufreq_boost_set_sw
Message-ID: <20240311052651.uedxt2wvywqlrsac@dhruva>
References: <20240308103630.383371-1-quic_sibis@quicinc.com>
 <20240311045044.7vvzbsx5nqs5a2lr@vireshk-i7>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20240311045044.7vvzbsx5nqs5a2lr@vireshk-i7>

Hi,

On Mar 11, 2024 at 10:20:44 +0530, Viresh Kumar wrote:
> On 08-03-24, 16:06, Sibi Sankar wrote:
> > +		/* Let the per-policy boost flag mirror the cpufreq_driver boost during init */
> > +		if (cpufreq_driver->boost_enabled)
> > +			policy->boost_enabled = policy_has_boost_freq(policy) ? true : false;
> 
> Can be written as:
> 
> policy->boost_enabled = cpufreq_boost_enabled() && policy_has_boost_freq(policy);

I would like to recommend the same.

> 
> Reviewed-by: Viresh Kumar <viresh.kumar@linaro.org>

Rest looks fine,
Reviewed-by: Dhruva Gole <d-gole@ti.com>

-- 
Best regards,
Dhruva Gole <d-gole@ti.com>