Received-SPF: pass (google.com: domain of linux-kernel+bounces-98483-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <681c0e19-51a7-452b-a6c6-f89c9c4dd254@amd.com>
Date: Mon, 11 Mar 2024 00:38:37 -0500
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v3] x86/mce: Dynamically size space for machine check
 records
Content-Language: en-US
To: Tony Luck <tony.luck@intel.com>, Borislav Petkov <bp@alien8.de>
Cc: "Mehta, Sohil" <sohil.mehta@intel.com>,
 Yazen Ghannam <yazen.ghannam@amd.com>, x86@kernel.org,
 linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20240307192704.37213-1-tony.luck@intel.com>
From: "Naik, Avadhut" <avadnaik@amd.com>
In-Reply-To: <20240307192704.37213-1-tony.luck@intel.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?Z0RmaER6YTNHZWVUZG44TUhqeGd5NW4xeWpCMHYyUHRoRVJqc2pJWVRMK2t2?=
 =?utf-8?B?YW9KejA3Z3AwdG9xOWlrd1RVVHBGYzJxampzcHdrTnlyTWFDSi95SVM4TnJK?=
 =?utf-8?B?T2llVXVXQ09wUFU3VlBSMmZOYmRreTU1VVZCNUkrMmJob3NFZUFJOUsya1BZ?=
 =?utf-8?B?VU8rMWxMM0RtV09IQ2hacWpZem4rajBXemlyMmxPWW1LekpMU1hraVlubGt1?=
 =?utf-8?B?dEs5TjNwMGtJTmxzclArZm1HUWNCTXFKSW9VMHVTdCtlVlJlNFVDdWtxSUIy?=
 =?utf-8?B?aVJDRUM0MTQvZ0NDWVhDdVBGdHV5QmZmVXo4Wkg0QXgxdVdTTElldDUrc1lO?=
 =?utf-8?B?YWNSY3Q5RmZSQkxyOGU0Vk1hTzk0NlAyeFpBa05zczNzZGtnSCtXM2xocHEx?=
 =?utf-8?B?TkNHbk5vRjMzZE1KcEtINHBXMUJWTFNUNU9QRmVuOE1md0xTMDViY3BDM3N3?=
 =?utf-8?B?VXNCSlkxdFJrRkRTR1hBYU8wclBabDZPbVpBSWVNMGEramhNQi9jeDVRU0JK?=
 =?utf-8?B?OXp3TnBndWVkOGEvajRxR2tFekd1NE1ZYitjNjdCMXNsZ05WTXFETmM5Z1JD?=
 =?utf-8?B?dTJtN1E0SjhtR2xFWjRMVzJ6LzdybnZUeDFpaTYrZFhFdEdFZXd0OXJzNEZV?=
 =?utf-8?B?TlRvb1dtK3pHc09OYmY3N3JYdHBtQVI3Z1ZaWi9rWk9iQjhocHFrT3hPQXBz?=
 =?utf-8?B?SnNPVFRQSXhsL3pKZXZsb0F6bHUwdFNSdEpDZE5ROVZpKzNROTVSSHltNGdG?=
 =?utf-8?B?aUx0Y2NqWHg2ZE9sUDl2dEhnKzh1d3IzemxRV2FZYUNSamM1Q1pyd1VnS0lI?=
 =?utf-8?B?b3hDYTEyMnorOXlrWUNsUWYzUkg5N0EvRFNCejZRTEtqV3BhQmE4VFphRUdq?=
 =?utf-8?B?SmwydU9xbHhobjNPblkwZmJ1a2dpT21TZmhSUE1YUkFsbXNJVEk3d2phWjlR?=
 =?utf-8?B?bXQxMTVwQ0dOeitra1VlMzJTeEpTN0lDYVlQeGlxeG5vVE0wSFNKU2g0ZG03?=
 =?utf-8?B?Vko4NHl2MDJDMVZWOTNERjNPZG1RZVYvZW5KMlhCc3BlZEUyRitxTUFXU0lq?=
 =?utf-8?B?bTBSbFlpOHVGSGwvMXBMeGQxcm42eWZNbWFiVWJSTUIwd1lZb055YlEyaUFi?=
 =?utf-8?B?aDByVFhBaS81QlBVeGFJMlVjTG1wUk11RzJCVXRQNXFkY1Nyc3g5bEltY2Ft?=
 =?utf-8?B?Q0Y1alRSMkxzVXRsREU4Q1VmekJWbVMwTTFiZzlKM0lrdjFWZVE1T0J2ZDZa?=
 =?utf-8?B?d1RTY0NhT0ZLSmh1UVFXakFpc2xqdldMNHN4TytodW1tNU1WVnBxNmIxV3ZE?=
 =?utf-8?B?VE5MTnlZVm1VUGZ1OGo1RFI4aVY2S3VkbmlaRGxzWCtuVEVFcVliVldxdmFW?=
 =?utf-8?B?T2JxaGhjNEw0UjFSTGNoaitHTXFJZWcxb3JMeTNIZ3VCQW1OUzVFdU82TUgy?=
 =?utf-8?B?a1k2eFJiUGdCSnlRdUs1dzJ2Z0ZIQVVqQnBvSGtaTTZSRGVpQnl2aFVNQkhT?=
 =?utf-8?B?TlBIS1dCOThQbnVhN1BKcFUzWkJyWDF2aFhyZEQrbys3Z3ZUYi9QYWlYa1BC?=
 =?utf-8?B?VGQ0Z3A5WVNxNUNRYUNsV3g5dXJ2d0I2U0xydlBkV0JsOWxSY3R4bDFIOWli?=
 =?utf-8?B?aVNHSm91U2RqbnBrVHp4WEtmNGt6Mm1KNEhqUHF4aFU0d3lueUs0V2hERjVi?=
 =?utf-8?B?cE0vekFEZmdHeWVrSFlzRU15WCtjdy9UYWQvSkF1RUJMdDhXdWVnLzFBalhZ?=
 =?utf-8?B?L29IeHNQQnZmaFJxL1ZkVDBTVzIxaUxCRDNLK1UwQ2ZWOGVJZkpFV1ZKVndX?=
 =?utf-8?B?Qys0NVVUb0VjVFNTaCthUit6bmNBZEE0KytmaGxhU3RGeDBJaU1pRGRRTkI2?=
 =?utf-8?B?WWN6YzFXeWZYb2VNN3JWcDVqR2htdDRCZXlrNWFTRFhrSjJPSnZpUjdlRzA0?=
 =?utf-8?B?MENCUk1UZkhVQ24zLytFZEdpVHBZdHJ4ZHZhbHltTFhudHNRN3VhNjRmaE40?=
 =?utf-8?B?ajY4YjdXY3Qzemt3ZGJwVU1ZZHVKdy9taVNFdEdJbjhTZ0kzd0RwOUljci9o?=
 =?utf-8?B?ZUppN0tGYVhvd2t0cFBzRlNDT2dqblIwbWNScHNFWTJNNGpvdURESW5SSnIv?=
 =?utf-8?Q?8xc46glvWtfaJyWkPyvCw8Gmg?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7b684218-d0f7-446e-0350-08dc418d8151
X-MS-Exchange-CrossTenant-AuthSource: CH3PR12MB8403.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Mar 2024 05:38:39.7926
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 1Bhomo+oR+4fc+qICWLZ5BLL1nYyZKGuRsZVRQbdblfVpYpiD8yveBTxEucTa+nUQvS1+IJnatqie7YEw+FXUg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CYYPR12MB9016


On 3/7/2024 13:27, Tony Luck wrote:
> Systems with a large number of CPUs may generate a large
> number of machine check records when things go seriously
> wrong. But Linux has a fixed buffer that can only capture
> a few dozen errors.
> 
> Allocate space based on the number of CPUs (with a minimum
> value based on the historical fixed buffer that could store
> 80 records).
> 
> Signed-off-by: Tony Luck <tony.luck@intel.com>
> Reviewed-by: Sohil Mehta <sohil.mehta@intel.com>
> ---
> 
> Changes since V2; Link: https://lore.kernel.org/all/20240307000256.34352-1-tony.luck@intel.com/
> 
> Boris: Eliminate "out:" label in mce_gen_pool_create()
> 
> Sohil: Added Reviewed-by tag
> 
>  arch/x86/kernel/cpu/mce/genpool.c | 28 +++++++++++++++++++---------
>  1 file changed, 19 insertions(+), 9 deletions(-)
> 
> diff --git a/arch/x86/kernel/cpu/mce/genpool.c b/arch/x86/kernel/cpu/mce/genpool.c
> index fbe8b61c3413..cadf28662a70 100644
> --- a/arch/x86/kernel/cpu/mce/genpool.c
> +++ b/arch/x86/kernel/cpu/mce/genpool.c
> @@ -16,14 +16,14 @@
>   * used to save error information organized in a lock-less list.
>   *
>   * This memory pool is only to be used to save MCE records in MCE context.
> - * MCE events are rare, so a fixed size memory pool should be enough. Use
> - * 2 pages to save MCE events for now (~80 MCE records at most).
> + * MCE events are rare, so a fixed size memory pool should be enough.
> + * Allocate on a sliding scale based on number of CPUs.
>   */
> -#define MCE_POOLSZ	(2 * PAGE_SIZE)
> +#define MCE_MIN_ENTRIES	80
> +#define MCE_PER_CPU	2
>  
>  static struct gen_pool *mce_evt_pool;
>  static LLIST_HEAD(mce_event_llist);
> -static char gen_pool_buf[MCE_POOLSZ];
>  
>  /*
>   * Compare the record "t" with each of the records on list "l" to see if
> @@ -118,22 +118,32 @@ int mce_gen_pool_add(struct mce *mce)
>  
>  static int mce_gen_pool_create(void)
>  {
> +	int mce_numrecords, mce_poolsz, order;
>  	struct gen_pool *tmpp;
>  	int ret = -ENOMEM;
> +	void *mce_pool;
>  
> -	tmpp = gen_pool_create(ilog2(sizeof(struct mce_evt_llist)), -1);
> +	order = order_base_2(sizeof(struct mce_evt_llist));
> +	tmpp = gen_pool_create(order, -1);
>  	if (!tmpp)
> -		goto out;
> +		return ret;
>  
> -	ret = gen_pool_add(tmpp, (unsigned long)gen_pool_buf, MCE_POOLSZ, -1);
> +	mce_numrecords = max(MCE_MIN_ENTRIES, num_possible_cpus() * MCE_PER_CPU);
> +	mce_poolsz = mce_numrecords * (1 << order);
> +	mce_pool = kmalloc(mce_poolsz, GFP_KERNEL);
> +	if (!mce_pool) {
> +		gen_pool_destroy(tmpp);
> +		return ret;
> +	}
> +	ret = gen_pool_add(tmpp, (unsigned long)mce_pool, mce_poolsz, -1);
>  	if (ret) {
>  		gen_pool_destroy(tmpp);
> -		goto out;
> +		kfree(mce_pool);
> +		return ret;
>  	}
>  
>  	mce_evt_pool = tmpp;
>  
> -out:
>  	return ret;
>  }
>  
> 
> base-commit: d206a76d7d2726f3b096037f2079ce0bd3ba329b

LGTM!

Reviewed-by: Avadhut Naik <avadhut.naik@amd.com>

-- 
Thanks,
Avadhut Naik