Received-SPF: pass (google.com: domain of linux-kernel+bounces-98534-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
From: Rex Nie <rex.nie@jaguarmicro.com>
To: james.morse@arm.com
Cc: fenghua.yu@intel.com,
	reinette.chatre@intel.com,
	rohit.mathew@arm.com,
	rex.nie@jaguarmicro.com,
	linux-kernel@vger.kernel.org
Subject: [PATCH] fs/resctrl: Uniform data type of component_id/domid/id/cache_id
Date: Mon, 11 Mar 2024 16:18:39 +0800
Message-Id: <20240311081839.937-1-rex.nie@jaguarmicro.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?3jCE2onIdoNWLovZoZNzz5sLIqps2Tpm4oEw3PuyT34ddob1AlKAoD1j4x5B?=
 =?us-ascii?Q?n8sQrmi62QHjrhip/s69EER9M25SwdbvZ4s+F+ntnbyT+UxReFSXocjIt9+L?=
 =?us-ascii?Q?JNS+Ii0N3bXToZ+WcPY8BaCSQc3ou9LCLhK4Lw+34nZ3ofhvgvFwcvUpKsNL?=
 =?us-ascii?Q?g1bnOMfLCYvrWE/mqwghUUGkF3wzxAZP/iZYDCc0/do5kRIHot0VL3q4DOht?=
 =?us-ascii?Q?SavQMUTnY2R5/veE+xqoq5HUOoMr6BsM6EPmRUiEP8JHjnHYYmNRyQJSIyOK?=
 =?us-ascii?Q?QG1tmsKoLbObZv8TSW2p9ZRRya+r6sMYddOW9hKyLGIwxfyl6GtJDxspyRum?=
 =?us-ascii?Q?G4n/+FbyeNoZLQ9fWvEBmnDYksWG70mQeaxlmqNnPohJRfyh1hmWwmoMUquW?=
 =?us-ascii?Q?csl0svi8OfbRqXn+dcgd5/8U1BFLvTgZnuJDjWN776t94bK5jdiPtU5CwdCt?=
 =?us-ascii?Q?JqUMC2rGzsBDkD+m5rTO9DH8if5BLejmioamVGsgWKoVWVmu3w6132/05YqV?=
 =?us-ascii?Q?Kht9V2xGRheRu2ubJdwu2pP28t39n1IGQg79ouJSTCi+wAdP/V1Pvtu4TWAC?=
 =?us-ascii?Q?r5M++dyZtZgKpenajCiLnGFS/KNv7pgozV3t5AdNGwxoRv6fZxxlUslkBOPP?=
 =?us-ascii?Q?qOx3W45mVEaTrghDYwBlRJQW5g2MoKCMw51WhJW4c+whY8Ik+Cu5newj76qW?=
 =?us-ascii?Q?a0rdUKbL3p2qpMBkxdGrUNWvfB+07itooCGHQtuFbg01gm4EV66WQT3BTEAf?=
 =?us-ascii?Q?iVC9N34spqtHNzIYnxbQNcnPRbCcQSAdgZe5SR18FoBoMTtk136H4IWWvK/E?=
 =?us-ascii?Q?g0SkE0ANbL/EShn8zG5GcjfTN2PcXj0TSHJlSeQUFr6P3Dcj67Hzx9QkP3MB?=
 =?us-ascii?Q?Q4UIvI0OIhbrzbY51fRUYCQtbMQv4QH7n6Yjp+u49v4Lag6HhaMpj7oDNTns?=
 =?us-ascii?Q?VeXIY3USFnGrenUhUhVlRfTlZAFCP/T0kycr/kjCcngWWJ5SAp+VrvkTME1C?=
 =?us-ascii?Q?FtTw14TLyW5YJXrXkJzakywXARA5H1IVPCKONQlW+AE1E8sVPO16J9WbOSd9?=
 =?us-ascii?Q?De9dElk09WeqRZDIFLsyhqHrGZ+0iSvfunuO57vvhfDxDoHYUbWcAo2sg1kR?=
 =?us-ascii?Q?AIARDzN4AnjmoZfOQRlo+k8ccbSCmZGguYWirr9LgFeufEvTGk/eGL11qtRT?=
 =?us-ascii?Q?A5s/VACYl4ZQXIsl2EfzCZXwI6cluYSLTN/LdDsHL6xN5d7vcrp4Ds/1HXf3?=
 =?us-ascii?Q?6KhYtRlWF9eTUm6GYo/keQqjLLHznsqzHfOniCP7j06xJApZUzZmXuQAPh+G?=
 =?us-ascii?Q?w33mP1z1PcRdgcxx0oNSntkV/Gr+F1ZFAooaPbmrAolKTVv1CXHYhe5lH8IZ?=
 =?us-ascii?Q?opq8A7EIz6QGAHG57LSIOuCfSgiUnKGUdzpcYKyw4KcE0Xz+LjYLcvNpjtNA?=
 =?us-ascii?Q?d02mUxabyAeepdS32FeckDaq0XXK98NHsgM5BYQHFK2SqZrfZx5erSL+1Y++?=
 =?us-ascii?Q?S+vlp83xWRCHCHr/b3TL785HuF9z9ajwsWmqz41DKssY6eANPhhMOdaaKPLP?=
 =?us-ascii?Q?0WxCuhLLXeONSJMJjhZZdWuvFKcf7Bms4lakJA/4?=
X-OriginatorOrg: jaguarmicro.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a16f1be5-be50-4426-dacd-08dc41a3dd4a
X-MS-Exchange-CrossTenant-AuthSource: KL1PR0601MB5773.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Mar 2024 08:18:42.9708
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 1e45a5c2-d3e1-46b3-a0e6-c5ebf6d8ba7b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: pyOP+FQVLaFw4uHuwbNzN9d/kIfWfdYhZWN6h9GYHwKaTvsrba0MOADWGqlGamQRUUZqvrLwpd79NXag7FlP7g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYUPR06MB6051

This patch uniform data type of component_id/domid/id/cache_id to
u32 to avoid type confusion. According to ACPI for mpam, cache id
is used as locator for cache MSC. Reference to RD_PPTT_CACHE_ID
definition from edk2-platforms, u32 is enough for cache_id.

	(                                                              \
	  (((PackageId) & 0xF) << 20) | (((ClusterId) & 0xFF) << 12) | \
	  (((CoreId) & 0xFF) << 4) | ((CacheType) & 0xF)               \
	)

refs:
1. ACPI for mpam: https://developer.arm.com/documentation/den0065/latest/
2. RD_PPTT_CACHE_ID from edk2-platforms: https://github.com/tianocore/edk2-platforms/blob/master/Platform/ARM/SgiPkg/Include/SgiAcpiHeader.h#L202

Signed-off-by: Rex Nie <rex.nie@jaguarmicro.com>
---
 drivers/platform/mpam/mpam_devices.c | 8 ++++----
 include/linux/arm_mpam.h             | 2 +-
 include/linux/resctrl.h              | 2 +-
 3 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/platform/mpam/mpam_devices.c b/drivers/platform/mpam/mpam_devices.c
index c2457c36ab12..335ca9e441da 100644
--- a/drivers/platform/mpam/mpam_devices.c
+++ b/drivers/platform/mpam/mpam_devices.c
@@ -205,7 +205,7 @@ int mpam_register_requestor(u16 partid_max, u8 pmg_max)
 EXPORT_SYMBOL(mpam_register_requestor);
 
 static struct mpam_component *
-mpam_component_alloc(struct mpam_class *class, int id, gfp_t gfp)
+mpam_component_alloc(struct mpam_class *class, u32 id, gfp_t gfp)
 {
 	struct mpam_component *comp;
 
@@ -227,7 +227,7 @@ mpam_component_alloc(struct mpam_class *class, int id, gfp_t gfp)
 }
 
 static struct mpam_component *
-mpam_component_get(struct mpam_class *class, int id, bool alloc, gfp_t gfp)
+mpam_component_get(struct mpam_class *class, u32 id, bool alloc, gfp_t gfp)
 {
 	struct mpam_component *comp;
 
@@ -476,7 +476,7 @@ static int mpam_ris_get_affinity(struct mpam_msc *msc, cpumask_t *affinity,
 
 static int mpam_ris_create_locked(struct mpam_msc *msc, u8 ris_idx,
 				  enum mpam_class_types type, u8 class_id,
-				  int component_id, gfp_t gfp)
+				  u32 component_id, gfp_t gfp)
 {
 	int err;
 	struct mpam_msc_ris *ris;
@@ -525,7 +525,7 @@ static int mpam_ris_create_locked(struct mpam_msc *msc, u8 ris_idx,
 }
 
 int mpam_ris_create(struct mpam_msc *msc, u8 ris_idx,
-		    enum mpam_class_types type, u8 class_id, int component_id)
+		    enum mpam_class_types type, u8 class_id, u32 component_id)
 {
 	int err;
 
diff --git a/include/linux/arm_mpam.h b/include/linux/arm_mpam.h
index d70e4e726fe6..0a4ac76682b5 100644
--- a/include/linux/arm_mpam.h
+++ b/include/linux/arm_mpam.h
@@ -48,7 +48,7 @@ static inline int acpi_mpam_count_msc(void) { return -EINVAL; }
 int mpam_register_requestor(u16 partid_max, u8 pmg_max);
 
 int mpam_ris_create(struct mpam_msc *msc, u8 ris_idx,
-		    enum mpam_class_types type, u8 class_id, int component_id);
+		    enum mpam_class_types type, u8 class_id, u32 component_id);
 
 static inline unsigned int resctrl_arch_round_mon_val(unsigned int val)
 {
diff --git a/include/linux/resctrl.h b/include/linux/resctrl.h
index dd34523469a5..b00a89addf91 100644
--- a/include/linux/resctrl.h
+++ b/include/linux/resctrl.h
@@ -108,7 +108,7 @@ struct resctrl_staged_config {
  */
 struct rdt_domain {
 	struct list_head		list;
-	int				id;
+	u32						id;
 	struct cpumask			cpu_mask;
 	unsigned long			*rmid_busy_llc;
 	struct mbm_state		*mbm_total;
-- 
2.34.1