Received-SPF: pass (google.com: domain of linux-kernel+bounces-98538-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Mon, 11 Mar 2024 09:24:00 +0100
From: Maciej Wieczor-Retman <maciej.wieczor-retman@intel.com>
To: Rex Nie <rex.nie@jaguarmicro.com>
CC: <james.morse@arm.com>, <fenghua.yu@intel.com>,
	<reinette.chatre@intel.com>, <linux-kernel@vger.kernel.org>, Liming Wu
	<liming.wu@jaguar.com>
Subject: Re: [PATCH] fs/resctrl: fix domid loss precision issue
Message-ID: <2u7eg2khp2zrcmbfpnh6ighxqbttv2w7giwdxlkndeywpgq2bq@2lccnqwkbo65>
References: <20240311064822.891-1-rex.nie@jaguarmicro.com>
Content-Type: text/plain; charset="iso-8859-1"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20240311064822.891-1-rex.nie@jaguarmicro.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?dQWSxhNdBaCuzIUwXyHnDhO/McE1IzvTxElcXsdpW3q6RVKWsnH8RLwA4f?=
 =?iso-8859-1?Q?Bir6HPv2eF6NPGXaIxvtchgu9CkPYebIZt2ctoYmgt1lpY0qHEYtrasvKd?=
 =?iso-8859-1?Q?G0TkWt4wDr2G/BlRantX9/LV4Gh49c+dKiwahr/2mtJDMOMJBwNVqK0XT4?=
 =?iso-8859-1?Q?GUDqjm8ChDa9mQxjPSM0356IRiB+/ZO51TOoVvg302Dhk1Cf5qVetRfqqp?=
 =?iso-8859-1?Q?nUJ2sYdYHVorkv+TKlWuJPVqIolFlB3QV9r6qoVzVq22u2mvIPxb55i3YP?=
 =?iso-8859-1?Q?TQ94NW6zd7ozLcaKOC5wvBzT3lySw5knUU1j2+X6oiITHDq8kr9aJ3ZvUO?=
 =?iso-8859-1?Q?8Z2HWQZoJ9myp8tdaxayvlHKCxmVhWvSEI3Vcne/CXHVOdJZ1KsdxvqB+K?=
 =?iso-8859-1?Q?Bl4D1oE9kyyzYuU7CoDKggi2jZXtH/ZLtVLVXXD3KiSogwdLr/WUlD+Dxj?=
 =?iso-8859-1?Q?V1FA0SiHG3n2PgJzN+bF+sJLG5ZDCVgAWVKP69kOKIIhwy/98SYHQuBYi4?=
 =?iso-8859-1?Q?vCyAU0Mn97TlooE4lwRLxrQJtaxIQVHcRHGN96yn8S4OLdywvb+Q6rFxTt?=
 =?iso-8859-1?Q?LblSsBLSnChwHv9XiOcb5i0a3e+ymsAeU0wKZNEoyIZB7xTdf6vsuhEu6L?=
 =?iso-8859-1?Q?ho48pYRf9wxNIohJEmUjWRSdaULNqdCEkQ5EqzNCWUxCxTXrzU3eT06maV?=
 =?iso-8859-1?Q?UQhtA5V4V0G9HwvApNYOLlB2AhfO+B4LWLkaAz01Z5A5GH6kU4Yc33hZpb?=
 =?iso-8859-1?Q?Qe4yS1XD5RWpGtATmk86CzxyrVMSm+Se8TOGMhSbIjqvGXIOSBRV8CqfSE?=
 =?iso-8859-1?Q?+f0FykT0NdyNG3/oPSo2qB4kAl3qa9JgFXl6PCxSzLNWMjOcENSSI9pZIv?=
 =?iso-8859-1?Q?/Ohk232Ako8fCb/YH96EFQA0IikVx2nu5iDwLBiFrmhmW/QxhJgqqqJDzv?=
 =?iso-8859-1?Q?OHJQM880A3gtinFFvz1gXO2ygwdx9H74BGWS0nh/5OH50QzF6inPqWdMZ6?=
 =?iso-8859-1?Q?bKQxZNL3xW/gN7QkZXman+oDuQYifBWhQx/0jf/TozMnoi4OipXGAvfXrr?=
 =?iso-8859-1?Q?geibkDV/2f6a//CpAfZlI0Hifg66YlfZ6LKJjEkNxjfXaTLHttu6d8lAfe?=
 =?iso-8859-1?Q?eNE5+JP01fUTxVin+uv/AkWE4Akv+VaqqYwVH2NAt+1epIavjCN5nTXyyy?=
 =?iso-8859-1?Q?7W60NH5LRPeyzT68YxxBYXDkEmP3QnuVSTNl6KuBblY0PO1eyhqnyumLpP?=
 =?iso-8859-1?Q?JHttwgNDBUfVjuOO4M4bldqAf2ExIUOZWFI0tU9s/zhmojIcnzuVD85bRp?=
 =?iso-8859-1?Q?gGgLOsT5K75NlaArs0VDwyMCJGtwXRW2hoLaqSBWwLaKMgeGpIUibX+Ixb?=
 =?iso-8859-1?Q?PV3ZUd+89kR3yLT3jWWEqfYsgSVQpCfYy/IDYhseMr0E4wc9vHy5qwNsPk?=
 =?iso-8859-1?Q?fx/7onb4FLeVKBc7RFMaElk80rSdaCgOklUpmu6j+cwFdZv3Q+l8Zot+FU?=
 =?iso-8859-1?Q?swtLMHJTlnccIugNVvZbOVhne3mCiI9ZnEjyoodI/awRgu0CcIJF8ZiqIB?=
 =?iso-8859-1?Q?vj+rMLWbUSWoeGnuse6VNayvXKgdD/SKYzCX6p/W8RedZ9QB9xyS2D8KSy?=
 =?iso-8859-1?Q?RruhhTAScum/IOXyM1b3XjkFktD+bekX8djpXUizD0dJYVTLC8Z4v9FgRC?=
 =?iso-8859-1?Q?hu0oGhYgwim6Heu6Zsc=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: b04d279e-bf3b-4ff2-b34d-08dc41a4a2da
X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6231.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Mar 2024 08:24:15.4799
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: p14APYPu7kOskxYNWlVJOdgCtG2OfAHQ2VKhAfcjlf0pxMKZ6fIfBXSOOVp1LptScuZdd1BHqnHsJiUXc75UBdES64zCcKfTDSA3jJKNPyA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB7871
X-OriginatorOrg: intel.com

Hello,

On 2024-03-11 at 14:48:22 +0800, Rex Nie wrote:
>Below statement from mkdir_mondata_subdir function will loss precision,
>because it assigns int to 14 bits bitfield.
>	priv.u.domid = d->id;
>
>This will cause below issue if cache_id > 0x3fff likes:

Is there some reason for cache_id ever being this high?

I thought the max for cache_id was the amount of L3 caches on a system. And I
only observed it going up to 3 on some server platforms. So not nearly in the
range of 0x3fff or 16k.

>/sys/fs/resctrl/mon_groups/p1/mon_data/mon_L3_1048564 # cat llc_occupancy

How did you get this file to appear? Could you maybe show how your mon_data
directory looks like?

>cat: read error: No such file or directory
>
>This is the call trace when cat llc_occupancy:
>rdtgroup_mondata_show()
>	domid = md.u.domid
>	d = resctrl_arch_find_domain(r, domid)
>
>d is null here because of lossing precision
>
>Signed-off-by: Rex Nie <rex.nie@jaguarmicro.com>
>Signed-off-by: Liming Wu <liming.wu@jaguar.com>
>---
> fs/resctrl/internal.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/fs/resctrl/internal.h b/fs/resctrl/internal.h
>index 7a6f46b4edd0..096317610949 100644
>--- a/fs/resctrl/internal.h
>+++ b/fs/resctrl/internal.h
>@@ -94,7 +94,7 @@ union mon_data_bits {
> 	struct {
> 		unsigned int rid		: 10;
> 		enum resctrl_event_id evtid	: 8;
>-		unsigned int domid		: 14;
>+		u32				domid;
> 	} u;
> };
> 
>-- 
>2.34.1
>

-- 
Kind regards
Maciej Wiecz?r-Retman