Received-SPF: pass (google.com: domain of linux-kernel+bounces-98539-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240310112129.376134-1-shorne@gmail.com>
In-Reply-To: <20240310112129.376134-1-shorne@gmail.com>
From: Guo Ren <guoren@kernel.org>
Date: Mon, 11 Mar 2024 16:30:20 +0800
Message-ID: <CAJF2gTTQejVrTE5P+snObx=+hV9Chzfk4h6i73Mm9g3b4BU7uQ@mail.gmail.com>
Subject: Re: [PATCH] riscv: Remove unused asm/signal.h file
To: Stafford Horne <shorne@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>, Paul Walmsley <paul.walmsley@sifive.com>, 
	Palmer Dabbelt <palmer@dabbelt.com>, Albert Ou <aou@eecs.berkeley.edu>, 
	=?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= <bjorn@rivosinc.com>, 
	linux-riscv@lists.infradead.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Sun, Mar 10, 2024 at 7:21=E2=80=AFPM Stafford Horne <shorne@gmail.com> w=
rote:
>
> When riscv moved to common entry the definition and usage of
> do_work_pending was removed.  This unused header file remains.
>
> Remove the header file as it is not used.
>
> I have tested compiling the kernel with this patch applied and saw no
> issues.  Noticed when auditing how different ports handle signals
> related to saving FPU state.
>
> Fixes: f0bddf50586d ("riscv: entry: Convert to generic entry")
> Signed-off-by: Stafford Horne <shorne@gmail.com>
> ---
>  arch/riscv/include/asm/signal.h | 12 ------------
>  1 file changed, 12 deletions(-)
>  delete mode 100644 arch/riscv/include/asm/signal.h
>
> diff --git a/arch/riscv/include/asm/signal.h b/arch/riscv/include/asm/sig=
nal.h
> deleted file mode 100644
> index 956ae0a01bad..000000000000
> --- a/arch/riscv/include/asm/signal.h
> +++ /dev/null
> @@ -1,12 +0,0 @@
> -/* SPDX-License-Identifier: GPL-2.0-only */
> -
> -#ifndef __ASM_SIGNAL_H
> -#define __ASM_SIGNAL_H
> -
> -#include <uapi/asm/signal.h>
> -#include <uapi/asm/ptrace.h>
> -
> -asmlinkage __visible
> -void do_work_pending(struct pt_regs *regs, unsigned long thread_info_fla=
gs);
No more calling in arch/riscv for do_work_pending.

> -
> -#endif
> --
> 2.41.0
>
LGTM, Thx.

Reviewed-by: Guo Ren <guoren@kernel.org>

--=20
Best Regards
 Guo Ren