Received-SPF: pass (google.com: domain of linux-kernel+bounces-98580-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Mon, 11 Mar 2024 10:08:56 +0100
From: =?UTF-8?B?S8O2cnk=?= Maincent <kory.maincent@bootlin.com>
To: Simon Horman <horms@kernel.org>
Cc: Jakub Kicinski <kuba@kernel.org>, netdev@vger.kernel.org,
 linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com, Richard Cochran
 <richardcochran@gmail.com>
Subject: Re: [PATCH net-next] ptp: Move from simple ida to xarray
Message-ID: <20240311100856.4187d247@kmaincent-XPS-13-7390>
In-Reply-To: <20240308210745.GE603911@kernel.org>
References: <20240307100327.887758-1-kory.maincent@bootlin.com>
	<20240308210745.GE603911@kernel.org>
Organization: bootlin
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Fri, 8 Mar 2024 21:07:45 +0000
Simon Horman <horms@kernel.org> wrote:

> On Thu, Mar 07, 2024 at 11:03:26AM +0100, Kory Maincent wrote:
> > Move from simple ida to xarray for storing and loading the ptp_clock
> > pointer. This prepares support for future hardware timestamp selection =
by
> > being able to link the ptp clock index to its pointer.
> >=20
> > Signed-off-by: Kory Maincent <kory.maincent@bootlin.com> =20
>=20
> ...
>=20
> > @@ -246,11 +246,10 @@ struct ptp_clock *ptp_clock_register(struct
> > ptp_clock_info *info, if (ptp =3D=3D NULL)
> >  		goto no_memory;
> > =20
> > -	index =3D ida_alloc_max(&ptp_clocks_map, MINORMASK, GFP_KERNEL);
> > -	if (index < 0) {
> > -		err =3D index;
> > +	err =3D xa_alloc(&ptp_clocks_map, &index, ptp, xa_limit_31b,
> > +		       GFP_KERNEL);
> > +	if (err)
> >  		goto no_slot;
> > -	}
> > =20
> >  	ptp->clock.ops =3D ptp_clock_ops;
> >  	ptp->info =3D info; =20
>=20
> Hi Kory,
>=20
> Prior to this change err was -ENOMEM at this point. Now it is 0.

You are totally right. Thanks for reporting the issue!

Regards,
--=20
K=C3=B6ry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com