Received-SPF: pass (google.com: domain of linux-kernel+bounces-98581-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
From: Alexander Stein <alexander.stein@ew.tq-group.com>
To: ping.bai@nxp.com, lgirdwood@gmail.com, broonie@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, linux-arm-kernel@lists.infradead.org
Cc: kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev, Joy Zou <joy.zou@nxp.com>
Subject: Re: [PATCH v2 2/3] regulator: pca9450: add pca9451a support
Date: Mon, 11 Mar 2024 10:09:12 +0100
Message-ID: <6027895.lOV4Wx5bFT@steina-w>
Organization: TQ-Systems GmbH
In-Reply-To: <20240311084758.377889-3-joy.zou@nxp.com>
References: <20240311084758.377889-1-joy.zou@nxp.com> <20240311084758.377889-3-joy.zou@nxp.com>
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="iso-8859-1"

Hi,

thanks for the update.

Am Montag, 11. M=E4rz 2024, 09:47:56 CET schrieb Joy Zou:
> Adding support for pmic pca9451a.
>=20
> This patch support old and new pmic pca9451a. The new pmic trimed BUCK1.
> The default value of Toff_Deb is used to distinguish the old and new pmic.

This section doesn't apply anymore. Please remove it.

> Signed-off-by: Joy Zou <joy.zou@nxp.com>
> ---
> Changes in v2:
> 1. remove the old part support because the old part only is used for samp=
le
> and is diffcult to distinguish old and new part. so drop old part.
> 2. remove the unnecessary marco definition in the file pca9450.h.
> ---
>  drivers/regulator/pca9450-regulator.c | 197 +++++++++++++++++++++++++-
>  include/linux/regulator/pca9450.h     |   1 +
>  2 files changed, 195 insertions(+), 3 deletions(-)
>=20
> diff --git a/drivers/regulator/pca9450-regulator.c b/drivers/regulator/pc=
a9450-regulator.c
> index 2ab365d2749f..50c324e275b5 100644
> --- a/drivers/regulator/pca9450-regulator.c
> +++ b/drivers/regulator/pca9450-regulator.c
> @@ -103,7 +103,15 @@ static const struct regulator_ops pca9450_ldo_regula=
tor_ops =3D {
>   * 0.60 to 2.1875V (12.5mV step)
>   */
>  static const struct linear_range pca9450_dvs_buck_volts[] =3D {
> -	REGULATOR_LINEAR_RANGE(600000,  0x00, 0x7F, 12500),
> +	REGULATOR_LINEAR_RANGE(600000, 0x00, 0x7F, 12500),
> +};

That's an unrelated change.

> +/*
> + * BUCK1/3
> + * 0.65 to 2.2375V (12.5mV step)
> + */
> +static const struct linear_range pca9451a_dvs_buck_volts[] =3D {
> +	REGULATOR_LINEAR_RANGE(650000, 0x00, 0x7F, 12500),
>  };
> =20
>  /*
> @@ -662,6 +670,178 @@ static const struct pca9450_regulator_desc pca9450b=
c_regulators[] =3D {
>  	},
>  };
> =20
> +static const struct pca9450_regulator_desc pca9451a_regulators[] =3D {
> +	{
> +		.desc =3D {
> +			.name =3D "buck1",
> +			.of_match =3D of_match_ptr("BUCK1"),
> +			.regulators_node =3D of_match_ptr("regulators"),
> +			.id =3D PCA9450_BUCK1,
> +			.ops =3D &pca9450_dvs_buck_regulator_ops,
> +			.type =3D REGULATOR_VOLTAGE,
> +			.n_voltages =3D PCA9450_BUCK1_VOLTAGE_NUM,
> +			.linear_ranges =3D pca9451a_dvs_buck_volts,
> +			.n_linear_ranges =3D ARRAY_SIZE(pca9451a_dvs_buck_volts),
> +			.vsel_reg =3D PCA9450_REG_BUCK1OUT_DVS0,
> +			.vsel_mask =3D BUCK1OUT_DVS0_MASK,
> +			.enable_reg =3D PCA9450_REG_BUCK1CTRL,
> +			.enable_mask =3D BUCK1_ENMODE_MASK,
> +			.enable_val =3D BUCK_ENMODE_ONREQ,
> +			.ramp_mask =3D BUCK1_RAMP_MASK,
> +			.ramp_delay_table =3D pca9450_dvs_buck_ramp_table,
> +			.n_ramp_values =3D ARRAY_SIZE(pca9450_dvs_buck_ramp_table),
> +			.owner =3D THIS_MODULE,
> +			.of_parse_cb =3D pca9450_set_dvs_levels,
> +		},
> +		.dvs =3D {
> +			.run_reg =3D PCA9450_REG_BUCK1OUT_DVS0,
> +			.run_mask =3D BUCK1OUT_DVS0_MASK,
> +			.standby_reg =3D PCA9450_REG_BUCK1OUT_DVS1,
> +			.standby_mask =3D BUCK1OUT_DVS1_MASK,
> +		},
> +	},
> +	{
> +		.desc =3D {
> +			.name =3D "buck2",
> +			.of_match =3D of_match_ptr("BUCK2"),
> +			.regulators_node =3D of_match_ptr("regulators"),
> +			.id =3D PCA9450_BUCK2,
> +			.ops =3D &pca9450_dvs_buck_regulator_ops,
> +			.type =3D REGULATOR_VOLTAGE,
> +			.n_voltages =3D PCA9450_BUCK2_VOLTAGE_NUM,
> +			.linear_ranges =3D pca9450_dvs_buck_volts,
> +			.n_linear_ranges =3D ARRAY_SIZE(pca9450_dvs_buck_volts),
> +			.vsel_reg =3D PCA9450_REG_BUCK2OUT_DVS0,
> +			.vsel_mask =3D BUCK2OUT_DVS0_MASK,
> +			.enable_reg =3D PCA9450_REG_BUCK2CTRL,
> +			.enable_mask =3D BUCK2_ENMODE_MASK,
> +			.enable_val =3D BUCK_ENMODE_ONREQ_STBYREQ,
> +			.ramp_mask =3D BUCK2_RAMP_MASK,
> +			.ramp_delay_table =3D pca9450_dvs_buck_ramp_table,
> +			.n_ramp_values =3D ARRAY_SIZE(pca9450_dvs_buck_ramp_table),
> +			.owner =3D THIS_MODULE,
> +			.of_parse_cb =3D pca9450_set_dvs_levels,
> +		},
> +		.dvs =3D {
> +			.run_reg =3D PCA9450_REG_BUCK2OUT_DVS0,
> +			.run_mask =3D BUCK2OUT_DVS0_MASK,
> +			.standby_reg =3D PCA9450_REG_BUCK2OUT_DVS1,
> +			.standby_mask =3D BUCK2OUT_DVS1_MASK,
> +		},
> +	},
> +	{
> +		.desc =3D {
> +			.name =3D "buck4",
> +			.of_match =3D of_match_ptr("BUCK4"),
> +			.regulators_node =3D of_match_ptr("regulators"),
> +			.id =3D PCA9450_BUCK4,
> +			.ops =3D &pca9450_buck_regulator_ops,
> +			.type =3D REGULATOR_VOLTAGE,
> +			.n_voltages =3D PCA9450_BUCK4_VOLTAGE_NUM,
> +			.linear_ranges =3D pca9450_buck_volts,
> +			.n_linear_ranges =3D ARRAY_SIZE(pca9450_buck_volts),
> +			.vsel_reg =3D PCA9450_REG_BUCK4OUT,
> +			.vsel_mask =3D BUCK4OUT_MASK,
> +			.enable_reg =3D PCA9450_REG_BUCK4CTRL,
> +			.enable_mask =3D BUCK4_ENMODE_MASK,
> +			.enable_val =3D BUCK_ENMODE_ONREQ,
> +			.owner =3D THIS_MODULE,
> +		},
> +	},
> +	{
> +		.desc =3D {
> +			.name =3D "buck5",
> +			.of_match =3D of_match_ptr("BUCK5"),
> +			.regulators_node =3D of_match_ptr("regulators"),
> +			.id =3D PCA9450_BUCK5,
> +			.ops =3D &pca9450_buck_regulator_ops,
> +			.type =3D REGULATOR_VOLTAGE,
> +			.n_voltages =3D PCA9450_BUCK5_VOLTAGE_NUM,
> +			.linear_ranges =3D pca9450_buck_volts,
> +			.n_linear_ranges =3D ARRAY_SIZE(pca9450_buck_volts),
> +			.vsel_reg =3D PCA9450_REG_BUCK5OUT,
> +			.vsel_mask =3D BUCK5OUT_MASK,
> +			.enable_reg =3D PCA9450_REG_BUCK5CTRL,
> +			.enable_mask =3D BUCK5_ENMODE_MASK,
> +			.enable_val =3D BUCK_ENMODE_ONREQ,
> +			.owner =3D THIS_MODULE,
> +		},
> +	},
> +	{
> +		.desc =3D {
> +			.name =3D "buck6",
> +			.of_match =3D of_match_ptr("BUCK6"),
> +			.regulators_node =3D of_match_ptr("regulators"),
> +			.id =3D PCA9450_BUCK6,
> +			.ops =3D &pca9450_buck_regulator_ops,
> +			.type =3D REGULATOR_VOLTAGE,
> +			.n_voltages =3D PCA9450_BUCK6_VOLTAGE_NUM,
> +			.linear_ranges =3D pca9450_buck_volts,
> +			.n_linear_ranges =3D ARRAY_SIZE(pca9450_buck_volts),
> +			.vsel_reg =3D PCA9450_REG_BUCK6OUT,
> +			.vsel_mask =3D BUCK6OUT_MASK,
> +			.enable_reg =3D PCA9450_REG_BUCK6CTRL,
> +			.enable_mask =3D BUCK6_ENMODE_MASK,
> +			.enable_val =3D BUCK_ENMODE_ONREQ,
> +			.owner =3D THIS_MODULE,
> +		},
> +	},
> +	{
> +		.desc =3D {
> +			.name =3D "ldo1",
> +			.of_match =3D of_match_ptr("LDO1"),
> +			.regulators_node =3D of_match_ptr("regulators"),
> +			.id =3D PCA9450_LDO1,
> +			.ops =3D &pca9450_ldo_regulator_ops,
> +			.type =3D REGULATOR_VOLTAGE,
> +			.n_voltages =3D PCA9450_LDO1_VOLTAGE_NUM,
> +			.linear_ranges =3D pca9450_ldo1_volts,
> +			.n_linear_ranges =3D ARRAY_SIZE(pca9450_ldo1_volts),
> +			.vsel_reg =3D PCA9450_REG_LDO1CTRL,
> +			.vsel_mask =3D LDO1OUT_MASK,
> +			.enable_reg =3D PCA9450_REG_LDO1CTRL,
> +			.enable_mask =3D LDO1_EN_MASK,
> +			.owner =3D THIS_MODULE,
> +		},
> +	},
> +	{
> +		.desc =3D {
> +			.name =3D "ldo4",
> +			.of_match =3D of_match_ptr("LDO4"),
> +			.regulators_node =3D of_match_ptr("regulators"),
> +			.id =3D PCA9450_LDO4,
> +			.ops =3D &pca9450_ldo_regulator_ops,
> +			.type =3D REGULATOR_VOLTAGE,
> +			.n_voltages =3D PCA9450_LDO4_VOLTAGE_NUM,
> +			.linear_ranges =3D pca9450_ldo34_volts,
> +			.n_linear_ranges =3D ARRAY_SIZE(pca9450_ldo34_volts),
> +			.vsel_reg =3D PCA9450_REG_LDO4CTRL,
> +			.vsel_mask =3D LDO4OUT_MASK,
> +			.enable_reg =3D PCA9450_REG_LDO4CTRL,
> +			.enable_mask =3D LDO4_EN_MASK,
> +			.owner =3D THIS_MODULE,
> +		},
> +	},
> +	{
> +		.desc =3D {
> +			.name =3D "ldo5",
> +			.of_match =3D of_match_ptr("LDO5"),
> +			.regulators_node =3D of_match_ptr("regulators"),
> +			.id =3D PCA9450_LDO5,
> +			.ops =3D &pca9450_ldo_regulator_ops,
> +			.type =3D REGULATOR_VOLTAGE,
> +			.n_voltages =3D PCA9450_LDO5_VOLTAGE_NUM,
> +			.linear_ranges =3D pca9450_ldo5_volts,
> +			.n_linear_ranges =3D ARRAY_SIZE(pca9450_ldo5_volts),
> +			.vsel_reg =3D PCA9450_REG_LDO5CTRL_H,
> +			.vsel_mask =3D LDO5HOUT_MASK,
> +			.enable_reg =3D PCA9450_REG_LDO5CTRL_H,
> +			.enable_mask =3D LDO5H_EN_MASK,
> +			.owner =3D THIS_MODULE,
> +		},
> +	},
> +};
> +
>  static irqreturn_t pca9450_irq_handler(int irq, void *data)
>  {
>  	struct pca9450 *pca9450 =3D data;
> @@ -729,6 +909,10 @@ static int pca9450_i2c_probe(struct i2c_client *i2c)
>  		regulator_desc =3D pca9450bc_regulators;
>  		pca9450->rcnt =3D ARRAY_SIZE(pca9450bc_regulators);
>  		break;
> +	case PCA9450_TYPE_PCA9451A:
> +		regulator_desc =3D pca9451a_regulators;
> +		pca9450->rcnt =3D ARRAY_SIZE(pca9451a_regulators);
> +		break;
>  	default:
>  		dev_err(&i2c->dev, "Unknown device type");
>  		return -EINVAL;
> @@ -755,7 +939,8 @@ static int pca9450_i2c_probe(struct i2c_client *i2c)
> =20
>  	/* Check your board and dts for match the right pmic */
>  	if (((device_id >> 4) !=3D 0x1 && type =3D=3D PCA9450_TYPE_PCA9450A) ||
> -	    ((device_id >> 4) !=3D 0x3 && type =3D=3D PCA9450_TYPE_PCA9450BC)) {
> +	    ((device_id >> 4) !=3D 0x3 && type =3D=3D PCA9450_TYPE_PCA9450BC) ||
> +	    ((device_id >> 4) !=3D 0x9 && type =3D=3D PCA9450_TYPE_PCA9451A)) {
>  		dev_err(&i2c->dev, "Device id(%x) mismatched\n",
>  			device_id >> 4);
>  		return -EINVAL;
> @@ -767,6 +952,7 @@ static int pca9450_i2c_probe(struct i2c_client *i2c)
>  		const struct pca9450_regulator_desc *r;
> =20
>  		r =3D &regulator_desc[i];
> +

Please don't add this empty line. Seems like a leftover from v1.

Thanks and best regards,
Alexander

>  		desc =3D &r->desc;
> =20
>  		config.regmap =3D pca9450->regmap;
> @@ -846,7 +1032,8 @@ static int pca9450_i2c_probe(struct i2c_client *i2c)
>  	}
> =20
>  	dev_info(&i2c->dev, "%s probed.\n",
> -		type =3D=3D PCA9450_TYPE_PCA9450A ? "pca9450a" : "pca9450bc");
> +		type =3D=3D PCA9450_TYPE_PCA9450A ? "pca9450a" :
> +		(type =3D=3D PCA9450_TYPE_PCA9451A ? "pca9451a" : "pca9450bc"));
> =20
>  	return 0;
>  }
> @@ -864,6 +1051,10 @@ static const struct of_device_id pca9450_of_match[]=
 =3D {
>  		.compatible =3D "nxp,pca9450c",
>  		.data =3D (void *)PCA9450_TYPE_PCA9450BC,
>  	},
> +	{
> +		.compatible =3D "nxp,pca9451a",
> +		.data =3D (void *)PCA9450_TYPE_PCA9451A,
> +	},
>  	{ }
>  };
>  MODULE_DEVICE_TABLE(of, pca9450_of_match);
> diff --git a/include/linux/regulator/pca9450.h b/include/linux/regulator/=
pca9450.h
> index 505c908dbb81..243633c8dceb 100644
> --- a/include/linux/regulator/pca9450.h
> +++ b/include/linux/regulator/pca9450.h
> @@ -9,6 +9,7 @@
>  enum pca9450_chip_type {
>  	PCA9450_TYPE_PCA9450A =3D 0,
>  	PCA9450_TYPE_PCA9450BC,
> +	PCA9450_TYPE_PCA9451A,
>  	PCA9450_TYPE_AMOUNT,
>  };
> =20
>=20


=2D-=20
TQ-Systems GmbH | M=FChlstra=DFe 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht M=FCnchen, HRB 105018
Gesch=E4ftsf=FChrer: Detlef Schneider, R=FCdiger Stahl, Stefan Schneider
http://www.tq-group.com/