Received: by 2002:ab2:710b:0:b0:1ef:a325:1205 with SMTP id z11csp278946lql; Mon, 11 Mar 2024 02:22:43 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCWjuq5ShWZFXyI+LO4EscMf3dGcdJdirZLak5A4QR9c6GEElGZa84J+0E+EB8i4tO9LImlN7ALY+TknKze+V2uglo7M3vYM17EywJcWtA== X-Google-Smtp-Source: AGHT+IGF5W2C3MX/WHeq+Q/OSzhDDsM0krEzf2UOznp5UcoKoi+5u5To7+s3w1oEiZLPDF9h+Eah X-Received: by 2002:a17:907:7b06:b0:a46:2dd:cc1b with SMTP id mn6-20020a1709077b0600b00a4602ddcc1bmr3037672ejc.66.1710148963375; Mon, 11 Mar 2024 02:22:43 -0700 (PDT) Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id n18-20020a170906689200b00a44b121be33si2452848ejr.198.2024.03.11.02.22.43 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Mar 2024 02:22:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-98607-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@kernel.org header.s=k20201202 header.b=hPGYambr; arc=fail (body hash mismatch); spf=pass (google.com: domain of linux-kernel+bounces-98607-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-98607-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 1EF761F210D8 for ; Mon, 11 Mar 2024 09:22:43 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 8530317578; Mon, 11 Mar 2024 09:22:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="hPGYambr" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9F88417557; Mon, 11 Mar 2024 09:22:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710148951; cv=none; b=l1Dm+IL0IGKOv/jTGa8prfB+HI56bPvFY5eT8NjNbRZhmwQGTQJ2XhuxpDAh2sh0Su64DMm15CPVhxNezlpIFN/bGLTy3JaRZhPba27etnovRZGvmHGCHmm5/JvoDD9ip2AhKgqKbwMDdnq3dpmHprOcFpEpuXRSYp9FM1dXN6Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710148951; c=relaxed/simple; bh=5jwRjzBuqHsD6PpmjxxWVJQrTPGroJenGMk4S3Kn5mk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=mI2hkkQFNgv2VwtYUbkLUux5sNcpQ9y/NfVtGxLdyfV7rhZJ0mRFZ+cTvvLXUE7Z3mLZxX1k3LaKyl5On6hjfYadTaTPN0Reja/MNdNzQPDIh5+68DHBfIqcQRPl+YhmPKq74padciN8m5lnzYtJsvEZTi8dA7ZSWfltIcT71UU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=hPGYambr; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id C15C4C433C7; Mon, 11 Mar 2024 09:22:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1710148950; bh=5jwRjzBuqHsD6PpmjxxWVJQrTPGroJenGMk4S3Kn5mk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=hPGYambr5jaJ6Z+mS4Splw3bUn17P/mw45+F/F4IKxxOGqgIy5tsW8sRz6KP1fZrg vacdvHj1yvz9RrE1Q79OWQgXSM4pdqnD+1cT/mb/E6f0VuRItRqEw78Rhh/POdTFH3 mGGeZipdfIemSqwvX67bFvDrrT3tFDgCOp/7i/totLr1hopE1DVNMFNSeHtsXwp1Tj z0l7wRA7ksCwKFc7EO9fsSuiDdRPt9hCgTKBvj1nPePVbLi2bXufCLO0p1V+gHcbJb VfxAoU2YsFuhUrWGNlNuk02YkfrE/hE+p6ugdar+xaqB48S7QsG2XW5NzAGy+MKYcI 08YRBY5TWwc0A== Date: Mon, 11 Mar 2024 09:22:23 +0000 From: Simon Horman To: Breno Leitao Cc: "Jason A. Donenfeld" , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, dsahern@kernel.org, "open list:WIREGUARD SECURE NETWORK TUNNEL" Subject: Re: [PATCH net-next v2 2/2] wireguard: Remove generic .ndo_get_stats64 Message-ID: <20240311092223.GG24043@kernel.org> References: <20240308112746.2290505-1-leitao@debian.org> <20240308112746.2290505-2-leitao@debian.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240308112746.2290505-2-leitao@debian.org> On Fri, Mar 08, 2024 at 03:27:45AM -0800, Breno Leitao wrote: > Commit 3e2f544dd8a33 ("net: get stats64 if device if driver is > configured") moved the callback to dev_get_tstats64() to net core, so, > unless the driver is doing some custom stats collection, it does not > need to set .ndo_get_stats64. > > Since this driver is now relying in NETDEV_PCPU_STAT_TSTATS, then, it > doesn't need to set the dev_get_tstats64() generic .ndo_get_stats64 > function pointer. > > Signed-off-by: Breno Leitao Reviewed-by: Simon Horman ..