Received-SPF: pass (google.com: domain of linux-kernel+bounces-98621-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <03afee77-3d5e-44fc-9e03-eec70c9cee2a@oracle.com>
Date: Mon, 11 Mar 2024 09:30:36 +0000
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] scsi: megaraid_sas: disabled shared host tagset feature
 by default
To: mengfanhui <mengfanhui@kylinos.cn>, kashyap.desai@broadcom.com,
        sumit.saxena@broadcom.com, shivasharan.srikanteshwara@broadcom.com,
        chandrakanth.patil@broadcom.com
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20240311085412.2391632-1-mengfanhui@kylinos.cn>
Content-Language: en-US
From: John Garry <john.g.garry@oracle.com>
Organization: Oracle Corporation
In-Reply-To: <20240311085412.2391632-1-mengfanhui@kylinos.cn>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?MnFXOG82UkRkM0Y4UlRRbHFWb1hrMjVFNUpSbnE2QTdtQ3NJT1V4U2xnRzR1?=
 =?utf-8?B?a1NuVEE0VmNzNXdVVmhpNHppT2hjVkwrMzB0TFlaN0V4WHJjdVFLc0dITlZE?=
 =?utf-8?B?TEpJSnJkc3pCWmhIaGVidGlleEk3eWZwQ2ZyN3hWZmhIeHhQZ1dwdVY1UUcy?=
 =?utf-8?B?VEVUN0xyci9mUUpDaDBYVDVjdTZDZ3lrMU45cTArMkFnSjdjUThmNUFpTURx?=
 =?utf-8?B?N1BIdXFrSUFsZmpqcFBUZ2hFZ256UWtYcmt1RUpyalNyaFdQMGluc2RzeEpa?=
 =?utf-8?B?NURrR3RsMFl1ejZud0dPWkZDQUVIcFh1RUtjeFRHMGVNUkx5UHA2UVhpQXRC?=
 =?utf-8?B?RnowWTZWR29laXUwSk9Ec0tkWU5QM0M5Qnl2UkwxK0FabkNSdmNzVGhSbkRp?=
 =?utf-8?B?VnhBcmJvY2cxNGRJY015UUN2WXZhSC9UNGdpcERUMWZocEY3cEhnWWJER0k3?=
 =?utf-8?B?azJEUjVkT3E5RGZSOTNoL1YrTWVxblB6Rlg1WXAvR3NJNXRlUXd6YUZOVHRF?=
 =?utf-8?B?WHRtTEpFYkV1a2JKaG5Vclp4Y2lzRnBuVGFERVBaZDdyNGluNHZTK0UxWjQr?=
 =?utf-8?B?aXVBMEJUZE9HN24xSjhtVlNDVmM1UEZvWm81MGJqK3YzTUhjdkhRMXZkVnRB?=
 =?utf-8?B?RlplNUlJcmFLc3F5elRjdFZRSnhtQVcrVmRaQ2JHR1hmMjdSM3pTbVczU055?=
 =?utf-8?B?RVR5L0orVjErUDVlUTcxU2k1RkNIT0VwQjh3S3RzMHBMM2ZyV1VTbFNxOGo3?=
 =?utf-8?B?NXRVS2dhQ3VLaVRDWDR0c2paTzRwdWhBV3dLRlZveTJpcmVCMW9JbEVZY2lP?=
 =?utf-8?B?a040b0YyUWtGT1MvV3UzczdqajBSY1NMY0xqbitLNlVWbmxUM05aSlMyc3d2?=
 =?utf-8?B?RFd5SlNGaUUxY2lpSmsyOGNCNGh4Vi9nQkhlR3pKRlVDTys1K2Evc0U3OVlV?=
 =?utf-8?B?Yy9SOHV5U2p6eDdmNzVRTkc1QU16WHBqdkkzb1QrVkt2YW10UnR1WEtCN2Vk?=
 =?utf-8?B?MDdXU3g0NjNjWjUzRmYvdEZzYkRlcmJ1QlNndVlpdkNJSGpuZDJGcDRVRjV2?=
 =?utf-8?B?MElOZmNzdElhbkZyblpRbjFBRC9XN0lJRUxZdzEwSitObmtHSHRUam9sTWM1?=
 =?utf-8?B?ZFFMZFFwVS95NkllL2EwYlpVRXZoTXkxR3E2UWs3NDFMRDIrU09xVkpMT3l6?=
 =?utf-8?B?OTJIVWtXb2E2UXh3eG5EWGVOVWFmV3NmQitwR0Q2NjJ1a0ZnaHpxOU5wNytH?=
 =?utf-8?B?Y255bmxXc0NNOU5mYXZ2VE0xOXJXeld5QWk5aEljL1ZTRERia3Q2OXNYVU5J?=
 =?utf-8?B?eEZrSmxTK25JTlBnSkszaG9PbzZsRzFJb0dUTXoybU9Jb0trSzgxRXdYS0ps?=
 =?utf-8?B?UHhPLy84Mk1xQUJLYVhPZU44VllTNmlkZnZGOUxlYVNNVU5ZaDlMUjlFS3VD?=
 =?utf-8?B?Z0Q5eEl2RSt1SnN0RGlKM2FmSUhwMmlINGY4TnNWSFVvWlNJbDhRc3JnY3h0?=
 =?utf-8?B?dHpIRGdEa2RtdDBveUhOOXh0VzZxQlhvdU1xdnFua3l6Smw2Y3REVG1sNWdW?=
 =?utf-8?B?UGp0eDVOOGFmekFjMEFhVlgzT3V2USsybno0NjNrU2E1WHJ1VDRYV0FWMEhK?=
 =?utf-8?B?VWVxYjExa0NESkhoYVNjbHE4NmEyWDFjbng4VEZzMFlhTDYyOUc5N1ZCMW5r?=
 =?utf-8?B?KzBQUWp4Z0JOT3FYeG1Tc2ZrQkdVMEwxNEl5R1VZNUdVaHVSdkQzeU5pclUv?=
 =?utf-8?B?RWFkMlFIT01IeU9ReVVlcEtSemR6WHo3RFlCTlVydC9UOHJESklzUVgvaEoz?=
 =?utf-8?B?N1VMRjBMR2lVVjRtT1RYQkh5Z0ZYUkVoK3hPdFVINFB3cjdOajdJbWU4eXZC?=
 =?utf-8?B?S0lZVTBBU3FWVUFmWGNIVSs4NzY0TVlhQUxVR0JsWDE2RVBNbVRkV0U0VkVX?=
 =?utf-8?B?enBleVRGaWwwbVR2dDBzSUttenI2MHlCMjlwQjgya1FWVi91RGJpazh2QlNG?=
 =?utf-8?B?SmxWL0lCbXMyTllMM0ZOakFnQUpBcndVQk94Sm9GMnFNLzZpUlJqQi83TVlP?=
 =?utf-8?B?Y1N5bkNna2hLaUlIdytMaTJYczJ2enp0MWlrSUpqSU8vYUFNbXp0VXhIWkJz?=
 =?utf-8?Q?xV8G6oPmxzs6lkXq5WW8b1ZRa?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	Ts0/00D+roZF7pypYxckAQ6beZ/fjHzwwhQ0kopN6OMpj86ZB49HJGkKU+KdbUelP3L98W4dOl1NsX9fSB7JhearkXS2p2AJxNhkJYuF/4m/72Qf+SnYIjCmbRPCoOR5A01EBeC0l0n/X+t3QtEYAUTPncmL5xsnV6fb3krqO5E0uklGBiuMq0V6fe9pWLdjUKRh5pN0Y6jQto19djbT0C2BVvT6lPy1bL0/6dIUy+VbwFHk87ixFMXi1KHKTYAKuuzRrD8W0NN24SpUvXQQjaDmUHRCOf3G/GxR4H7N+AKJcud/iciFed7VD8kCheSaqesGUz6R86yc92XJgNbGQEIgQpIxXd9q877EonTQ79Dn9rLeyVFbUaZQL8J+9VWnoowhR23syLCxEZdtIXnuturecjdI9Z1Xh0lp7woJQOfxc025fAnl4EqvcjITbHkpEXexoITNb4ZXNISqDQymE1c2kzuwf4vN27JsKutdNiScBG9kx0aZyJO2r1qyHZakpN7CqePYdDUzyvZZdFdAo4rtUj2sk6iCoVgwbj11KUXFUZYJo4ioBi/Pt7eSCOu5p7WUuR4dL1lhXcShJxCUK5Yp8vSQdDotYSGxeHXdmn4=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 817e1a52-e4eb-422d-45cf-08dc41ade8c4
X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB4313.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Mar 2024 09:30:37.2090
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 6BklTYt7zZTrIoDPMYFXZkKDw2WhW9IiaZsVgFPTWb0hMIDrvOLTRCcrlmTm5hPTPLO2MM39HKWO6vahSCSlzQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN4PR10MB5797
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-03-11_06,2024-03-06_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 mlxscore=0 spamscore=0
 bulkscore=0 phishscore=0 malwarescore=0 suspectscore=0 mlxlogscore=999
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000
 definitions=main-2403110070
X-Proofpoint-ORIG-GUID: ym-nuQJYlcG76nN9yamBzbk3geBmEq9n
X-Proofpoint-GUID: ym-nuQJYlcG76nN9yamBzbk3geBmEq9n

On 11/03/2024 08:54, mengfanhui wrote:
> By default, the host_tagset_enable feature is disabled，Fio performance
> has improved significantly
> 
> fio test command:
> sudo fio -filename=/fio_test -direct=1 -iodepth 32 -thread -rw=write -ioengine=libaio
> -bs=4K -size=5120M -runtime=600 -numjobs=$CPUN -group_reporting -name=**.result >> **.result
> 
> The test data results bw  are as follows：
>                v6.8_kernel       v6.8_kernel_disable_host_tagset
> 4k randwrite     375                     642
> 4k randread      210                     784
> 4k  write        306                     387
> 4k  read         435                     2457
> 128k write       355                     380
> 128k read        976                     3665
> 1M   read        415                     3122
> 

There are some huge differences in those numbers. Can you find out what 
is going on?

> Signed-off-by: mengfanhui <mengfanhui@kylinos.cn>
> ---
>   drivers/scsi/megaraid/megaraid_sas_base.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c b/drivers/scsi/megaraid/megaraid_sas_base.c
> index 3d4f13da1ae8..da19c4c07f2f 100644
> --- a/drivers/scsi/megaraid/megaraid_sas_base.c
> +++ b/drivers/scsi/megaraid/megaraid_sas_base.c
> @@ -123,9 +123,9 @@ MODULE_PARM_DESC(poll_queues, "Number of queues to be use for io_uring poll mode
>   		"High iops queues are not allocated &\n\t\t"
>   		);
>   
> -int host_tagset_enable = 1;
> +int host_tagset_enable;
>   module_param(host_tagset_enable, int, 0444);
> -MODULE_PARM_DESC(host_tagset_enable, "Shared host tagset enable/disable Default: enable(1)");
> +MODULE_PARM_DESC(host_tagset_enable, "Shared host tagset enable/disable Default: disable(0)");
>   
>   MODULE_LICENSE("GPL");
>   MODULE_VERSION(MEGASAS_VERSION);