Received-SPF: pass (google.com: domain of linux-kernel+bounces-98642-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <2b512404-bc56-41b8-89aa-dcbb23d7b2bd@quicinc.com>
Date: Mon, 11 Mar 2024 17:43:22 +0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 1/2] dt-bindings: pinctrl: qcom: update compatible name
 for match with driver
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        Linus Walleij
	<linus.walleij@linaro.org>,
        Rob Herring <robh+dt@kernel.org>
CC: <andersson@kernel.org>, <konrad.dybcio@linaro.org>,
        <krzysztof.kozlowski+dt@linaro.org>, <conor+dt@kernel.org>,
        <linux-arm-msm@vger.kernel.org>, <linux-gpio@vger.kernel.org>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <kernel@quicinc.com>
References: <20240129092512.23602-1-quic_tengfan@quicinc.com>
 <20240129092512.23602-2-quic_tengfan@quicinc.com>
 <CAL_JsqJfsWaj9OPkvc34rBvx7W_3v9+1kZqNu6QKDsA=iWAA4w@mail.gmail.com>
 <CAL_JsqLbbRFijBXS5CyRm0P4FMY7bR3UUdgXA7xP4Z1oRevnzQ@mail.gmail.com>
 <CACRpkdZ3uhyTnF7YkMk9sOeJJFZ4UPEna7PwpqPeBpWDdAmayA@mail.gmail.com>
 <e828b14c-7a09-479a-bf60-0c16571f133f@quicinc.com>
 <abebde71-ac9f-434b-b48b-6567308a2873@linaro.org>
From: Tengfei Fan <quic_tengfan@quicinc.com>
In-Reply-To: <abebde71-ac9f-434b-b48b-6567308a2873@linaro.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit


On 3/11/2024 2:48 PM, Krzysztof Kozlowski wrote:
> On 11/03/2024 03:27, Tengfei Fan wrote:
>>
>>
>> On 3/10/2024 7:44 AM, Linus Walleij wrote:
>>> On Fri, Mar 8, 2024 at 9:10 PM Rob Herring <robh+dt@kernel.org> wrote:
>>>> On Tue, Feb 27, 2024 at 7:37 AM Rob Herring <robh+dt@kernel.org> wrote:
>>>>> On Mon, Jan 29, 2024 at 3:25 AM Tengfei Fan <quic_tengfan@quicinc.com> wrote:
>>>>>>
>>>>>> Use compatible name "qcom,sm4450-tlmm" instead of "qcom,sm4450-pinctrl"
>>>>>> to match the compatible name in sm4450 pinctrl driver.
>>>>>>
>>>>>> Fixes: 7bf8b78f86db ("dt-bindings: pinctrl: qcom: Add SM4450 pinctrl")
>>>>>> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
>>>>>> Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com>
>>>>>> ---
>>>>>>    Documentation/devicetree/bindings/pinctrl/qcom,sm4450-tlmm.yaml | 2 +-
>>>>>>    1 file changed, 1 insertion(+), 1 deletion(-)
>>>>>>
>>>>>> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sm4450-tlmm.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sm4450-tlmm.yaml
>>>>>> index bb08ca5a1509..bb675c8ec220 100644
>>>>>> --- a/Documentation/devicetree/bindings/pinctrl/qcom,sm4450-tlmm.yaml
>>>>>> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sm4450-tlmm.yaml
>>>>>> @@ -17,7 +17,7 @@ allOf:
>>>>>>
>>>>>>    properties:
>>>>>>      compatible:
>>>>>> -    const: qcom,sm4450-pinctrl
>>>>>> +    const: qcom,sm4450-tlmm
>>>>>
>>>>> I think you forgot to update the example:
>>>>>
>>>>> Documentation/devicetree/bindings/pinctrl/qcom,sm4450-tlmm.example.dtb:
>>>>> /example-0/pinctrl@f100000: failed to match any schema with
>>>>> compatible: ['qcom,sm4450-tlmm']
>>>>
>>>> Still a warning in linux-next. Please send a fix.
>>>
>>> I understand it as applying 1/2 is the fix so I applied it.
>>
>> I will check this warning, and I will fix it.
> 
> Now? We were all waiting for you to respond here without any effect, so
> finally I asked Linus to take the patch. In the future, be responsible
> for your patches and comments happening to them. The same if your
> applied commit causes issues in the next.

I will speed up the upstream work of the sm4450.
Before that, I had been focusing on the work of AIM300.

> 
> Best regards,
> Krzysztof
> 

-- 
Thx and BRs,
Tengfei Fan