Received-SPF: pass (google.com: domain of linux-kernel+bounces-98653-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <d9d10da3-5b13-4a48-9236-d29fdf48220e@huawei.com>
Date: Mon, 11 Mar 2024 17:55:36 +0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
CC: <shaojijie@huawei.com>, <yisen.zhuang@huawei.com>,
	<salil.mehta@huawei.com>, <davem@davemloft.net>, <edumazet@google.com>,
	<kuba@kernel.org>, <pabeni@redhat.com>, <jiri@resnulli.us>,
	<shenjian15@huawei.com>, <wangjie125@huawei.com>, <liuyonglong@huawei.com>,
	<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V5 net-next 4/4] net: hns3: add support to query scc
 version by devlink info
To: Simon Horman <horms@kernel.org>
References: <20240309100044.2351166-1-shaojijie@huawei.com>
 <20240309100044.2351166-5-shaojijie@huawei.com>
 <20240311091904.GA24043@kernel.org>
From: Jijie Shao <shaojijie@huawei.com>
In-Reply-To: <20240311091904.GA24043@kernel.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit


on 2024/3/11 17:19, Simon Horman wrote:
>> +#define HNAE3_SCC_VERSION_BYTE1_SHIFT	8
>> +#define HNAE3_SCC_VERSION_BYTE1_MASK	GENMASK(15, 8)
>> +#define HNAE3_SCC_VERSION_BYTE0_SHIFT	0
>> +#define HNAE3_SCC_VERSION_BYTE0_MASK	GENMASK(7, 0)
> Not strictly related to this patch, but FWIIW, I suspect that
> hnae3_set_field() and hnae3_get_field() could be reworked to use / replaced
> by use of FIELD_PREP and FIELD_GET.  In which case I suspect that the
> *_SHIFT #defines would no longer be needed.

Yes, using FIELD_PREP and FIELD_GET is a better option.
But I'm not going to modify this patch.
If it's necessary, I will send a cleanup patch later to
replace all hnae3_set_field/hnae3_get_field in driver.