Received: by 2002:ab2:710b:0:b0:1ef:a325:1205 with SMTP id z11csp304965lql; Mon, 11 Mar 2024 03:22:47 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUxkZThK2zIixkDuH14+N2Eb1qumE4D9rrBOF3R62zT4t2fL7T0FjOTPd9KXPHgN6kYPqmkZXWtXZ0UBQTnO6rSEO2tWpz/n1oHcjs25A== X-Google-Smtp-Source: AGHT+IET7K/s/sPxTkQnMdQJFjV3F5JhaY6baPYpNTx6j3iSPVkmuoNKUPq+DeXriAscQOjCa/MI X-Received: by 2002:a17:907:d40d:b0:a46:166d:d0d8 with SMTP id vi13-20020a170907d40d00b00a46166dd0d8mr3054846ejc.64.1710152567403; Mon, 11 Mar 2024 03:22:47 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1710152567; cv=pass; d=google.com; s=arc-20160816; b=BWpHlPuFCaXTPLHWEOsLkH9gfU5uYqQQrjepMM2EMH2UGkG4du+kow2CyMBf8fdn+v gFvLZdUSuKw1+fnlrWU4t1CjVh7/E0lhO9mmHp2ZtQNx+h3eLef2G/ulM8/MYx/Gisgv FDMWI6fSnFCXurGRmOzzzQQmS9SahP8ozUMfW98BBJGHKmiT0+N5BgGXz0l6+k52h3jk x9Dslf6cPr9X/W/1Xgwgm970zaJQs2427yoNAHJVoIg73cTrjDHWm/Td88r+0U+APrlT aEu8R/y+CFvTCHDl7i9N1bAX5SvH2q0B6SaM7xsAbKG45FP4TKmXz8IuJXnKavXxraVa amsQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:dkim-signature; bh=YvzM3BBNPq7PQ1sKkJH5WYWafUPK5ZsWj/fFwcqWaJU=; fh=W6COFBd4BX4Q4YpnsinfP4Lifuq45kIfChsHXFM1YEQ=; b=08Qiq8qozDt6jxd4WZMCni8LkekV7LVblUCzIS1PCMKEUsc2ufChWaZr0K9miQJZAW yzNOp5oI1amiJ0Adck0/JqLhDKix3OhGybkEctEX7GHj7LfxVvLev0KFuU6IxSYIDh4J zFxUNm34/DRTO3FHbJI9U2xZmoGg1URl9HltXdlERqsKKbxjjCx7xcuGo3wU9PwKa8Zj x4+EnIs31HlmQFQ7HAhSCUfSWk3mZ/jYbdub2aSmsJKOayislDa82ft+qJZ+NF7boEKj p9SRHzESbYdf6qnAf6yEVKjlrXZT4hBgPzZibnlgyA+bBaaIUGjrAciXxGGmhl0Evgr4 DgCw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=st0YsnIN; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-98693-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-98693-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id qw39-20020a1709066a2700b00a44b9329951si2320303ejc.627.2024.03.11.03.22.47 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Mar 2024 03:22:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-98693-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=st0YsnIN; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-98693-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-98693-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 25EA21F2178E for ; Mon, 11 Mar 2024 10:22:47 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 24D532BB1A; Mon, 11 Mar 2024 10:22:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="st0YsnIN" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4DB66224D7 for ; Mon, 11 Mar 2024 10:22:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710152561; cv=none; b=cyEVPHGm4YQXHP4nRG0U3kCs5APWrkvgfzUTX/h5FU4A1Y3+uxJm9D2blDIsoqmykTX0jp7Tv/DXb7LkBP58uzW3ccW8JjzDDmvC2cvOyB1ctGNDXVpJO6yTOk8S8yfyckchlUF0kKdEn7hdam9qqRXtaHzPncjF5H+/nxKIQBE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710152561; c=relaxed/simple; bh=NNHHZLyZv26sgBeGxvdVNmM6HJZ5hj9Zl2HSEx5V0/o=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Q+wto1cK2S6IlWeIsMf9RgKfZ52nXz9weNdeCzNRZjraqmgmgAjTVxCBR1p99dmwXC2elOVYhkZn8fF1kUd6u7M/auoclMoUem7vh3wIXRdF4u6YR4XjJT/JhHfeOwn0NJKK0FAPXoEuaITGMErBmnSZHb1mlmeCgupLogmK6Lo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=st0YsnIN; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id E4B06C433F1; Mon, 11 Mar 2024 10:22:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1710152560; bh=NNHHZLyZv26sgBeGxvdVNmM6HJZ5hj9Zl2HSEx5V0/o=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=st0YsnIN8DGk5svq78mSzUHDC3atE+DJb36P7okTncDE9FmR1rqvKST3bgJya3zEM oMQJOKTyMi5spTD/HVc9cpSqAL5FO4Zr31VhUGOXZxf0LVryvMSo9DOqdT1QcRTlRe roY7k3mTBTMzxitaPXdiQFaEjxbjXSRr7hPNS6iapQYlhRaBa3GYh2/Lq/+FgfSkqp iisPjzvpm4Xy3y1z+vGBFVw6Uw8Hy/Fe3ssE30pj9UfnVeWNyMlNOQGWDeXe7pez81 Dd3GK7qpfd9PBnixfjmc702E1FZ9IDe/XYXNZE918RKD9lNNkDt4IEx+moF9+rYNIz CypmM57h/jlow== Message-ID: <9c68f756-5ac9-4074-a374-d62b6671f72b@kernel.org> Date: Mon, 11 Mar 2024 18:22:36 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH V2 2/2] f2fs: fix to handle error paths of {new,change}_curseg() Content-Language: en-US To: Zhiguo Niu , jaegeuk@kernel.org Cc: linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, niuzhiguo84@gmail.com, ke.wang@unisoc.com, hongyu.jin@unisoc.com References: <1710143334-27653-1-git-send-email-zhiguo.niu@unisoc.com> From: Chao Yu In-Reply-To: <1710143334-27653-1-git-send-email-zhiguo.niu@unisoc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2024/3/11 15:48, Zhiguo Niu wrote: > {new,change}_curseg() may return error in some special cases, > error handling should be did in their callers, and this will also > facilitate subsequent error path expansion in {new,change}_curseg(). > > Signed-off-by: Zhiguo Niu > Signed-off-by: Chao Yu Reviewed-by: Chao Yu Thanks,