Received-SPF: pass (google.com: domain of linux-kernel+bounces-98734-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Precedence: bulk
MIME-Version: 1.0
References: <20240307092104.937440-1-jens.wiklander@linaro.org> <ZerVwbT8cbXuzviy@lpieralisi>
In-Reply-To: <ZerVwbT8cbXuzviy@lpieralisi>
From: Jens Wiklander <jens.wiklander@linaro.org>
Date: Mon, 11 Mar 2024 12:00:53 +0100
Message-ID: <CAHUa44GVSFhdrsULSnn8KjG2LJJWEUVdVyaJwCOgH01QLaVFTw@mail.gmail.com>
Subject: Re: [PATCH] firmware: arm_ffa: fix ffa_notification_info_get()
To: Lorenzo Pieralisi <lpieralisi@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, 
	Sudeep Holla <sudeep.holla@arm.com>, Marc Bonnici <marc.bonnici@arm.com>, 
	Olivier Deprez <Olivier.Deprez@arm.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, Mar 8, 2024 at 10:09=E2=80=AFAM Lorenzo Pieralisi <lpieralisi@kerne=
l.org> wrote:
>
> On Thu, Mar 07, 2024 at 10:21:04AM +0100, Jens Wiklander wrote:
> > FFA_NOTIFICATION_INFO_GET retries information about pending
>
> s/retries/retrieves/
>
> > notifications. Notifications can be either global or per VCPU. Global
> > notifications are represented by the VM ID only, or 0 in the absence of
> > a hypervisor.
>
> I would just say "Global notifications are reported with the partition
> ID only in the list of endpoints with pending notifications".
>
> > ffa_notification_info_get() incorrectly expect no ID at all
> > for global notifications. Fix this by checking for 1 ID instead of 0.
> >
> > Fixes: 3522be48d82b ("firmware: arm_ffa: Implement the NOTIFICATION_INF=
O_GET interface")
> > Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>
> > ---
> >  drivers/firmware/arm_ffa/driver.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
>
> Reviewed-by: Lorenzo Pieralisi <lpieralisi@kernel.org>

Thanks, I'll update the commit message accordingly.

Cheers,
Jens

>
> > diff --git a/drivers/firmware/arm_ffa/driver.c b/drivers/firmware/arm_f=
fa/driver.c
> > index c183c7d39c0f..ff1f37a4b28c 100644
> > --- a/drivers/firmware/arm_ffa/driver.c
> > +++ b/drivers/firmware/arm_ffa/driver.c
> > @@ -790,7 +790,7 @@ static void ffa_notification_info_get(void)
> >
> >                       part_id =3D packed_id_list[ids_processed++];
> >
> > -                     if (!ids_count[list]) { /* Global Notification */
> > +                     if (ids_count[list] =3D=3D 1) { /* Global Notific=
ation */
> >                               __do_sched_recv_cb(part_id, 0, false);
> >                               continue;
> >                       }
> > --
> > 2.34.1
> >