Received-SPF: pass (google.com: domain of linux-kernel+bounces-98739-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Precedence: bulk
MIME-Version: 1.0
References: <20240310175217.20981-1-animeshagarwal28@gmail.com>
 <448f9d20-8b45-4794-9440-89d6a6888aee@linaro.org> <011b7c4c-ae44-41eb-b7eb-1a71da669f26@linaro.org>
 <CAE3Oz82ZC5Vz125iLzjsdvZd1YLd4YgQsrGPgTRJ=ugEc=e=Ow@mail.gmail.com> <087db56b-13c3-4624-b3a3-f02989aa5409@kernel.org>
In-Reply-To: <087db56b-13c3-4624-b3a3-f02989aa5409@kernel.org>
From: Animesh Agarwal <animeshagarwal28@gmail.com>
Date: Mon, 11 Mar 2024 16:37:44 +0530
Message-ID: <CAE3Oz80ef3ESw3cus9wyGy2RrMfJWDAd7zkokUPZkTgLR3m5WQ@mail.gmail.com>
Subject: Re: [PATCH v6] dt-bindings: imx-pata: Convert to dtschema
To: Damien Le Moal <dlemoal@kernel.org>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>, Rob Herring <robh+dt@kernel.org>, 
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, 
	Shawn Guo <shawnguo@kernel.org>, Sascha Hauer <s.hauer@pengutronix.de>, 
	Pengutronix Kernel Team <kernel@pengutronix.de>, Fabio Estevam <festevam@gmail.com>, 
	NXP Linux Team <linux-imx@nxp.com>, linux-ide@vger.kernel.org, devicetree@vger.kernel.org, 
	linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, Mar 11, 2024 at 9:39=E2=80=AFAM Damien Le Moal <dlemoal@kernel.org>=
 wrote:
> It is simple: the commit message should always explain *WHAT* you did and
> *WHY*. This is to give some context to reviewers and to help with checkin=
g that
> your code actually does what you explained. This also helps with potentia=
l
> future issues with a change as the commit message remains in the git log =
history.
>
> Regardless of the version of your patch, always have the what & why expla=
ined
> in your commit message. This implies that the commit message must change =
if the
> patch content changes between versions. Keep in mind that the changelog a=
dded
> to a patch is lost when the patch is applied, but the commit message rema=
ins.

Thank you for your feedback and guidance.
Your advice regarding the necessity of explaining both the *WHAT* and
*WHY* behind each change is duly noted. Moving forward, I will ensure
that my commit messages provide comprehensive context to facilitate
smoother reviewing processes and to maintain a clear log history for
potential future issues.

Thanks & regards,
Animesh