Received-SPF: pass (google.com: domain of linux-kernel+bounces-98771-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
From: Subbaraya Sundeep Bhatta <sbhatta@marvell.com>
To: Breno Leitao <leitao@debian.org>, "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>,
        Paolo
 Abeni <pabeni@redhat.com>
CC: "keescook@chromium.org" <keescook@chromium.org>,
        Ido Schimmel
	<idosch@nvidia.com>,
        Nikolay Aleksandrov <razor@blackwall.org>,
        Amit Cohen
	<amcohen@nvidia.com>, Petr Machata <petrm@nvidia.com>,
        Jiri Benc
	<jbenc@redhat.com>, Beniamino Galvani <b.galvani@gmail.com>,
        Gavin Li
	<gavinl@nvidia.com>,
        "open list:NETWORKING DRIVERS" <netdev@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>
Subject: RE: [EXTERNAL] [PATCH net-next 2/2] vxlan: Remove generic
 .ndo_get_stats64
Thread-Topic: [EXTERNAL] [PATCH net-next 2/2] vxlan: Remove generic
 .ndo_get_stats64
Thread-Index: AQHac6bXZtyIJKjPJ0W06FQgEfQfJbEyaStg
Date: Mon, 11 Mar 2024 11:36:14 +0000
Message-ID: 
 <CO1PR18MB4666DBAAE72E169E647528FDA1242@CO1PR18MB4666.namprd18.prod.outlook.com>
References: <20240311112437.3813987-1-leitao@debian.org>
 <20240311112437.3813987-2-leitao@debian.org>
In-Reply-To: <20240311112437.3813987-2-leitao@debian.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?us-ascii?Q?iCftmHzvf3AWdeQA+/L1XTzeIEYJLpvtgWS2ooIy05B+iMvCTcuiE3ytfTu2?=
 =?us-ascii?Q?50LGqFd+XbLsRqq+9Nzl8KtZRITiYgeCEXBZCz21lRoTgE3pHcoVjiak9ut/?=
 =?us-ascii?Q?xXRH/tpjPA3qBzobj92bcU0vQdrn4ZHOq6mp1x+LSAl8rXPsUmB+xxRBuoRn?=
 =?us-ascii?Q?d77OVQPgPieZcVXr5CP0lEMTTiA67JNAq2wKeVesLBh+NrQa45tbnfySVhIo?=
 =?us-ascii?Q?8MStPeI1GSwBR9CZklTNHVTYO0xNtotyFeeS2np/Q2tDymuo9ird4s1GwTuX?=
 =?us-ascii?Q?hhOyo1nkSa9V3qJhDvloSC/ezH07V/ad92oko66tuYAjv28wZIBxWO8CeRVJ?=
 =?us-ascii?Q?uInC4BrlturOufxG86wH2hW04sqmdhi2kAymoeVRh2+08sNlMhlXIeMthvrW?=
 =?us-ascii?Q?LYvvroRdufB8q3teee+gcV2/OgP5Z3ZBDzE/H53muw4mULkNrH2mYz+a33kd?=
 =?us-ascii?Q?ROgg+OxViKiPXgPk03GS8peVEUuAozcevJiNp8rKEwF47HUAHDFw8NLsZp8n?=
 =?us-ascii?Q?Ht31VflsWd8d+3fUB8wfq97RQp6PMFp2fVhVaaNxnyMcXNi3ax4QsDni5RnP?=
 =?us-ascii?Q?2buKmoCM514ZHHoLy9DHBqyt4F9Ob3A51tmoKt8rXOfXqLWn7A6RluXZq1+K?=
 =?us-ascii?Q?DLpK7PjLuHVv23h/K0YDPkWAyMsfcF4QvTCrsuTHC5wB55P0gLPg+1hODxm5?=
 =?us-ascii?Q?7zOapbeiIzvcwj5yAItgnurVZ802nRb1S9VqL0EsorVLqROB6EvrR1t5ULNl?=
 =?us-ascii?Q?ALM2VCmaC0X/Zlv8XYxo1rvr5bazP0cYY/44EOZNjkceXksRtscET+GbEG/t?=
 =?us-ascii?Q?P/w3WKRPW2oMnkcFrdbiDpmKtFeA9M91jyqEqsB+qeKZ4UaIV4sPGfVBtwy+?=
 =?us-ascii?Q?ZFU/bao7K/fB6/CljfWWOB/zdR+UAOUcPiOHaWMXN1Cmzo2Omm9zrojpjd8j?=
 =?us-ascii?Q?DlDYpJ23ogi0gFIjEUsM2vBP2eqRAMvA6QApZMcEGmNuI0Eyyd0ca8Hd4RHh?=
 =?us-ascii?Q?014ztTe4Wvr28m9giEicQBnldRTj0MbMw82eo7wkkjMcrU2KrwrUvZhfd/Th?=
 =?us-ascii?Q?W6VTE8CZisnvLDTX1heR7TAVy51OyvAX3oIXORBq0xPj02QKNmGXMxLEdScr?=
 =?us-ascii?Q?DgfQ5G2a+AmOkP4/b78P2lpWhByzOcKqP2S5VTrf6bbrTfvbR2ECksrJtl6f?=
 =?us-ascii?Q?eM6W5FITU2oYqWeV2L1Hc6Xlk2ZwDp442xhCRNUqHLIP9VqQ1dHxPH+hGkkH?=
 =?us-ascii?Q?Rly+DrDgacKnRKsq+ADvHWWhTPJK7HIQVjtN9DWp4sLSljJz3hnclXPinaST?=
 =?us-ascii?Q?MKmMfN2IoJhLo9xtni1UqX4oaf3IOZQeBmlGZNZ7jOcrK9lz11/My1HfJuKM?=
 =?us-ascii?Q?9y1yY8LW+5ZUyn/wNZE94WoYgntDyH7h2Zhk6Yocm4B+2rD2+u9qt4SdmZgQ?=
 =?us-ascii?Q?Y7YTO2jlRQ0jGID3g9o4n+sixwRsft1ImmUb8z6+8LmGQNMcmzQ0eY+fq8gW?=
 =?us-ascii?Q?sLZNZHLXWqr8mRzDGiL65vlpVmvI7nNvomoqBMqZr4+vI7n1lb0YF5uk4lVc?=
 =?us-ascii?Q?iQkglbP621uG8brmKEPgTBOC4zuwjD5BqpDQm4rr?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CO1PR18MB4666.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 271d2dfa-6371-4ee4-40b1-08dc41bf7564
X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Mar 2024 11:36:14.3306
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: c6tlo/qbDGRhqTAAyWZ+ljaiJm9QihZvOoB4dYj9cdecQZARchYqrZWqRobP6HflncHCa0ftZfm50A6cXCrZJg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR18MB4972
X-Proofpoint-GUID: feAOewRNjEg4GUsbYZUUe8i7ZUqLcczQ
X-Proofpoint-ORIG-GUID: feAOewRNjEg4GUsbYZUUe8i7ZUqLcczQ
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-03-11_08,2024-03-06_01,2023-05-22_02


>-----Original Message-----
>From: Breno Leitao <leitao@debian.org>
>Sent: Monday, March 11, 2024 4:55 PM
>To: David S. Miller <davem@davemloft.net>; Eric Dumazet
><edumazet@google.com>; Jakub Kicinski <kuba@kernel.org>; Paolo Abeni
><pabeni@redhat.com>
>Cc: keescook@chromium.org; Ido Schimmel <idosch@nvidia.com>; Nikolay
>Aleksandrov <razor@blackwall.org>; Amit Cohen <amcohen@nvidia.com>; Petr
>Machata <petrm@nvidia.com>; Jiri Benc <jbenc@redhat.com>; Beniamino
>Galvani <b.galvani@gmail.com>; Gavin Li <gavinl@nvidia.com>; open
>list:NETWORKING DRIVERS <netdev@vger.kernel.org>; open list <linux-
>kernel@vger.kernel.org>
>Subject: [EXTERNAL] [PATCH net-next 2/2] vxlan: Remove generic
>.ndo_get_stats64
>
>Commit 3e2f544dd8a33 ("net: get stats64 if device if driver is
>configured") moved the callback to dev_get_tstats64() to net core, so,
>unless the driver is doing some custom stats collection, it does not
>need to set .ndo_get_stats64.
>
>Since this driver is now relying in NETDEV_PCPU_STAT_TSTATS, then, it
>doesn't need to set the dev_get_tstats64() generic .ndo_get_stats64
>function pointer.
>
>Signed-off-by: Breno Leitao <leitao@debian.org>

Reviewed-by: Subbaraya Sundeep <sbhatta@marvell.com>
..