Received-SPF: pass (google.com: domain of linux-kernel+bounces-98782-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Mon, 11 Mar 2024 12:49:39 +0100
From: Maciej Wieczor-Retman <maciej.wieczor-retman@intel.com>
To: Rex Nie <rex.nie@jaguarmicro.com>
CC: "james.morse@arm.com" <james.morse@arm.com>, "fenghua.yu@intel.com"
	<fenghua.yu@intel.com>, "reinette.chatre@intel.com"
	<reinette.chatre@intel.com>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>, Liming Wu <liming.wu@jaguar.com>
Subject: Re: =?utf-8?B?562U5aSN?= =?utf-8?Q?=3A?= [PATCH] fs/resctrl: fix
 domid loss precision issue
Message-ID: <3fjeeggediya7cl26snya5o5oif6x2xfd26qmsvroe6jygtufu@whanfahntydy>
References: <20240311064822.891-1-rex.nie@jaguarmicro.com>
 <2u7eg2khp2zrcmbfpnh6ighxqbttv2w7giwdxlkndeywpgq2bq@2lccnqwkbo65>
 <KL1PR0601MB577303C9D0B1247436BB06F8E6242@KL1PR0601MB5773.apcprd06.prod.outlook.com>
Content-Type: text/plain; charset="iso-8859-1"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <KL1PR0601MB577303C9D0B1247436BB06F8E6242@KL1PR0601MB5773.apcprd06.prod.outlook.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?5CJjlWX+N+TH81QzBFBW8pF1EE1V7aM73mZzHU8dTtU+5uB1M/nftTfezy?=
 =?iso-8859-1?Q?hoIM6vxTIumz1UFRrQaBu4TIRi2eKwoSrPmef7+DDKIOELEBnVtbfv+rod?=
 =?iso-8859-1?Q?Oo/1f22s4zsjLHcdvuWGqsSHxQ8K5+ec5FgrvWEMphl52B536BNfRuDKsw?=
 =?iso-8859-1?Q?RHF03aTK3gWFAyuOgvF9wFYy6y+ZfCmho7pMP+dKB8gYu4wRpgak36ApMr?=
 =?iso-8859-1?Q?GyZqbgZ64mVHzMFjUdTDrACpMmZP6NJrIp4/oM8mpCRsIN5QDwxy9Z8HfQ?=
 =?iso-8859-1?Q?Eswjkw/Z5Thm+aVbOWK6bVynnYZCk43kh0JvzqME9hdkLSSl+1FoMA1qLK?=
 =?iso-8859-1?Q?DXZU3c2PAs8qLihnm6TFr/7uZpy8ZDAIUs7lwHyCZVHHywC3heiWw/t8ec?=
 =?iso-8859-1?Q?JLqI/bxB3WX3v/mQx9bnaFrg+bU/GNfY38VRewGqojRAGX0G3BoVhZM9JK?=
 =?iso-8859-1?Q?PdLA/VOwfj4BGZgQAQ55urXaD21wurGjcWSlGXcJW+STf8YMFs1GxUxkcg?=
 =?iso-8859-1?Q?KKiqw1A9wEjwd9rRydMqTFjEkajaId0M+X4rsnpN5mAf8IaM4MjTabk47K?=
 =?iso-8859-1?Q?oN3qCNptQyiHCmtabLvOuRA4uTSnD+TNQYzjQ3eeRAtcxN4Y6cCFXpN4nx?=
 =?iso-8859-1?Q?Qtc6PybRhsi/oxzMn7ftRcopRkFdQZEPzdzLpYFtCfWiwhkTihTJGKUbEG?=
 =?iso-8859-1?Q?W0nDtibb1/gunrckybKesTSIh9Lzh8mmMHZVQKSG1zi45E552NArHlFckX?=
 =?iso-8859-1?Q?4Ys7kZORgkdLgUeBnjgvEhLS4yGu/8R7+OJKCBtlg/wrBA7mpA68Avt5RE?=
 =?iso-8859-1?Q?lu/dbEpDZekpx1kHtEFQv6Eg9JG0au4M3qB03CxzxixxdrBcg/N1rcUteu?=
 =?iso-8859-1?Q?6+Fl68il4AOURNDyzijWocEjnO9FE/fMtnIt+rN0tcuAqsR8GThNWKsXxy?=
 =?iso-8859-1?Q?rI+AvkfUxMRQWK+yX9+wUzK0oMgjbArmm+722v6ph4xqFYvIWbVKAuufm2?=
 =?iso-8859-1?Q?LbJzZRggdeD4OoAXlRGehT86YoIr1kusjGQ5ja6Af8B/aH8Ipyn2aQNuLs?=
 =?iso-8859-1?Q?kyTZC2nzVY1RIA8uBjJlUb/0tI0xtNwz+9sR4MUjB1jgshtoqAlDfd8vSb?=
 =?iso-8859-1?Q?Oxj9Rbdv+DYkBCSsqNRV+kWRtjBqJu1otMBrnC1kw9sgd/3kO8PFP7BMb9?=
 =?iso-8859-1?Q?NIwcGAXVhxEThLzLcHbCKZgOd4qY3jJlVDi9AzAylyqJLT98kk4uZc3/5B?=
 =?iso-8859-1?Q?QctI9Tij54kLKIDNFDpn/tmS154Ro4em9N5m9cZ2o2f/BLQMrphh1ZdSvS?=
 =?iso-8859-1?Q?rUJ31keL0CtWGp2lVNjJCw4I2wgqkt17i5CteKYYmArViweg+wVSQS4ZbQ?=
 =?iso-8859-1?Q?yUjRkiqcmeMj6Q7o8gfLOmkammc6V68NRheLbKDcTE3j6EgVF8xFZuAPHE?=
 =?iso-8859-1?Q?QDxIjq1IjHma3SfkmNWZ8tqaMZybwZTFEUVrGMXk/b9rWibiW8wQqPVcjU?=
 =?iso-8859-1?Q?d9NzAQYaVxQmosiVcepYsAt5Szl2f0C8a3vRfQNBabjXqSw18IHUyHOtNo?=
 =?iso-8859-1?Q?vxU0GgwnAUxFWYUvVNIvbywBWyPf1wXN+YxbE/SAZQylWWaLY6l237Mffl?=
 =?iso-8859-1?Q?eVJfRaYL1lSrNKKcbM6Tfm2ENQGuyShyqiAVDzHr8RFZCXMMPPmqRPSusG?=
 =?iso-8859-1?Q?FaDkNPTBKcnB4Om9btk=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 7934a4fa-3a48-4f82-26bb-08dc41c1686a
X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6231.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Mar 2024 11:50:11.7771
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: SBGpUj+QFeip+F9UhhKWRLi2JF52E3XqiIiSMmWJ+M1k2G1H1ZzlSy3I8I4WA7ecTUNq8I8qcvneMWM8tqlPaAIYCTKpSsl8SdgmgLUbovE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV3PR11MB8694
X-OriginatorOrg: intel.com

Thanks for the reply,

On 2024-03-11 at 09:37:37 +0000, Rex Nie wrote:
>Hello,
>	Please kindly check my inline reply. Thanks.
>Best regards
>Rex Nie
>
>> >This will cause below issue if cache_id > 0x3fff likes:
>> 
>> Is there some reason for cache_id ever being this high?
>> 
>> I thought the max for cache_id was the amount of L3 caches on a system. And I
>> only observed it going up to 3 on some server platforms. So not nearly in the
>> range of 0x3fff or 16k.
>> 
>It is exactly as you said on X86 platforms, but cache_Id on Arm platform is different.
>According to ACPI for mpam, cache id is used as locator for cache MSC. Reference to RD_PPTT_CACHE_ID definition from edk2-platforms:
>#define RD_PPTT_CACHE_ID(PackageId, ClusterId, CoreId, CacheType)         \
>	(                                                              \
>	  (((PackageId) & 0xF) << 20) | (((ClusterId) & 0xFF) << 12) |              \
>	  (((CoreId) & 0xFF) << 4) | ((CacheType) & 0xF)                        \
>	)
>So it may be > 0x3fff on Arm platform.
>
>Reference RD_PPTT_CACHE_ID from edk2-platforms: https://github.com/tianocore/edk2-platforms/blob/master/Platform/ARM/SgiPkg/Include/SgiAcpiHeader.h#L202

and thanks for clearing it up for me! I browsed some MPAM patches but didn't
notice cache_id was used differently on ARM.

>
>> >/sys/fs/resctrl/mon_groups/p1/mon_data/mon_L3_1048564 # cat
>> >llc_occupancy
>> 
>> How did you get this file to appear? Could you maybe show how your
>> mon_data directory looks like?
>> 
>I found this issue on Arm FVP N1 platform and my N2 platform.
>
>Below is the steps on Arm FVP N1:
>mount -t resctrl resctrl / /sys/fs/resctrl
>cd /sys/fs/resctrl/mon_data
>
>/sys/fs/resctrl/mon_data # ls -l
>total 0
>dr-xr-xr-x    2 0        0                0 Mar 11 09:24 mon_L3_1048564
>
>cd /sys/fs/resctrl/mon_data # cd mon_L3_1048564
>/sys/fs/resctrl/mon_data/mon_L3_1048564 # cat llc_occupancy
>cat: read error: No such file or directory
>
>Arm FVP MPAM: https://neoverse-reference-design.docs.arm.com/en/latest/mpam/mpam-resctrl.html#memory-system-resource-partitioning-and-monitoring-mpam
>

-- 
Kind regards
Maciej Wiecz?r-Retman