Received-SPF: pass (google.com: domain of linux-kernel+bounces-98785-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Mon, 11 Mar 2024 14:00:17 +0200
From: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
To: 
	Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
Cc: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, 
	dave.hansen@intel.com, hpa@zytor.com, seanjc@google.com, ele.reshetova@intel.com, 
	rick.p.edgecombe@intel.com, x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] x86/tdx: Introduce tdg_vm_wr()
Message-ID: <7fyh7qsx6guodh7vxs4luxrh25gdk4ze4cwlg4q2m7ukyqt5ht@t3a7hz2pohdt>
References: <20240309210230.239045-1-kirill.shutemov@linux.intel.com>
 <20240309210230.239045-2-kirill.shutemov@linux.intel.com>
 <CAC41dw-ptOjRuOLefeu2-k_K1sigKVNxRxh+-9SHNooMfH660A@mail.gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAC41dw-ptOjRuOLefeu2-k_K1sigKVNxRxh+-9SHNooMfH660A@mail.gmail.com>

On Sat, Mar 09, 2024 at 04:02:58PM -0800, Kuppuswamy Sathyanarayanan wrote:
> > +       /* Old value */
> > +       return args.r8;
> 
> Since the update failure will panic, any use for returning the old value?

I don't have any immediate users for the old value, but I can imagine
situation when you need to do something else if your write result in
actual change of setting.

-- 
  Kiryl Shutsemau / Kirill A. Shutemov