Received-SPF: pass (google.com: domain of linux-kernel+bounces-98797-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
From: =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>
Date: Mon, 11 Mar 2024 14:05:29 +0200 (EET)
To: Kate Hsuan <hpa@redhat.com>
cc: Pavel Machek <pavel@ucw.cz>, Lee Jones <lee@kernel.org>, 
    linux-leds@vger.kernel.org, platform-driver-x86@vger.kernel.org, 
    Hans de Goede <hdegoede@redhat.com>, 
    =?ISO-8859-15?Q?Andr=E9_Apitzsch?= <git@apitzsch.eu>, 
    LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4 0/2] KTD2026 indicator LED for X86 Xiaomi Pad2
In-Reply-To: <20240306025801.8814-1-hpa@redhat.com>
Message-ID: <fc522d02-d1e9-22e8-6cbd-8a8d66e3ba77@linux.intel.com>
References: <20240306025801.8814-1-hpa@redhat.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Wed, 6 Mar 2024, Kate Hsuan wrote:

> This patch added the support for Xiaomi Pad2 indicator LED. This work
> included two parts.
> 1. Added the KTD2026 swnode description to describe the LED controller.
> 2. Migrated the original driver to fwnode to support x86 platform.
> 
> Moreover, the LED trigger is set to bq27520-0-charging for Xiaomi Pad2
> so the LED will be turned on when charging.
> 
> --
> Changes in v4:
> 1. Fix double casting.
> 2. Since force casting a pointer value to int will trigger a compiler
>    warning, the type of num_leds was changed to unsigned long. 
> 
> Changes in v3:
> 1. Drop the patch "leds-ktd202x: Skip regulator settings for Xiaomi
>    pad2"
> 
> Changes in v2:
> 1. Typo and style fixes.
> 2. The patch 0003 skips all the regulator setup for Xiaomi pad2 since
>    KTD2026 on Xiaomi pad2 is already powered by BP25890RTWR. So, the
>    sleep can be removed when removing the module.
> 
> Kate Hsuan (2):
>   platform: x86-android-tablets: other: Add swnode for Xiaomi pad2
>     indicator LED
>   leds: rgb: leds-ktd202x: Get device properties through fwnode to
>     support ACPI

Hi,

I took the patch 1/2 now into pdx86/review-ilpo where it will propagate 
into pdx86/for-next.

-- 
 i.