Received-SPF: pass (google.com: domain of linux-kernel+bounces-98841-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Mon, 11 Mar 2024 13:47:40 +0100
From: Christian Heusel <christian@heusel.eu>
To: David Woodhouse <dwmw2@infradead.org>, 
	Richard Weinberger <richard@nod.at>, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] jffs2: print symbolic error name instead of error code
Message-ID: <b4oa6jak7f4hiaqcqpmasclaylqdhdzgne75a6nol6z33d4o7z@3soexkn4smz4>
References: <20240211003907.167891-1-christian@heusel.eu>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="u36om64zlux4crqa"
Content-Disposition: inline
In-Reply-To: <20240211003907.167891-1-christian@heusel.eu>
UI-OutboundReport: notjunk:1;M01:P0:TOIz44WZJa0=;MyS8RxB+EdiCl7XJkSIX7TNN68R
 QR0+dCPy7Ia6LsNvV4aH8k8eImoWzIgIkgkLxtx1w1aNxkX2AMEw3y4AnTdYij7QaSEmmyywq
 C5AA7lQJz/H4Vi4TTuXXpe5wAororgN+gXaDULqCOSaxnj3lAEKzG5H4ZhYklAKwGY6bthTpU
 aHuBDO6wf56WnGtyjKLaeljkfUuSGQdnJf8A5OuexRyNkc66/pnjSLcJnaw0ldGz9ARbxbKp3
 D09DfMkwtVFXAFlftCPqkMxNfgBCsaoAwmLod4w6CFtKJo/EOHl6WUlEHRVmbNUgouxDKLGZv
 wDNDv1fkG8lUqR+GFRXjpzeJVwOPEXHKWW6fmbKgfZNOQFoGrc8m4ImN6VuEbKfm8zFNPKQf9
 YHt5ABl9GSZ7PxbCWrne6PLC9XdD5HHQ1tYPXAOUOGA94+ko4x4XBcnhNu7GHPaLKMwnCuqUM
 b+TAc4cKUN58gCkKwfAIFd0/Kl848UphxeepAog3UAgmfboa/SRvYxiFUfVsh4z65QjgNUi/V
 Uvc5XtMhXKtV+U8etV59FhcdclLYAUpDAQPYuE9bGN8Lh4b7RZniCWt32NM0Cgr5HG4HFLZ0b
 2KNJLNES/R29kw2kNm9u35/lMU2vbVUld3JoiFC/7nQ0CCCsITvGeDqexBC4AfMH5TcTaDncI
 FxODoaTTpU5fZMvSIxTkAf8IdrR6bfrhCnu4l/MpT3FdGKGowcuDyKE+3mFZZjLaAknXpjwTo
 W/Pj4vQLFRT32dJNqIjkKQYFPMgfIco42ZQzWOsJt2JrVG3KsbGzIM=


--u36om64zlux4crqa
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 24/02/11 01:39AM, Christian Heusel wrote:
> Utilize the %pe print specifier to get the symbolic error name as a
> string (i.e "-ENOMEM") in the log message instead of the error code to
> increase its readablility.
>=20
> This change was suggested in
> https://lore.kernel.org/all/92972476-0b1f-4d0a-9951-af3fc8bc6e65@suswa.mo=
untain/
>=20
> Signed-off-by: Christian Heusel <christian@heusel.eu>
> ---
>  fs/jffs2/background.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>=20
> diff --git a/fs/jffs2/background.c b/fs/jffs2/background.c
> index 6da92ecaf66d..bb0ee1a59e71 100644
> --- a/fs/jffs2/background.c
> +++ b/fs/jffs2/background.c
> @@ -44,8 +44,8 @@ int jffs2_start_garbage_collect_thread(struct jffs2_sb_=
info *c)
>=20
>  	tsk =3D kthread_run(jffs2_garbage_collect_thread, c, "jffs2_gcd_mtd%d",=
 c->mtd->index);
>  	if (IS_ERR(tsk)) {
> -		pr_warn("fork failed for JFFS2 garbage collect thread: %ld\n",
> -			-PTR_ERR(tsk));
> +		pr_warn("fork failed for JFFS2 garbage collect thread: %pe\n",
> +			tsk);
>  		complete(&c->gc_thread_exit);
>  		ret =3D PTR_ERR(tsk);
>  	} else {
> --
> 2.43.1

Friendly ping on the above patch, since it's now a month after sending
it :)

Cheers,
chris

--u36om64zlux4crqa
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEb3ea3iR6a4oPcswTwEfU8yi1JYUFAmXu/WwACgkQwEfU8yi1
JYWNaBAA3O92OboqsUyaSWRqJ+1aXC2lC2cHWCQnaLE8/tlW8wIlA6FPrZKkO6h3
TxxzZo8TPzpZgaUzkOlZps5CjOYQNzx1axbm2WXkrj44oHbmavq+Zj7ehSjdvwMW
P5foTpyJJt6mwBgaKv8I3WIR8utjV8AyMLsjPtSayYcvBtsmZxJyPcY38On7JuSH
mNegCXTkBorj2R3Rzm8ijWCIA39Bc5HCpdk03cx8T2+2+3BcTZ9HH8nFA+qIXd5H
wTN+iQjdxHE/+yMqaExoRFWM5C4lLk5ub38j2d2VzBY6sIfDBzGmwRcfmapofAsG
tj1NyYCB2Oe1dA2cr5BZ7CrIh5CTHRPSgOMSkJIItet0jmTrtyndfocmsSEzsKoM
A/QC0bGK8M/7APTBjY5YY6FFBpZlIWkfCP2cdk/EmYuPLhU+UuJHdl9difcIClik
nmdptzAGu4uBsHqDQShnTxPUkaGi4geeY5QM2ylxtYIsd0aH198GDF6BO26UPRmg
c8r0RcqTJ19Jeyb87waHKDqejKlkMFm1/tM5LU9U0aGr43TmFJ6Xky5YJ7hOp5Gr
ZAU7gUXUwXmB0qs96+Hl6lU4PISIkb8FPmqYLRf57mxMhSyRuz7k1fyYlstzfGCB
vwIkWhSLK+/ZYmSsyumqyhCOxdtT+QWpMJfA68OQcvlv7cRqUqk=
=EQU3
-----END PGP SIGNATURE-----

--u36om64zlux4crqa--