Received-SPF: pass (google.com: domain of linux-kernel+bounces-98895-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <6568ada1-7fee-457c-871f-b52ee3f7c820@intel.com>
Date: Mon, 11 Mar 2024 14:42:24 +0100
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 net-next] ptp: Move from simple ida to xarray
Content-Language: en-US
To: Kory Maincent <kory.maincent@bootlin.com>, Jakub Kicinski
	<kuba@kernel.org>, Simon Horman <horms@kernel.org>, <netdev@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
CC: <thomas.petazzoni@bootlin.com>, Richard Cochran <richardcochran@gmail.com>
References: <20240311092101.1114687-1-kory.maincent@bootlin.com>
From: Przemek Kitszel <przemyslaw.kitszel@intel.com>
In-Reply-To: <20240311092101.1114687-1-kory.maincent@bootlin.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VXpLWjBFS3dPNU5uUmdZcU9sSVVYQ1hzUWluZlB0aUJZNUc2a3RRSUIydFBp?=
 =?utf-8?B?dHN0bGNWdTFCbTVEVHpqcExSYzVJbCtkK0FydnA3QVFvY1lSeTVRam1kcytl?=
 =?utf-8?B?MWhIanY1blhud0xSTVBENmhOWjJLNUNaQWxEbGZWQnlnODgrbVBTalBtbElv?=
 =?utf-8?B?T1pHSkoySTdhL2luempUUTBxTzIwNWpqSXZhV2k3VHNlTXFCREdjcGhGaUFi?=
 =?utf-8?B?Q1lIUE56dGIwb0pxZVpRNVM0QWxMRE5uRmpST2hzZm14Tk9PQXlhWGZNN0F0?=
 =?utf-8?B?T00yQVlTMFk3WWFMN0FYQ3dKSExJTnJMUWRWd1JFL0tpN25SNmRRUHFrcFVx?=
 =?utf-8?B?MmtFN0d2bmY4dXYzNHFOSWxwZnFwd0wyNWlTY2NnbDBRL0xnTy9Rb1U4dG5N?=
 =?utf-8?B?T2ZIR09iVzNHbzFWZ2lkTGhETnc5L1NMczlQZGJ2Y2RWYlE4cHNxZEYycktX?=
 =?utf-8?B?T1NIUmh2aWRIam5DcDFmVEQ3K1RlU3VCQ1Q2T1RUdk5IQVVjbVJBWXJYVVdy?=
 =?utf-8?B?QUR1YVNFNmZzQmhGeFVwZ1B4cDhoTnBsSzJxa25XejQ2VS9NdWl3cndmb2xl?=
 =?utf-8?B?cVk1aE5PMjQxQWg3S0M3bFkwWXZOSWcwZm9IN2lWR3dWdllsaXRQMDM3L2wr?=
 =?utf-8?B?RUFhWDAxV2UvM2FWc251QktuTmFkK1RRY09hUEtzL0VxUUZxeEU1VUd5UHdi?=
 =?utf-8?B?b0t6a08zc0h4RGRGaThORTFXb2NEMFhKa3NjbHNkeUZPM2xVM1RmUUgvVzl3?=
 =?utf-8?B?blBLbFFqQXFJcDJ5UVhya2NRSGRkVlhyczIxc21MbHhwMmtZZGR0WUVWU01Y?=
 =?utf-8?B?U1B4ZXBaZXBaU2NPOHVJdXlET2kwZWpReVhVWlJFeEswenBHTTlpK0R3U292?=
 =?utf-8?B?ZEEwQlk4V0g5MjZWWExCSGw1RFJzTjVSLzhwV2tha1oydnRrdjZtSWw1WENR?=
 =?utf-8?B?TU03NFh5emJuTDhBS1Q3OTA2eXAyTGRtNHk1V0xLcEVvRWU0Q1Y0R3BaQTdv?=
 =?utf-8?B?bVp1cHJOdHR6WXp1VWJ0VEI1eWV6N1dJWlFsc3dqejltVEE3b1lXeTVRZ2ZO?=
 =?utf-8?B?SENiQ0pMYTZyQXhOMHRWNFo1dnEvSzRzZGpjem5DemxuemQyb053MlBiTit2?=
 =?utf-8?B?UUZsMkhKdEZ0YmRtRU1sSDBsVW5JK2dEbGRSOTUzVmxGVmwreS9lU2xDV0NE?=
 =?utf-8?B?Sy9oY0NsR0hKdW9KcVVERWtNQ1NqTENOZG4zcXIxdGlaSGlnd0lCOVpDUjgw?=
 =?utf-8?B?T0xpZFgvNkJsY25UU0dSeUhYNUhnMlBVeHM3T0wwUDBMZ1RQbi9WTXd2YlZS?=
 =?utf-8?B?ZjI1TENLWHJqb0xLRFpOR0NjYmI1WTFGajNBaUcyY29RSEg4S3NEWE5nNjQx?=
 =?utf-8?B?TEhWNGtKV2N3ekhtQ254NW5kYWZsaVFSdEszTFFTTS80Y3VXMzZQQnJXU1p1?=
 =?utf-8?B?MlNMMlNxc1dQcTJZVTNBT2pybFd0N3NzQS9lSHpzQVdJNlRDbzhSU3FBdFRl?=
 =?utf-8?B?T0NPRUJVc3JudTdJR3dFUkpDSld0T1pkcVJ1YkVqQlNibitMZ3RrTzRoYUgr?=
 =?utf-8?B?cjF6dkZOWDM5WGxnNzI4QkloMVZ5UVl4djFyM0I2SVVsQXFCckRuOG9EbTlv?=
 =?utf-8?B?b3BTNlNJUURXQmdUZ2hUNlduZkcxYzZIa2VPeER4dkRCMGJxOHF5ejR6SUlG?=
 =?utf-8?B?eUd0Nk0veCtWKzYyRHJNSmVNZ2RIWDNRUExYSGwxQ09uQXR2azNoWlA2VDls?=
 =?utf-8?B?U0dHS3hWdzh6cHB0T21jc0pFN3lhbzRGa1BzR3d3NnpKMG5FLzZWNVhXbU1t?=
 =?utf-8?B?aGRkclNxVytKWHBkVExvVVQwTk9xUFNZOUU5NmVxUVA5VzVWWklJRVB6VSto?=
 =?utf-8?B?THdhWDdzUno1WGZER1BScEp2UWpiYllZNHM4RlF4MmhsVnhSaEF3bUFOOFlF?=
 =?utf-8?B?MDJHdU5lTTZMTUhqTHN6cHpnbVZJSUkvSlZ2MmdPa1RlcVZYQ0QxT0Z3a1Rk?=
 =?utf-8?B?bThKanZsbUcrM2I3QzlvYXR2R0xvNVZYYUdDeTduNXdKdHhWT2lmdExUNVRY?=
 =?utf-8?B?VWNyb3loYU1nTkp6Zk8yVjBzcWJMUDNMV3hMYXg3NmdxZGZNazYrRWx6NG9D?=
 =?utf-8?B?NTlJTGxHaHBRMkYwT21TcWo0UHJURFlOUWx4NUdlZHArbFQvSC8xWlFuMXVt?=
 =?utf-8?Q?v+2aHAijVlFzwK0a1+TsnxY=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 46eb70e1-7941-4297-ea91-08dc41d11974
X-MS-Exchange-CrossTenant-AuthSource: MN6PR11MB8102.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Mar 2024 13:42:31.2806
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 4Ecn58TRD5UMDq8r9sieV7RjMFfqXT2XgV58P4HMpuTjgtA8+KxLv3Zo0gk499gzSFMfcmluMejPsEGBArRUlA2T02vVgmjigK7t63xPjno=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB8210
X-OriginatorOrg: intel.com

On 3/11/24 10:21, Kory Maincent wrote:
> Move from simple ida to xarray for storing and loading the ptp_clock
> pointer. This prepares support for future hardware timestamp selection by
> being able to link the ptp clock index to its pointer.
> 
> Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
> ---
> 
> Change in v2:
> - Update an err value missing
> ---
>   drivers/ptp/ptp_clock.c | 16 ++++++++--------
>   1 file changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/ptp/ptp_clock.c b/drivers/ptp/ptp_clock.c
> index 3aaf1a3430c5..9339fd475df0 100644
> --- a/drivers/ptp/ptp_clock.c
> +++ b/drivers/ptp/ptp_clock.c
> @@ -31,7 +31,7 @@ struct class *ptp_class;
>   
>   static dev_t ptp_devt;
>   
> -static DEFINE_IDA(ptp_clocks_map);
> +static DEFINE_XARRAY_ALLOC(ptp_clocks_map);
>   
>   /* time stamp event queue operations */
>   
> @@ -201,7 +201,7 @@ static void ptp_clock_release(struct device *dev)
>   	bitmap_free(tsevq->mask);
>   	kfree(tsevq);
>   	debugfs_remove(ptp->debugfs_root);
> -	ida_free(&ptp_clocks_map, ptp->index);
> +	xa_erase(&ptp_clocks_map, ptp->index);
>   	kfree(ptp);
>   }
>   
> @@ -246,12 +246,12 @@ struct ptp_clock *ptp_clock_register(struct ptp_clock_info *info,
>   	if (ptp == NULL)
>   		goto no_memory;
>   
> -	index = ida_alloc_max(&ptp_clocks_map, MINORMASK, GFP_KERNEL);
> -	if (index < 0) {
> -		err = index;
> +	err = xa_alloc(&ptp_clocks_map, &index, ptp, xa_limit_31b,
> +		       GFP_KERNEL);
> +	if (err)
>   		goto no_slot;
> -	}
>   
> +	err = -ENOMEM;

here it looks weird (even if technically correct),
I would either move the err assignement down, just above next kzalloc()
call, or refactor function to use the following idiom:
   ptr = kzalloc(...)
   if (!ptr) {
       err = -ENOMEM;
       goto somewhere;
   }

(it's already is for @vclock_index field init)

Otherwise context is too small to tell what is the reason.

>   	ptp->clock.ops = ptp_clock_ops;
>   	ptp->info = info;
>   	ptp->devid = MKDEV(major, index);
> @@ -378,7 +378,7 @@ struct ptp_clock *ptp_clock_register(struct ptp_clock_info *info,
>   	list_del(&queue->qlist);
>   	kfree(queue);
>   no_memory_queue:
> -	ida_free(&ptp_clocks_map, index);
> +	xa_erase(&ptp_clocks_map, index);
>   no_slot:
>   	kfree(ptp);
>   no_memory:
> @@ -511,7 +511,7 @@ static void __exit ptp_exit(void)
>   {
>   	class_destroy(ptp_class);
>   	unregister_chrdev_region(ptp_devt, MINORMASK + 1);
> -	ida_destroy(&ptp_clocks_map);
> +	xa_destroy(&ptp_clocks_map);
>   }
>   
>   static int __init ptp_init(void)