Received: by 2002:ab2:710b:0:b0:1ef:a325:1205 with SMTP id z11csp424130lql; Mon, 11 Mar 2024 06:58:02 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCW88MoXQdomW7z3hhZzu3j7rWs2+uqAw4dkq/tO4mlL/xVLPLL9TVMo1TiVdKGIaWNcz4yszYGlgGsF4cQIQWm32Ybyo/2ohxWiMhFufw== X-Google-Smtp-Source: AGHT+IGH/EEldoSpcSs8PJcu7isn7Ugh2JHod8xFjbgj+wKzbpbhwkf5eOwLhHtIe71vkDYSrjNI X-Received: by 2002:a05:620a:10b9:b0:788:384e:9a7d with SMTP id h25-20020a05620a10b900b00788384e9a7dmr7788007qkk.22.1710165482713; Mon, 11 Mar 2024 06:58:02 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1710165482; cv=pass; d=google.com; s=arc-20160816; b=BPbWPY1uzr+P6q+GTYWsHP+op4wNY/7Z4w2+Zgul+40wIJwnGVYqpj7WI0CEi3npfm FOkDfk/fsG3DGHJt0I5MeXMQ6/o27PilkS08eo87IMSoIVx0ZJ3cz9TKOBAp4Qa93Mph Wyql+oKy5y+Xg3/GzcBNgrdsTbJ11duORgQaLICw3DSTe3bSbnBqHz1sDSs1YndBNVRj 8S63grQKeffKAYQU9CBsQlOrAh+8A9LlReDJnqi1+CgOFkwfk5vLTpDXS4IaNGNlkjje F/4t2RoTF1uQTtCm5/rz16CIsLNFDCksuF1tWQe5UNSQmG/9tK5x25b+mBWvRwiLJx61 3mUA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=LMXq/m0hqKjZszVjyjD0++MBWTgCPJKu1ehEfBrjypQ=; fh=gMv/aOp25kJ7F/iRUOircPfusc2hc2GfhdWHG94h6TY=; b=GPrUGLw24mfe6suYjNkuy0qE1HpE8NRQHg8Ll4zRFHfhC3qZmI6kHMu/6Lcj6YDZEi SEMYTj1xGRqLoegso9E1xYC428wvnRCKtNxQjk+EMLVn1GWHjnCr7zWCpbZqc1ggl0wv 4xUBcQsAX83G7Eftwl3jCZCYai3vvQUjp1dk3FauUsIYGPyCMub3ADef5mA/p85KVwlY Bb6yKX6qK3mtwozhtxkqT0/vMuWoeAJt1cqwmH6BS19Db9mMzzpVpYi83fbu/fhzKfRj ufWW/K73lvZGETYoRsbOfi3XaDyKNhwxKXsjawVPMRdvHWtkMM5h2aXOKINeOOVgu8II e0/w==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=fail header.i=@lechnology.com header.s=default header.b=fDIQDqKc; arc=pass (i=1 spf=pass spfdomain=lechnology.com dkim=pass dkdomain=lechnology.com); spf=pass (google.com: domain of linux-kernel+bounces-98926-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-98926-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id w11-20020a05620a444b00b0078870e613b4si1612457qkp.642.2024.03.11.06.58.02 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Mar 2024 06:58:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-98926-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=fail header.i=@lechnology.com header.s=default header.b=fDIQDqKc; arc=pass (i=1 spf=pass spfdomain=lechnology.com dkim=pass dkdomain=lechnology.com); spf=pass (google.com: domain of linux-kernel+bounces-98926-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-98926-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 3014F1C2276F for ; Mon, 11 Mar 2024 13:58:02 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 0E8B83FB2C; Mon, 11 Mar 2024 13:57:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=lechnology.com header.i=@lechnology.com header.b="fDIQDqKc" Received: from vern.gendns.com (vern.gendns.com [98.142.107.122]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BEDC03E491; Mon, 11 Mar 2024 13:57:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=98.142.107.122 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710165475; cv=none; b=akQGhCma20hbPys8kqdSz8Hq7TFjVVHUX+dBsHIhom6oenYl4I3H8vo+DP408lBQ25fYfKdz+7kjb8uzdXiSGZXori65utlnwSOY5Zq7qRUs4z2eId+RzGSGSm2X5D/x8BZZseLqhRPPtnMBb3HrUjiGvVEJdctOOt1pR5BTYtE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710165475; c=relaxed/simple; bh=PnsyeRRFvDbok9D2S0+fAq2mkLT0LCY/VjhGwmCyYf8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=DtNylyH5D4hge2/ALsMEHMVaXXq3Do7gVuvOI8oAP0Oz+Alk8oaV3f8vp0vCf+LgjfmP8oz/k/YOFQO0b2D2U1b2nevM3RNxMG0W7Ge+PXw3wO9UdY3TFEqNZUmgnRU7rD3wEEUl2SCXABNxYHP5rTRd9t5qtnP19p8W4M1N0Wc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=lechnology.com; spf=pass smtp.mailfrom=lechnology.com; dkim=pass (2048-bit key) header.d=lechnology.com header.i=@lechnology.com header.b=fDIQDqKc; arc=none smtp.client-ip=98.142.107.122 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=lechnology.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lechnology.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lechnology.com; s=default; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=LMXq/m0hqKjZszVjyjD0++MBWTgCPJKu1ehEfBrjypQ=; b=fDIQDqKce5Yo2yAZIQyTDgLHyq 5nJJHkqm8nMmblDztveq7svAQvHTaCvSXWHda7ryRj0/sDQ5urQt+L+d76mhAK/MWNY7Qet/HEl68 ekSwcdVNMUSY/yBi7ZAf8Hsldi42jCyb84sN9tawRkmk/HuQBT1KFl225RQRDP5yY3as2+L+806SN vPvg8/xbGG2oOIi5IK0GfsemL+Kg7kTT8y/CSx21Myl0p28n67v5RnUrz1K30N6ZwjiLrmljjAC6B Vd5rTTDJhG6cQtDUnXzxJaqpf05OULuk95jn8kya/wHeUB0IqCOcNNu1vFAGukSB3eQR+Wh7czSYe LUgdd/hQ==; Received: from ip98-183-112-25.ok.ok.cox.net ([98.183.112.25]:54976 helo=[192.168.0.142]) by vern.gendns.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96.2) (envelope-from ) id 1rjgAl-0008GO-2l; Mon, 11 Mar 2024 09:57:44 -0400 Message-ID: <9b61b7cd-38c6-456b-aef1-be96c6bff978@lechnology.com> Date: Mon, 11 Mar 2024 08:57:42 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] counter: ti-eqep: Convert to platform remove callback returning void Content-Language: en-US To: =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig?= , William Breathitt Gray Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de References: From: David Lechner Autocrypt: addr=david@lechnology.com; keydata= xsFNBFFxkZ8BEADXzbnj9t8XSZYxKJGHdHqYgEBVzRElb3+f11qhDZKzVCMsn1+AN+PlHqC7 VrCWLsWTSY7WsHB2fW3aXaoidtac5FYoX2IXAun1Sbv15NcBdapImkMv6zxhAyWz6LqPfdCp QV+3x6qwUPFeLHdmew8mkSq56qTFgDQr9oQhsrXKHkXFD7aIAf5bM6janQCHgGTVDraRDfEO rV9rj7Wu/SfjUCVSCvW/SuWBa3IXTLNgbrNwBfo7Pl/tHuto0jxkVCIJ6J3xa85BKMw1WjA+ jKzh12S6KWrLUfhEUt64G9WJHiZOnVAjxgCR7TUahVM2OQHcp49ouG/JZsGNniulXH4ErA2O Wt6seUEx8XQIm48H96RWgKrwKJ+1WoLEmUcYOJDZUcguMZVc3Astx8aSaRjf6IRBO8XlJSJV OorkguvrTQBZJfjoicuFx7VlpdMggMZayv0cqEvzZMSHUt8DCUG74rLhtab9LCg/9wdCwqyE JEi/8jaV7JWxwiCmzVpw0mHn1DiUlp5kapZT+Hart0Gc1WW915psA4G6KneisFM5DJe+S5mn dUJb5IttTOx37jQQi2igwlSBdSC/M+Zy3sb+DXYJUVjVxK56RGAnlSvjHUx/TkID6Vb6HXvm Fgm9vQamTEf+C3XzlY2v1YaMMX8yQjfrzQSoGfB0+9zaD9J/cwARAQABzSREYXZpZCBMZWNo bmVyIDxkYXZpZEBsZWNobm9sb2d5LmNvbT7CwXgEEwECACIFAlFxkZ8CGwMGCwkIBwMCBhUI AgkKCwQWAgMBAh4BAheAAAoJEB+K+IyC93wDdcMQALkIsjA/nWJZY+Z6AkpL9HfeyYA6D2LK LFwWQ5fPok9G5wArvf+yHnbnVvtlZKPEdUAzbBacaATeLGRC0Kzei1asDgb/IR5YXQRMdshj 5Bd+DutTbT270p6jrzI3p7r1K7AycFcpfgSpOUQY7Wde7AT7KHCHaDjsy/a4d8EVjEhKZBg1 wgBr8L+2lVgjQP4x/tuj4KrWKygcCNiombhKW4iz2uR7EspoS18D+9MD8vLVrOqDKBWGswes cDblcjMv8FXIc7JR8x6ZbubFODoRzAs4MAlOgGT8FBAK/DUD63gMHTtKJrVghjoDNe77pmW1 zQK0P0zu9zciPg4h3AE+ENsJxqHoOEwCvJMQbhliFVYL4O0tM648V6K0o1btt4Ps0FEFASfX ZDa7uO30YZG+uqevP4wp6bfPpiHEUku32tSKZstbxljprLe0wDwYFSgXvVYUDUD6G3N1e3p0 xDXo+Oj/8yoZaPrOzMbqL66uSVghVTya7FjgT2aG1HfzH19NfO7SN+BQ4ld94gnDL2wWjA6h pddm+me8Aqa/xp0Wfhzs77/tyYd2FhV8RRs/tt1RN/8COblLnFGpNjtHCtpUuPCMTPN04+hg fEQVsW03//yRgt4teDogaklG+mYSbpkANMjyMN1LKVWM3YJTQcKIgpT8HvZwdrYBjB8CMHLb K2zgzsFNBFFxkZ8BEADSVjyceG8Up24FFXwv5YmV7yX520kM97N11e1RJVMI1RSU+Na3Xo9J 1BW6EFMAdibD6hH8PiMmToKxBrfYSLStLh2MbHA2T/3zqicU1nuk376LMyrAuoV/fl8/7Jld wh1c9AADaYXNQfZ84R6nyaTRjy4fqcc/dG2kw5ZMln909SMKZc3HdVynmo9pLT2HBOnXu2d3 bIGmzuDnDXzh1X8+ods4gViuvB31xU1WiANr4TbhaNU+/LmEVfvhS+34Cmz3U5Xs5x7nWdpM 6fFfDOSz2sIYXOGAcaV3oJ121Uul2U2bMTsXxiwdbjmZP9jrzEfvhD5KIOutX+0OzdtM9QVB 70QQOEh3maW/FwGdL5stYcadsBiEEI6Y2ymVpBgzrPS6HzC+UZLUShOE+aLx+SYBYAuypikM PvG9W3MqWHCsXXEfyp2mCeorKb7PafyaBO/E5REjPmYUpkGMNZH1lGV3jegE9WdOBfXW9xvC wf0UefoFaVhjsjtzvl8lMQndrDBdKPpJ7zIIG6FGSsUYmCtvE+JAk83tfpUpSZKDSzsqtLTI 8GE2fQzEuZcBqm6Yk2V1+u6rjUjmqEBIzunyeUupaUc+p00JiwNE8v/wcx7UbD5m+PGOkNoL MLe0ti0O7nFlY8avZzy3eLBQenu4WsJjPVYeQGeGB3oLvCGIhT9/WwARAQABwsFfBBgBAgAJ BQJRcZGfAhsMAAoJEB+K+IyC93wDC44P/0bAjHgFUPHl7jG5CrWGwgdTNN8NrjpmIxSk37kI uKMzcwP9BWhFF0mx6mCUEaxvGdAQ9Va/uXB2TOyhLCGXhlf8uCwxcIyrOlhi2bK6ZIwwovyj jh7GCRnm8cP8ohDCJlDUpHkOpmU4tcapbZiBrFaFAahxPMjwK9GJ3JY0lx63McgCEIwm6txN cMnVX5Y3HeW5Wo8DtmeM3XajJLFaBXIhEfoNHMfDON6UGiXFeR8S9W8dpaX8XEwzPUjZyOG2 LvOMAEPXx+kB9mZPTogong8LekL1HZHSY4OYffzQy5fVE+woHAMADkrmuosGkTRCP4IQHXOa goax/Dox01lKTLnlUL1iWWQjfRaFXVKxEc2PF1RZUpoO/IQYFB1twcaF2ibT3TlGolbmb3qU YBo/Apl5GJUj/xOWwrbikD+Ci+vx8yuFUlulbS9Ht+3z1dFjBUDbtZ4Bdy/1heNpA9xORiRs +M4GyTil33pnBXEZp29nh7ev4VJ96sVvnQFzls3motvG+pq/c37Ms1gYayeCzA2iCDuKx6Zk ybHg7IzNEduqZQ4bkaBpnEt+vwE3Gg5l4dAUFWAs9qY13nyBANQ282FNctziEHCUJZ/Map6T dzHWO6hU1HuvmlwcJSFCOey8yhkt386E6KfVYzrIhwTtabg+DLyMZK40Rop1VcU7Nx0M In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - vern.gendns.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - lechnology.com X-Get-Message-Sender-Via: vern.gendns.com: authenticated_id: davidmain+lechnology.com/only user confirmed/virtual account not confirmed X-Authenticated-Sender: vern.gendns.com: davidmain@lechnology.com X-Source: X-Source-Args: X-Source-Dir: On 3/10/24 3:06 AM, Uwe Kleine-König wrote: > The .remove() callback for a platform driver returns an int which makes > many driver authors wrongly assume it's possible to do error handling by > returning an error code. However the value returned is ignored (apart > from emitting a warning) and this typically results in resource leaks. > > To improve here there is a quest to make the remove callback return > void. In the first step of this quest all drivers are converted to > .remove_new(), which already returns void. Eventually after all drivers > are converted, .remove_new() will be renamed to .remove(). > > Trivially convert this driver from always returning zero in the remove > callback to the void returning variant. > > Signed-off-by: Uwe Kleine-König > --- Acked-by: David Lechner