Received-SPF: pass (google.com: domain of linux-kernel+bounces-98928-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <9e1dbcbc-f00e-417c-995e-d9c539292e03@amd.com>
Date: Mon, 11 Mar 2024 14:59:27 +0100
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] drm/amdgpu: add ring buffer information in devcoredump
Content-Language: en-US
To: Sunil Khatri <sunil.khatri@amd.com>,
 Alex Deucher <alexander.deucher@amd.com>,
 Shashank Sharma <shashank.sharma@amd.com>
Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
 linux-kernel@vger.kernel.org
References: <20240311122212.13713-1-sunil.khatri@amd.com>
From: =?UTF-8?Q?Christian_K=C3=B6nig?= <christian.koenig@amd.com>
In-Reply-To: <20240311122212.13713-1-sunil.khatri@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?Q2lTZlgwWmpMdHhqeTV6bW1PYWJrUitmZmhKUDFmcjh2NHF1THBvR0M2K3dS?=
 =?utf-8?B?d3NCdUFnSzZRbU5lVk5qa3dSUHJyL0VEWFFpQmtYMWdnMzNhZnN5WncrOHVN?=
 =?utf-8?B?b1dIamp6ZVhybHE1NFdudTBCKzRyZXhZRlR5SUFCOVVhSmMrdEtWN1c0MGlG?=
 =?utf-8?B?RVE4TUJJLy9sYm44SUE5VkNRa2FxS1R1NmhGT3FBWUxJVUF4MWprRkcvNTht?=
 =?utf-8?B?cmN6d1pTL1NnV29VSDUxa25jdXc3VjZyNGR3QmIxa2tyd2dmMkkyUXF1VVhu?=
 =?utf-8?B?aC9DS0trTUhycGpsQWxLL2RyM1JpdnlNMjEvekU1YXpsQUtlRjd3Vnl2MXh2?=
 =?utf-8?B?U0Q4RWJjSE1SOWp0RkRDQWMrWDBiNzJSNUwwYzRKSnNDc1dUbXJXSlFVU3Zj?=
 =?utf-8?B?Zk8wdWR3WU1YNFFQa3FObG5wSG5nTHNqck5LZXVSRCswckN5NG96amFaS01S?=
 =?utf-8?B?NTZwaGpJam1WRDd1L0E3UVgxSEtsOHY2ZkxnMnBlN2dCK1VjYW5tSk9VS3VX?=
 =?utf-8?B?YTZkT3lienFRNEFXOVVQbmUzQjd5TGsxL3M5Mk5PRkVBcjBxMW9QOEpOQjFi?=
 =?utf-8?B?Ylk0R2xNZmxOK0kwZVg4QzhFVkpKZ0w0ckEyaE1mQ3VZdGVGQSt1aEhVVnBa?=
 =?utf-8?B?cVpCS241R3NBYlBmUXh6U2RwQnlYdE43Y3VoWlFHMTBlM3IxUXU0bGpPK1Za?=
 =?utf-8?B?TG8ycTB4dDRkOTI1ZTlPazlIMEhpeEc3MGRQdGtUcXBQbkVQMmQydGN2T0E3?=
 =?utf-8?B?NXJmYjd1MklkcmRVVjUzVXFYMklSeXRQcENpMGplTDBCbWpWckNJUmdQNXIx?=
 =?utf-8?B?bHpZa1BtNjRtVk92cVRudjhmRitZK2pZMW5ZeThxMkRudzdsVmh0RlRicXRL?=
 =?utf-8?B?Rmw5R25XQUhXL0w0Qlc3NnFTZFg4dHU5ZDEvemJjYXZSVlBDdy9yUVJZMzQw?=
 =?utf-8?B?dFI4c2FRcXkxL2RDaW1IVGNKUnQyZzYvNEhNK2JJU2U2T0JDVzdjQ2lWbGVk?=
 =?utf-8?B?RDhmZkZJSDlWU0podFRHQldpenJLaDRJbVFlVlliMkVjcnZnSUdwRTN4SEdx?=
 =?utf-8?B?dUNTK3lTVUYrN0hLbW1jNzZ6ZXBHRmROTEZ5cUlTWC85WE54TXEyOUk0ZHkr?=
 =?utf-8?B?UmQ0MHgyNGQ5OGY4ajVHRDJWTDF1N0VVMXZkT3UyZmtVL0VvYWhySXcwMHIx?=
 =?utf-8?B?OEQzOW1PRXVKVTZwMmlnS0tnS3NyRzBHaUEyZCtZS3o1YzdtSVdwL21OYUxB?=
 =?utf-8?B?NmNKamgzZ3phU1l3ZHBTT3VtV1pWRWJFTXRtQ1YrOEJpdDBtaFdoWU5zWVo4?=
 =?utf-8?B?UW9GSmJnS3B4c0huMFUxOWdsKzMrQWdIUWRHRVQ4TU5SQy9XRy9TWDBUMWpJ?=
 =?utf-8?B?SHdRRTBjUGlzbVh1OTZGcllKNk10bkRyWEJHQ21XRmRjc052bXRJaElCZFJz?=
 =?utf-8?B?akRBc0h4VmFMN3NERVJYR0cxandPQjBDR3NZT1NFZ1g5ZVNOeXZrWTV2a2dY?=
 =?utf-8?B?VEVJWjd6Y0xCU1BhQ25zVFh0aytSWUh5VytHQXZmd0J4WmN2TGJGSkxMM29X?=
 =?utf-8?B?N29aVlc0cnJlUmdvREhnRlhPcmxnSDVLekNvcDA1NjAzNG8rb21DOWdDS3RK?=
 =?utf-8?B?emp2RFRTUTlHQXhlYnB1UmxMYjYwNExycW1aVUlqQ0oyL3NOM056NDhZSWdY?=
 =?utf-8?B?L3pUd2dCNWFPT2RQWjF3UTk4MVRhNS92RkdsYTBpKzlDWTNYTmlBMTR4UkJC?=
 =?utf-8?B?eTZFcERzbEQrajBreTk4UkhLUUNSUDErU0RwT1NGUGpkT240WG9IN01nUWl4?=
 =?utf-8?B?cTlIdDFrT3NjeDIwT3oyMzV6aHhMSHRCaDF0bFZmOTR5MlRQRDJKYmdoT1BS?=
 =?utf-8?B?Z1dQaGQzTXRKNE8xQS9LcS9tcUd0MXhETDdyNEVLK0pQRXRtdXI2b2c2RWZp?=
 =?utf-8?B?anNPL0FBQkZ1bGNGRmFYYjJyL1dySE9JeFZZakJTT0FwOE1JWjBFOE9SdGFp?=
 =?utf-8?B?Q0dMeXBoZjE2NFhULzBTdUFqRXlGaGhETFhiSGJxWXNyQjZ0R1J4cGQzejdD?=
 =?utf-8?B?VHdSdmxxNWduY2pGNDEzSDQ5OHEwb0tidTN5M1J6dERjODJxa1pHRTltYk5C?=
 =?utf-8?Q?Rvlez9JwMhOKjKygZRJ9d2cA+?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1536601b-3968-42a2-f81a-08dc41d37a53
X-MS-Exchange-CrossTenant-AuthSource: PH7PR12MB5685.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Mar 2024 13:59:32.7210
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 8RtJ1/CHr/w6dmeOtaxDOGuQSh1ygj82x/Q0wS/8OClJfMfLr6/Z/nEmzAsmF55r
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB8525


Am 11.03.24 um 13:22 schrieb Sunil Khatri:
> Add relevant ringbuffer information such as
> rptr, wptr, ring name, ring size and also
> the ring contents for each ring on a gpu reset.
>
> Signed-off-by: Sunil Khatri <sunil.khatri@amd.com>
> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_reset.c | 21 +++++++++++++++++++++
>   1 file changed, 21 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_reset.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_reset.c
> index 6d059f853adc..1992760039da 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_reset.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_reset.c
> @@ -215,6 +215,27 @@ amdgpu_devcoredump_read(char *buffer, loff_t offset, size_t count,
>   			   fault_info->status);
>   	}
>   
> +	drm_printf(&p, "Ring buffer information\n");
> +	for (int i = 0; i < coredump->adev->num_rings; i++) {
> +		int j = 0;
> +		struct amdgpu_ring *ring = coredump->adev->rings[i];
> +
> +		drm_printf(&p, "ring name: %s\n", ring->name);
> +		drm_printf(&p, "Rptr: 0x%llx Wptr: 0x%llx\n",
> +			   amdgpu_ring_get_rptr(ring) & ring->buf_mask,
> +			   amdgpu_ring_get_wptr(ring) & ring->buf_mask);

Don't apply the mask here. We do have some use cases where the rptr and 
wptr are outside the ring buffer.

> +		drm_printf(&p, "Ring size in dwords: %d\n",
> +			   ring->ring_size / 4);

Rather print the mask as additional value here.

> +		drm_printf(&p, "Ring contents\n");
> +		drm_printf(&p, "Offset \t Value\n");
> +
> +		while (j < ring->ring_size) {
> +			drm_printf(&p, "0x%x \t 0x%x\n", j, ring->ring[j/4]);
> +			j += 4;
> +		}

> +		drm_printf(&p, "Ring dumped\n");

That seems superfluous.

Regards,
Christian.

> +	}
> +
>   	if (coredump->reset_vram_lost)
>   		drm_printf(&p, "VRAM is lost due to GPU reset!\n");
>   	if (coredump->adev->reset_info.num_regs) {