Received-SPF: pass (google.com: domain of linux-kernel+bounces-98798-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Mon, 11 Mar 2024 14:05:39 +0200
From: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
To: 
	Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
Cc: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, 
	dave.hansen@intel.com, hpa@zytor.com, seanjc@google.com, ele.reshetova@intel.com, 
	rick.p.edgecombe@intel.com, x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] x86/tdx: Enable ENUM_TOPOLOGY
Message-ID: <fivnqmu4rfm22ps4mevrmeq2oncjwxe6i2t5foptxxhdb6dzgp@dur4zezgxd23>
References: <20240309210230.239045-1-kirill.shutemov@linux.intel.com>
 <20240309210230.239045-5-kirill.shutemov@linux.intel.com>
 <95ba9bb3-7c48-4d99-b05e-5a45a796af3c@linux.intel.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <95ba9bb3-7c48-4d99-b05e-5a45a796af3c@linux.intel.com>

On Sat, Mar 09, 2024 at 07:56:11PM -0800, Kuppuswamy Sathyanarayanan wrote:
> 
> On 3/9/24 1:02 PM, Kirill A. Shutemov wrote:
> > TDX 1.0 generates a #VE when accessing topology-related CPUID leafs
> > (0xB and 0x1F) and the X2APIC_APICID MSR. The kernel returns all
> > zeros on CPUID #VEs. In practice, this means that the kernel can only
> > boot with a plain topology. Any complications will cause problems.
> 
> Is this issue only for TDX 1.0? What about TDX > 1.0?

TDX 1.0 defines the baseline for TDX. Any change in behaviour will be
gated by explicit opt-in. In this case, it is ENUM_TOPOLOGY.

> > The ENUM_TOPOLOGY feature allows the VMM to provide topology
> > information to the guest in a safe manner. Enabling the feature
> > eliminates topology-related #VEs: the TDX module virtualizes
> > accesses to the CPUID leafs and the MSR.
> >
> > Enable ENUM_TOPOLOGY if it is available.
> 
> I cant find the ENUM_TOPOLOGY in ABI spec (https://cdrdv2.intel.com/v1/dl/getContent/795381).
> 
> Can you point me to the correct document?

I guess JSON dump is out of sync with the PDF doc. See this:

https://cdrdv2.intel.com/v1/dl/getContent/733579

-- 
  Kiryl Shutsemau / Kirill A. Shutemov