Received-SPF: pass (google.com: domain of linux-kernel+bounces-98937-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Precedence: bulk
MIME-Version: 1.0
References: <f713d82fe6526288f51fc138cd16681cec6b43a6.1710164592.git.geert@linux-m68k.org>
 <8f27c774-7197-48da-a6f2-6d375bd848f0@app.fastmail.com>
In-Reply-To: <8f27c774-7197-48da-a6f2-6d375bd848f0@app.fastmail.com>
From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: Mon, 11 Mar 2024 15:04:09 +0100
Message-ID: <CAMuHMdWJJuEHo08gJwrxiLv2P-US6sfEz83PZHnAcB4es68BjQ@mail.gmail.com>
Subject: Re: [PATCH] fork: Use THREAD_SIZE_ORDER
To: Arnd Bergmann <arnd@arndb.de>
Cc: Andrew Morton <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Arnd,

On Mon, Mar 11, 2024 at 2:48=E2=80=AFPM Arnd Bergmann <arnd@arndb.de> wrote=
:
> On Mon, Mar 11, 2024, at 14:44, Geert Uytterhoeven wrote:
> > Use the existing THREAD_SIZE_ORDER definition instead of calculating it
> > from THREAD_SIZE and PAGE_SIZE.
> >
> > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> > ---
> >  kernel/fork.c | 8 ++++----
> >  1 file changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/kernel/fork.c b/kernel/fork.c
> > index 0d944e92a43ffa13..e79fdfe1f0bf4953 100644
> > --- a/kernel/fork.c
> > +++ b/kernel/fork.c
> > @@ -252,9 +252,9 @@ static int memcg_charge_kernel_stack(struct vm_stru=
ct *vm)
> >       int ret;
> >       int nr_charged =3D 0;
> >
> > -     BUG_ON(vm->nr_pages !=3D THREAD_SIZE / PAGE_SIZE);
> > +     BUG_ON(vm->nr_pages !=3D THREAD_SIZE_ORDER);
> >
>
> That doesn't look right, THREAD_SIZE_ORDER not the number of
> pages but the the log2 of it, right?
>
> I think you want '(1 << THREAD_SIZE_ORDER)', but at that point
> it doesn't actually look simpler than the existing code.

Thank you for pointing out my silly mistake.

/me hides in a brown paper bag, with a coffee machine.

Gr{oetje,eeting}s,

                        Geert

--=20
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k=
org

In personal conversations with technical people, I call myself a hacker. Bu=
t
when I'm talking to journalists I just say "programmer" or something like t=
hat.
                                -- Linus Torvalds