Received-SPF: pass (google.com: domain of linux-kernel+bounces-98947-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
From: Bernard Metzler <BMT@zurich.ibm.com>
To: linke li <lilinke99@qq.com>
CC: Jason Gunthorpe <jgg@ziepe.ca>, Leon Romanovsky <leon@kernel.org>,
        "linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Thread-Topic: [EXTERNAL] [PATCH] RDMA/siw: Reuse value read using READ_ONCE
 instead of re-reading it
Thread-Index: AQHach13aXbUy+IdAE6aHBqKSSZ2zrEyeAoA
Date: Mon, 11 Mar 2024 14:14:09 +0000
Message-ID: 
 <BYAPR15MB32080B7AA8255352C1F691A199242@BYAPR15MB3208.namprd15.prod.outlook.com>
References: <tencent_32C3AEB0599DF0A0010A862439636CDA2707@qq.com>
In-Reply-To: <tencent_32C3AEB0599DF0A0010A862439636CDA2707@qq.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?utf-8?B?UGIvcjVWOFNpQVR4NVZaQ0NRNllyNlk1RWk1VW83MWF3aDVyaUMxeThvQ0FL?=
 =?utf-8?B?REJWSnJxUG00Wk9kNVJYNmVxYlphRkd6SFR1dEdmUTI3TmJuOEpLU2dnTzdv?=
 =?utf-8?B?YlFPekszU0JEeXpCTVVuNk1tck9jTXlJSVJ1VUoxTUdRdHB0NHhCNE5CVEMy?=
 =?utf-8?B?TGZOYVp0VnBtUHRPL2gxa2JIZjJpbEd3NjVpdnBMYzVzL1NvMFdHMmdmVmE0?=
 =?utf-8?B?V0ZGSTVKVm9yYjgveGN0YUs2Tml1Z05KYzhQRW1mcnFBMVVNQ2FZNEhhdW9L?=
 =?utf-8?B?cmR1dHdXdkRPenRUamJSb3N3KzJvWWN1M3FpNE9YeHJlNGhCaG04ZUlWYjFH?=
 =?utf-8?B?Q0hOVlFBWDVEcFE1RWtZQUl3bDBwK2k2eUFHNkV3RUI4S3Jnb3dMZE51MnI1?=
 =?utf-8?B?M3dSYlh0Z1RMT2VNNFhlR0dyRGFocUNuZ2Y1NnAwM05HSUlIak9GUWF1YVVF?=
 =?utf-8?B?QUVTUi9ZYVFxZ2Q0UzNubTJSN0pUb0dZVi95K29pS09sS0dhQ2d1SG4raWFT?=
 =?utf-8?B?ZGNJZlM1VE9JcDU0Umg5Uks1bnRLUmlhU2E1UXdJWndoeXZOTFpacTUreTZC?=
 =?utf-8?B?eXpUUzBwdlhmVWhjeGNJN09Yb2xncWdXd2NjS3FUWE0yM0tUNXNKQlRnTDNO?=
 =?utf-8?B?MTdPSjZ6RTZVMDZyalBxQmlFNm90MHVGcUFUVDltR1lZc2xKTlhSNW45S1Y5?=
 =?utf-8?B?ZFAxajhob0ppT1hIeVE4VjhLK2VsSzAxZjFZVjdXSTAyM2tuM09ncTRqQ1o2?=
 =?utf-8?B?NjZRLy8wTmVLc3IwT3ZhcUpFU21xUkVEVVdMVTBoTnhhc3lsT2NQZ3BzbVl1?=
 =?utf-8?B?K1NOY3lYVlZmNnBIU3YzU0JETDRBSVFZTVp1Vm5mWjFFU1kxeXpFSFFQbUIx?=
 =?utf-8?B?bkp1a0RYMXRDNkhoODBQZ2hHK1FLQlA4UU5hbjllRVl5cHdZdGZSbGtneXQ0?=
 =?utf-8?B?RHAxcG56aTA0MUtzdnBlanFieEgwMGRtT2NpM3I2UXRicEdweU16dy81R2dP?=
 =?utf-8?B?YS9ReW50WjFFTFlBV1VXK3hUK1lUaU5UV2VTYlRPcnpPRUcxT2Z3NWZxTmls?=
 =?utf-8?B?ZUdQOFpvbE11b3BINWR3NUg4YmxlMGVKSHpnT3BoY1c0ai9mb1FjdGZlZklQ?=
 =?utf-8?B?OW4rRnVTOGNaSE0yNUFybjJqeW9yYUpFWEs3SjUrZmJmblAveG9HNG9PSE9I?=
 =?utf-8?B?c0R3MjZQdFdkMGhMNXNuNGZscGFWVkpkVEhBVy9aUTVJYTV3dXc1dU4xQUpP?=
 =?utf-8?B?WHNub1RmcUNwZmRuQlByampBTjRtaXBQdWdYNWRkWDJiMS81N1RWQUFKU3RW?=
 =?utf-8?B?RUIzdUViNytIRHduWVU2TW1vU0pmU1hQQmNQaGZOM2tMWklZVEdxWTFjUnM3?=
 =?utf-8?B?STN5VHdLendDZE9Oa21mdU94VG91Myt5U0daMGpIK01BVU5hczhiaW0zUUtz?=
 =?utf-8?B?aVVqYjVvQ2xnQ1RhMml3ek9NN3pVNm1DWVBhQjdQSFlscW12elZnVzA1LzFP?=
 =?utf-8?B?Umg4T1ZSdjZkd2ZPMGVmN2xDVUw0Y1dSV2lKT0JWR0dncmMrM1F1S240VEg0?=
 =?utf-8?B?QTRHVlpPWXRpd2hhWXhDTUFvRHNjdDNOSlJHa1hmQ0g5Unc2N0s5WDdkN1Q4?=
 =?utf-8?B?bk1wNUdCNm1lSGp2THhFNkpXcDlBZURUcU1SVjlWM1hNMTc4MllGUlo5Kzgz?=
 =?utf-8?B?VXhhWlUxdld0TjVOZG5OV3lQVjUvS0FIbjRhR3V1SGNYLzVod29wMUl0OXlB?=
 =?utf-8?B?dWlzYTFaUXNHTC90L09JNXBCRnJoMVFHRHBvdWJEcFFUbUJpNVhYaDAxZ3pV?=
 =?utf-8?B?dkxUNWQ3c2FpbTZ3ZDlmR2VmYnN4LzYwSGErN0g2TTlmYjFvVjdVRjV2eHNV?=
 =?utf-8?B?VlRoc2dMTmtuMU8rNjZTb3NUKzE2TnZvRlRLeUNZZCtnZFpXb24wUzVsZUtQ?=
 =?utf-8?B?VFdWUEJmblZhTW1BM2xKU3hCTTFiVy9ZY082T0ZmWDNzVi84aGZmOTlUVzFI?=
 =?utf-8?B?TkJOSnplbS9IU2c5d2NoM29QVHAvWG10a0FsODMzQ0t3R1lOOHdrZG5KdUF1?=
 =?utf-8?B?WlhCZzBDMlluRlRwYUxzdm5LVXZMdWxPYnZ0dDRuV3lhczN0bkRGb1pXV0t0?=
 =?utf-8?B?emtQNFRlR2N4anV6eFJMbFM4MU9qbDAycmZyNjU3aUNoS1pPNzlteXhwckNl?=
 =?utf-8?Q?4XcYfkES4jbS6WjGxBRsHSQ=3D?=
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: Zurich.ibm.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR15MB3208.namprd15.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3fdbcde5-defe-48f7-38b4-08dc41d5853b
X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Mar 2024 14:14:09.8805
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: fcf67057-50c9-4ad4-98f3-ffca64add9e9
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 3+YSbXuEwNtqw6xlOSz86BL7yaX2JAEpbgAV1/0sQZiQCEGAPJvkcfe/LS6deNzGr2tGu4iEju0FKPezzVt8RA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR15MB5047
X-Proofpoint-GUID: 6e9XQ6jkVLRQRsNM2wreh-1Qm_hbP5A4
X-Proofpoint-ORIG-GUID: Nppm9ukXdl5KOBRNyJUD2kUThRx1PmcO
Subject: RE:  [PATCH] RDMA/siw: Reuse value read using READ_ONCE instead of
 re-reading it
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-03-11_08,2024-03-06_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 mlxscore=0
 bulkscore=0 clxscore=1011 mlxlogscore=999 phishscore=0 suspectscore=0
 spamscore=0 malwarescore=0 impostorscore=0 adultscore=0 lowpriorityscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000
 definitions=main-2403110107

DQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogbGlua2UgbGkgPGxpbGlu
a2U5OUBxcS5jb20+DQo+IFNlbnQ6IFNhdHVyZGF5LCBNYXJjaCA5LCAyMDI0IDE6MjcgUE0NCj4g
Q2M6IGxpbGlua2U5OUBxcS5jb207IEJlcm5hcmQgTWV0emxlciA8Qk1UQHp1cmljaC5pYm0uY29t
PjsgSmFzb24gR3VudGhvcnBlDQo+IDxqZ2dAemllcGUuY2E+OyBMZW9uIFJvbWFub3Zza3kgPGxl
b25Aa2VybmVsLm9yZz47IGxpbnV4LQ0KPiByZG1hQHZnZXIua2VybmVsLm9yZzsgbGludXgta2Vy
bmVsQHZnZXIua2VybmVsLm9yZw0KPiBTdWJqZWN0OiBbRVhURVJOQUxdIFtQQVRDSF0gUkRNQS9z
aXc6IFJldXNlIHZhbHVlIHJlYWQgdXNpbmcgUkVBRF9PTkNFDQo+IGluc3RlYWQgb2YgcmUtcmVh
ZGluZyBpdA0KPiANCj4gSW4gc2l3X29ycWVfc3RhcnRfcngsIHRoZSBvcnFlJ3MgZmxhZyBpbiB0
aGUgaWYgY29uZGl0aW9uIGlzIHJlYWQgdXNpbmcNCj4gUkVBRF9PTkNFLCBjaGVja2VkLCBhbmQg
dGhlbiByZS1yZWFkLCB2b2lkaW5nIGFsbCBndWFyYW50ZWVzIG9mIHRoZQ0KPiBjaGVja3MuIFJl
dXNlIHRoZSB2YWx1ZSB0aGF0IHdhcyByZWFkIGJ5IFJFQURfT05DRSB0byBlbnN1cmUgdGhlDQo+
IGNvbnNpc3RlbmN5IG9mIHRoZSBmbGFncyB0aHJvdWdob3V0IHRoZSBmdW5jdGlvbi4NCj4gDQo+
IFNpZ25lZC1vZmYtYnk6IGxpbmtlIGxpIDxsaWxpbmtlOTlAcXEuY29tPg0KPiAtLS0NCj4gIGRy
aXZlcnMvaW5maW5pYmFuZC9zdy9zaXcvc2l3X3FwX3J4LmMgfCA2ICsrKystLQ0KPiAgMSBmaWxl
IGNoYW5nZWQsIDQgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkNCj4gDQo+IGRpZmYgLS1n
aXQgYS9kcml2ZXJzL2luZmluaWJhbmQvc3cvc2l3L3Npd19xcF9yeC5jDQo+IGIvZHJpdmVycy9p
bmZpbmliYW5kL3N3L3Npdy9zaXdfcXBfcnguYw0KPiBpbmRleCBlZDRmYzM5NzE4YjQuLmY1ZjY5
ZGU1Njg4MiAxMDA2NDQNCj4gLS0tIGEvZHJpdmVycy9pbmZpbmliYW5kL3N3L3Npdy9zaXdfcXBf
cnguYw0KPiArKysgYi9kcml2ZXJzL2luZmluaWJhbmQvc3cvc2l3L3Npd19xcF9yeC5jDQo+IEBA
IC03NDAsNiArNzQwLDcgQEAgc3RhdGljIGludCBzaXdfb3JxZV9zdGFydF9yeChzdHJ1Y3Qgc2l3
X3FwICpxcCkNCj4gIHsNCj4gIAlzdHJ1Y3Qgc2l3X3NxZSAqb3JxZTsNCj4gIAlzdHJ1Y3Qgc2l3
X3dxZSAqd3FlID0gTlVMTDsNCj4gKwl1MTYgb3JxZV9mbGFnczsNCj4gDQo+ICAJaWYgKHVubGlr
ZWx5KCFxcC0+YXR0cnMub3JxX3NpemUpKQ0KPiAgCQlyZXR1cm4gLUVQUk9UTzsNCj4gQEAgLTc0
OCw3ICs3NDksOCBAQCBzdGF0aWMgaW50IHNpd19vcnFlX3N0YXJ0X3J4KHN0cnVjdCBzaXdfcXAg
KnFwKQ0KPiAgCXNtcF9tYigpOw0KPiANCj4gIAlvcnFlID0gb3JxX2dldF9jdXJyZW50KHFwKTsN
Cj4gLQlpZiAoUkVBRF9PTkNFKG9ycWUtPmZsYWdzKSAmIFNJV19XUUVfVkFMSUQpIHsNCj4gKwlv
cnFlX2ZsYWdzID0gUkVBRF9PTkNFKG9ycWUtPmZsYWdzKTsNCj4gKwlpZiAob3JxZV9mbGFncyAm
IFNJV19XUUVfVkFMSUQpIHsNCj4gIAkJLyogUlJFU1AgaXMgYSBUQUdHRUQgUkRNQVAgb3BlcmF0
aW9uICovDQo+ICAJCXdxZSA9IHJ4X3dxZSgmcXAtPnJ4X3RhZ2dlZCk7DQo+ICAJCXdxZS0+c3Fl
LmlkID0gb3JxZS0+aWQ7DQo+IEBAIC03NTYsNyArNzU4LDcgQEAgc3RhdGljIGludCBzaXdfb3Jx
ZV9zdGFydF9yeChzdHJ1Y3Qgc2l3X3FwICpxcCkNCj4gIAkJd3FlLT5zcWUuc2dlWzBdLmxhZGRy
ID0gb3JxZS0+c2dlWzBdLmxhZGRyOw0KPiAgCQl3cWUtPnNxZS5zZ2VbMF0ubGtleSA9IG9ycWUt
PnNnZVswXS5sa2V5Ow0KPiAgCQl3cWUtPnNxZS5zZ2VbMF0ubGVuZ3RoID0gb3JxZS0+c2dlWzBd
Lmxlbmd0aDsNCj4gLQkJd3FlLT5zcWUuZmxhZ3MgPSBvcnFlLT5mbGFnczsNCj4gKwkJd3FlLT5z
cWUuZmxhZ3MgPSBvcnFlX2ZsYWdzOw0KPiAgCQl3cWUtPnNxZS5udW1fc2dlID0gMTsNCj4gIAkJ
d3FlLT5ieXRlcyA9IG9ycWUtPnNnZVswXS5sZW5ndGg7DQo+ICAJCXdxZS0+cHJvY2Vzc2VkID0g
MDsNCj4gLS0NCj4gMi4zOS4zIChBcHBsZSBHaXQtMTQ2KQ0KPiANCj4gDQoNClRoZSBvdXRib3Vu
ZCByZWFkIHF1ZXVlIChvcnEpIGlzIGEgcmluZyBidWZmZXIgd2l0aCBvbmx5IG9uZQ0KY29uc3Vt
ZXIgKHRoaXMgY29kZSkgYW5kIG9uZSBwcm9kdWNlciAoUkVBRC5yZXF1ZXN0IHNlbmRpbmcNCmNv
ZGUpLiBUaGVyZSBpcyBubyBwYXJhbGxlbCByZWFkZXIgYW5kIGEgc2luZ2xlIHdyaXRlci4NCg0K
VGhlIHByb2R1Y2VyIChzZW5kZXIgb2YgdGhlIFJFQUQucmVxdWVzdCkgc2V0cyB0aGUgb3JxIGVu
dHJ5DQp2YWxpZCBhbmQgZG9lcyB0aGlzIG9ubHkgb25jZSBhZnRlciBjb21wbGV0ZWx5IHdyaXRp
bmcNCnRoZSBlbnRyeS4gSXQgZG9lcyBpdCB1bmRlciBxcC0+b3JxX2xvY2suDQoNCk9ubHkgaWYg
d2UgZmluZCB0aGUgb3JxIGVudHJ5IHZhbGlkLCBpdHMgY29udGVudCBnZXRzIGNvcGllZA0KYXQg
dGhlIGJlZ2lubmluZyBvZiBhIG5ldyBSRUFELnJlc3BvbnNlICh0aGlzIGNvZGUpLg0KDQpUaGUg
b3JxIGVudHJ5IHJlbWFpbnMgdmFsaWQgdG8gc3RvcCB0aGUgcHJvZHVjZXIgZnJvbSByZS11c2lu
Zw0KaXQgdW50aWwgdGhlIGNvbXBsZXRlIFJFQUQucmVzcG9uc2UgaGFzIGJlZW4gcmVjZWl2ZWQg
KG1heSBiZQ0KbXVsdGlwbGUgZnJhZ21lbnRzKS4gVGhlIGZsYWcgZ2V0cyBjbGVhcmVkIHVuZGVy
IHFwLT5vcnFfbG9jaw0KYWZ0ZXIgdGhlIGNvbXBsZXRlIFJFQUQucmVzcG9uc2UgaGFzIGJlZW4g
cmVjZWl2ZWQsIG9yIHRoZQ0KcmVzcG9uc2Ugd2FzIGludmFsaWQuDQoNCg0KVGhlcmUgaXMgbm8g
cG9zc2liaWxpdHkgYSB2YWxpZCBvcnEgZW50cnkgZ2V0cyBpbnZhbGlkYXRlZA0KYWZ0ZXIgaXQg
aGFzIGJlZW4gZm91bmQgdmFsaWQsIHNvIGl0IGlzIHNhZmUgdG8gY29weSBhbGwgaXRzDQptZW1i
ZXJzLiANCg0KVGhhbmtzLA0KQmVybmFyZC4NCg==