Received-SPF: pass (google.com: domain of linux-kernel+bounces-98948-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <43b0b4ad-69ac-450f-8b39-ae264355622e@intel.com>
Date: Mon, 11 Mar 2024 15:17:15 +0100
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v3 net-next] ptp: Move from simple ida to xarray
Content-Language: en-US
To: Kory Maincent <kory.maincent@bootlin.com>, Jakub Kicinski
	<kuba@kernel.org>, Simon Horman <horms@kernel.org>, <netdev@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
CC: <thomas.petazzoni@bootlin.com>, Richard Cochran <richardcochran@gmail.com>
References: <20240311135949.1180157-1-kory.maincent@bootlin.com>
From: Przemek Kitszel <przemyslaw.kitszel@intel.com>
In-Reply-To: <20240311135949.1180157-1-kory.maincent@bootlin.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eDFNZkxTUkRkUFRwc0R1QXYzclRxdm1WSzdTcHFVTUtpTEFMME5zSEJLWGpw?=
 =?utf-8?B?S1dac3VXSGpNVGNESjZ1a1V5Z293NVVBdU42SldhNGw5NVFTYXhIb3UvQWg0?=
 =?utf-8?B?ankrQVZWdEdIQkl1V0RPcEhjTjVtclVEZUlqYmpKSnpVQzRQcXVQd2tmN0to?=
 =?utf-8?B?cUZUKzFBZVJjVldMZmlwMVlGT29EVmJTSTJQZytDTlNrL3VsbnBESUozQnRq?=
 =?utf-8?B?K2hibGVOUittUm03eXFjc0JKNlRRM0NaRmh5ZTF2bDlvMitNdE5Gc1o3Nm5E?=
 =?utf-8?B?N0QvQThGZTJzRlp4aXBXdTQyVVNhamRrVnJ5K3QzbDJ1V0ZpMG5EWE1GOFZ3?=
 =?utf-8?B?YXpISCt4Wmp6UUtjbkpsalVWVEdGUnIzcDE4UVgwOERFWTViREVxVVVadHlz?=
 =?utf-8?B?SEd5N1ltWVh5eGU1M0V0cERobTVPUDY5QitVNnBubTBPYThjZlUzSStHeHov?=
 =?utf-8?B?NEZ1N240QnBjSXBpTlhITE5Ka05oT3dhOEszc09RTlBubVdPOXRmUGl3bzRz?=
 =?utf-8?B?RXpVajFGbXV0WXpWaXFTczZxWWxCUkVkVFkxQlloN2R3Ni9HQkI1YW93SnNT?=
 =?utf-8?B?Nml1bWFTYzl2Mkx0aFIyb0psQVFiTERYb2dYWjdCanFLbDBCT25GcmgrVk13?=
 =?utf-8?B?a0NRcjkvNStUalIrTnE3eXM2dDQrSDk2T05pWGZMRjlTdE5XOVVFQWlkSnpl?=
 =?utf-8?B?UUNhRFJCL1duQkJ0MTJPUHE3VXBsSm1XbVB4T25oL2hHM0xkKzZQNGludkVY?=
 =?utf-8?B?RkNNdTdlQ1VYTGtiOXNCNGR4ZlZKK0pQcmZnODVMNDFoQXhiWVlESEZDTDhn?=
 =?utf-8?B?LzV3azNHUDZWTTNiL3RVaHFPbkl0TUdkNTVvWTJjdjI5Mnd5SGc1bW41aGdo?=
 =?utf-8?B?ZDNMMGVNOUJ6bEppZm1YaU43K0c5RXlhRTZRd09JaUZKL1h0a3dvblcrRmZm?=
 =?utf-8?B?UXB6VVB0Z3VYM09BZk1lbVB0dVZudnMxRHVQdGdOblh0WFpIM2pqMXp5bVdO?=
 =?utf-8?B?eE1FYjN2T05lVGtxcnhVTmlEN1Zzc0lDZ1ZaS2s2SVdnSEdVcVorMW50ZHFh?=
 =?utf-8?B?V3NWL1pSNVEvbHJCZlREME52djJrcnpKU2lMZVM4RDFydXBzWGVDWkVEUFlx?=
 =?utf-8?B?eFBrZFJhdUk0K0pFU2ZQNVRzVm44Zk5Na1dBck5ZR1hqQS9DYXZPdDRHb05B?=
 =?utf-8?B?d0hnUlFibXFkREtLUUc2aVE1bmRPS2ZSQnlLejc3UmtnZC9RdkpkUkpZazFK?=
 =?utf-8?B?ZFRuVUJLb3p1dTYvM0pVbTV3TzIzZytuNzZINlgyWVNUSnpzMnJHTkl0SDhu?=
 =?utf-8?B?RHJ6M0xoUllYQ3MvUVpZSGxyRTJIdVVkNjZrZUJhLzFWOXY1cHp4ODNkUTEr?=
 =?utf-8?B?cVBrbkRXS1VTZkFuL3JpVm5Galh3eEV2K1d4UnUwbnYxK3EvVWtldzZFVnhk?=
 =?utf-8?B?Wno2UndTNVB3bUR4Z0lXYzJWbHdWQWJHVzlXTlh3QlVlNG1WZDQ1b3VQMmIw?=
 =?utf-8?B?T0NXSUdvb0ttN0lUL1VEd1NJUzIrNWJ4cFQ5TE1SLzJuNFl3UUFUTW82WFVK?=
 =?utf-8?B?MVRGQmhDRTliWDhtMFN3OVNyeHdpanhyOWRVczg3a1l0S1RBSWpOSUdLQThk?=
 =?utf-8?B?WVd4ZXlzeXBFS2l4WVV2eUxzbXhyZThqQjB4dWNlS0E3cTkvcWU0QkI5N1ox?=
 =?utf-8?B?YjZRanFDN0Q0cm90bzA0a2M0d1BUZVVLb0dZWkhnQ2FwSmRXcXF1amFYMUJs?=
 =?utf-8?B?TlpuZXJjNUZFb2FWb0YxNHRyOXl0Q0lPNEEwNitRemhNYmJUbmtLMFR1Wi93?=
 =?utf-8?B?akxZWnlEeVhSbUtXUE9hZ291SUovb0tEbEhnN3lIRnF6dWd2dlVsMWFJa1ZK?=
 =?utf-8?B?QkpoNTRzcTZhQnJqTUJ5ZmVkRUgwNW1rU0hyRDhPeWJhOVpYL1kyUVFKUEpi?=
 =?utf-8?B?TUNkRXpUWDVqZ0kxZFE0THNDU1k5M09ZM05NMDNOVzRWMFJuZFNsUUdyNWJ5?=
 =?utf-8?B?bk9IM3J4RW5zaC8zWnFQRmd2VkljZ2dHZW82UHdibE5oWEcrQkJnbW5WZkVq?=
 =?utf-8?B?eXZncTFCTnJvZXdEUURZU0tCK2lwcmFzV0J5N1hGdnBTbnJUVVpDL2F0dWNw?=
 =?utf-8?B?dXBPUDc0QTVwbkhVR3JydGRxUWN1KzNCRFExZ1B2QU9WeHBYS003S0xIMmhO?=
 =?utf-8?Q?Cd2dRE/X5afFSPOAE/uD7KM=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: a85e017b-5e6f-477d-65d0-08dc41d5f7db
X-MS-Exchange-CrossTenant-AuthSource: MN6PR11MB8102.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Mar 2024 14:17:22.2663
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: uKxwzVJiz4VNx3Rxm2krhRM6eZZSr/jSZMuXvSlbGPsBZznYIlWcoCMMc6VtPeAI/YOtXrgx1JD16g2E/QlZeOTB/gmy1eS+W6D5NJEKfGo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR11MB6156
X-OriginatorOrg: intel.com

On 3/11/24 14:59, Kory Maincent wrote:
> Move from simple ida to xarray for storing and loading the ptp_clock
> pointer. This prepares support for future hardware timestamp selection by
> being able to link the ptp clock index to its pointer.
> 
> Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
> ---
> 
> Change in v2:
> - Update an err value missing.
> 
> Change in v3:
> - Refactor err management.
> ---
>   drivers/ptp/ptp_clock.c | 28 ++++++++++++++++------------
>   1 file changed, 16 insertions(+), 12 deletions(-)
> 

sorry for not commenting more on v2 :/

As you change (the intent of*) underlying data structure you should also 
change included header file.

*ida is an xarray wrapper by now so the change is on semantic level only

> diff --git a/drivers/ptp/ptp_clock.c b/drivers/ptp/ptp_clock.c
> index 3aaf1a3430c5..8eebf1373ca3 100644
> --- a/drivers/ptp/ptp_clock.c
> +++ b/drivers/ptp/ptp_clock.c
> @@ -31,7 +31,7 @@ struct class *ptp_class;
>   
>   static dev_t ptp_devt;
>   
> -static DEFINE_IDA(ptp_clocks_map);
> +static DEFINE_XARRAY_ALLOC(ptp_clocks_map);
>   
>   /* time stamp event queue operations */
>   
> @@ -201,7 +201,7 @@ static void ptp_clock_release(struct device *dev)
>   	bitmap_free(tsevq->mask);
>   	kfree(tsevq);
>   	debugfs_remove(ptp->debugfs_root);
> -	ida_free(&ptp_clocks_map, ptp->index);
> +	xa_erase(&ptp_clocks_map, ptp->index);
>   	kfree(ptp);
>   }
>   
> @@ -241,16 +241,16 @@ struct ptp_clock *ptp_clock_register(struct ptp_clock_info *info,
>   		return ERR_PTR(-EINVAL);
>   
>   	/* Initialize a clock structure. */
> -	err = -ENOMEM;

you could remove 0-init of err in this commit too

>   	ptp = kzalloc(sizeof(struct ptp_clock), GFP_KERNEL);
> -	if (ptp == NULL)
> +	if (!ptp) {
> +		err = -ENOMEM;
>   		goto no_memory;
> +	}
>   

[snip]

Thanks a lot!
Only nitpicks left, so:
Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>