Received-SPF: pass (google.com: domain of linux-kernel+bounces-98949-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <f27274a9-fc5d-4be3-a364-5f5a471c20bd@redhat.com>
Date: Mon, 11 Mar 2024 15:21:55 +0100
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [GIT PULL] KVM: x86: Selftests changes for 6.9
Content-Language: en-US
To: Sean Christopherson <seanjc@google.com>
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20240308223702.1350851-1-seanjc@google.com>
 <20240308223702.1350851-7-seanjc@google.com>
From: Paolo Bonzini <pbonzini@redhat.com>
Autocrypt: addr=pbonzini@redhat.com; keydata=
 xsEhBFRCcBIBDqDGsz4K0zZun3jh+U6Z9wNGLKQ0kSFyjN38gMqU1SfP+TUNQepFHb/Gc0E2
 CxXPkIBTvYY+ZPkoTh5xF9oS1jqI8iRLzouzF8yXs3QjQIZ2SfuCxSVwlV65jotcjD2FTN04
 hVopm9llFijNZpVIOGUTqzM4U55sdsCcZUluWM6x4HSOdw5F5Utxfp1wOjD/v92Lrax0hjiX
 DResHSt48q+8FrZzY+AUbkUS+Jm34qjswdrgsC5uxeVcLkBgWLmov2kMaMROT0YmFY6A3m1S
 P/kXmHDXxhe23gKb3dgwxUTpENDBGcfEzrzilWueOeUWiOcWuFOed/C3SyijBx3Av/lbCsHU
 Vx6pMycNTdzU1BuAroB+Y3mNEuW56Yd44jlInzG2UOwt9XjjdKkJZ1g0P9dwptwLEgTEd3Fo
 UdhAQyRXGYO8oROiuh+RZ1lXp6AQ4ZjoyH8WLfTLf5g1EKCTc4C1sy1vQSdzIRu3rBIjAvnC
 tGZADei1IExLqB3uzXKzZ1BZ+Z8hnt2og9hb7H0y8diYfEk2w3R7wEr+Ehk5NQsT2MPI2QBd
 wEv1/Aj1DgUHZAHzG1QN9S8wNWQ6K9DqHZTBnI1hUlkp22zCSHK/6FwUCuYp1zcAEQEAAc0j
 UGFvbG8gQm9uemluaSA8cGJvbnppbmlAcmVkaGF0LmNvbT7CwU0EEwECACMFAlRCcBICGwMH
 CwkIBwMCAQYVCAIJCgsEFgIDAQIeAQIXgAAKCRB+FRAMzTZpsbceDp9IIN6BIA0Ol7MoB15E
 11kRz/ewzryFY54tQlMnd4xxfH8MTQ/mm9I482YoSwPMdcWFAKnUX6Yo30tbLiNB8hzaHeRj
 jx12K+ptqYbg+cevgOtbLAlL9kNgLLcsGqC2829jBCUTVeMSZDrzS97ole/YEez2qFpPnTV0
 VrRWClWVfYh+JfzpXmgyhbkuwUxNFk421s4Ajp3d8nPPFUGgBG5HOxzkAm7xb1cjAuJ+oi/K
 CHfkuN+fLZl/u3E/fw7vvOESApLU5o0icVXeakfSz0LsygEnekDbxPnE5af/9FEkXJD5EoYG
 SEahaEtgNrR4qsyxyAGYgZlS70vkSSYJ+iT2rrwEiDlo31MzRo6Ba2FfHBSJ7lcYdPT7bbk9
 AO3hlNMhNdUhoQv7M5HsnqZ6unvSHOKmReNaS9egAGdRN0/GPDWr9wroyJ65ZNQsHl9nXBqE
 AukZNr5oJO5vxrYiAuuTSd6UI/xFkjtkzltG3mw5ao2bBpk/V/YuePrJsnPFHG7NhizrxttB
 nTuOSCMo45pfHQ+XYd5K1+Cv/NzZFNWscm5htJ0HznY+oOsZvHTyGz3v91pn51dkRYN0otqr
 bQ4tlFFuVjArBZcapSIe6NV8C4cEiSTOwE0EVEJx7gEIAMeHcVzuv2bp9HlWDp6+RkZe+vtl
 KwAHplb/WH59j2wyG8V6i33+6MlSSJMOFnYUCCL77bucx9uImI5nX24PIlqT+zasVEEVGSRF
 m8dgkcJDB7Tps0IkNrUi4yof3B3shR+vMY3i3Ip0e41zKx0CvlAhMOo6otaHmcxr35sWq1Jk
 tLkbn3wG+fPQCVudJJECvVQ//UAthSSEklA50QtD2sBkmQ14ZryEyTHQ+E42K3j2IUmOLriF
 dNr9NvE1QGmGyIcbw2NIVEBOK/GWxkS5+dmxM2iD4Jdaf2nSn3jlHjEXoPwpMs0KZsgdU0pP
 JQzMUMwmB1wM8JxovFlPYrhNT9MAEQEAAcLBMwQYAQIACQUCVEJx7gIbDAAKCRB+FRAMzTZp
 sadRDqCctLmYICZu4GSnie4lKXl+HqlLanpVMOoFNnWs9oRP47MbE2wv8OaYh5pNR9VVgyhD
 OG0AU7oidG36OeUlrFDTfnPYYSF/mPCxHttosyt8O5kabxnIPv2URuAxDByz+iVbL+RjKaGM
 GDph56ZTswlx75nZVtIukqzLAQ5fa8OALSGum0cFi4ptZUOhDNz1onz61klD6z3MODi0sBZN
 Aj6guB2L/+2ZwElZEeRBERRd/uommlYuToAXfNRdUwrwl9gRMiA0WSyTb190zneRRDfpSK5d
 usXnM/O+kr3Dm+Ui+UioPf6wgbn3T0o6I5BhVhs4h4hWmIW7iNhPjX1iybXfmb1gAFfjtHfL
 xRUr64svXpyfJMScIQtBAm0ihWPltXkyITA92ngCmPdHa6M1hMh4RDX+Jf1fiWubzp1voAg0
 JBrdmNZSQDz0iKmSrx8xkoXYfA3bgtFN8WJH2xgFL28XnqY4M6dLhJwV3z08tPSRqYFm4NMP
 dRsn0/7oymhneL8RthIvjDDQ5ktUjMe8LtHr70OZE/TT88qvEdhiIVUogHdo4qBrk41+gGQh
 b906Dudw5YhTJFU3nC6bbF2nrLlB4C/XSiH76ZvqzV0Z/cAMBo5NF/w=
In-Reply-To: <20240308223702.1350851-7-seanjc@google.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 3/8/24 23:36, Sean Christopherson wrote:
> Add SEV(-ES) smoke tests, and start building out infrastructure to utilize the
> "core" selftests harness and TAP.  In addition to provide TAP output, using the
> infrastructure reduces boilerplate code and allows running all testscases in a
> test, even if a previous testcase fails (compared with today, where a testcase
> failure is terminal for the entire test).
> 
> As noted in the PMU pull request, the "Use TAP interface" changes have a few
> conflicts.  3 of 4 are relatively straightforward, but the one in
> userspace_msr_exit_test.c's test_msr_filter_allow() is a pain.  At least, I
> thought so as I botched it at least twice.  (LOL, make that three times, as I
> just botched my test merge resolution).
> 
> The code should end up looking like this:
> 
> ---
> KVM_ONE_VCPU_TEST_SUITE(user_msr);
> 
> KVM_ONE_VCPU_TEST(user_msr, msr_filter_allow, guest_code_filter_allow)
> {
> 	struct kvm_vm *vm = vcpu->vm;
> 	uint64_t cmd;
> 	int rc;
> 
> 	sync_global_to_guest(vm, fep_available);
> 
> 	rc = kvm_check_cap(KVM_CAP_X86_USER_SPACE_MSR);
> ---
> 
> The resolutions I've been using can be found in kvm-x86/next.
> 
> 
> The following changes since commit db7d6fbc10447090bab8691a907a7c383ec66f58:
> 
>    KVM: remove unnecessary #ifdef (2024-02-08 08:41:06 -0500)
> 
> are available in the Git repository at:
> 
>    https://github.com/kvm-x86/linux.git tags/kvm-x86-selftests-6.9
> 
> for you to fetch changes up to e9da6f08edb0bd4c621165496778d77a222e1174:
> 
>    KVM: selftests: Explicitly close guest_memfd files in some gmem tests (2024-03-05 13:31:20 -0800)
> 
> ----------------------------------------------------------------
> KVM selftests changes for 6.9:
> 
>   - Add macros to reduce the amount of boilerplate code needed to write "simple"
>     selftests, and to utilize selftest TAP infrastructure, which is especially
>     beneficial for KVM selftests with multiple testcases.
> 
>   - Add basic smoke tests for SEV and SEV-ES, along with a pile of library
>     support for handling private/encrypted/protected memory.
> 
>   - Fix benign bugs where tests neglect to close() guest_memfd files.
> 
> ----------------------------------------------------------------

Pulled, thanks.

Paolo

> Ackerley Tng (1):
>        KVM: selftests: Add a macro to iterate over a sparsebit range
> 
> Dongli Zhang (1):
>        KVM: selftests: Explicitly close guest_memfd files in some gmem tests
> 
> Michael Roth (2):
>        KVM: selftests: Make sparsebit structs const where appropriate
>        KVM: selftests: Add support for protected vm_vaddr_* allocations
> 
> Peter Gonda (5):
>        KVM: selftests: Add support for allocating/managing protected guest memory
>        KVM: selftests: Explicitly ucall pool from shared memory
>        KVM: selftests: Allow tagging protected memory in guest page tables
>        KVM: selftests: Add library for creating and interacting with SEV guests
>        KVM: selftests: Add a basic SEV smoke test
> 
> Sean Christopherson (4):
>        KVM: selftests: Move setting a vCPU's entry point to a dedicated API
>        KVM: selftests: Extend VM creation's @shape to allow control of VM subtype
>        KVM: selftests: Use the SEV library APIs in the intra-host migration test
>        KVM: selftests: Add a basic SEV-ES smoke test
> 
> Thomas Huth (7):
>        KVM: selftests: x86: sync_regs_test: Use vcpu_run() where appropriate
>        KVM: selftests: x86: sync_regs_test: Get regs structure before modifying it
>        KVM: selftests: Add a macro to define a test with one vcpu
>        KVM: selftests: x86: Use TAP interface in the sync_regs test
>        KVM: selftests: x86: Use TAP interface in the fix_hypercall test
>        KVM: selftests: x86: Use TAP interface in the vmx_pmu_caps test
>        KVM: selftests: x86: Use TAP interface in the userspace_msr_exit test
> 
>   tools/testing/selftests/kvm/Makefile               |   2 +
>   tools/testing/selftests/kvm/guest_memfd_test.c     |   3 +
>   .../selftests/kvm/include/aarch64/kvm_util_arch.h  |   7 ++
>   .../selftests/kvm/include/kvm_test_harness.h       |  36 ++++++
>   .../testing/selftests/kvm/include/kvm_util_base.h  |  61 +++++++++--
>   .../selftests/kvm/include/riscv/kvm_util_arch.h    |   7 ++
>   .../selftests/kvm/include/s390x/kvm_util_arch.h    |   7 ++
>   tools/testing/selftests/kvm/include/sparsebit.h    |  56 +++++++---
>   .../selftests/kvm/include/x86_64/kvm_util_arch.h   |  23 ++++
>   .../selftests/kvm/include/x86_64/processor.h       |   8 ++
>   tools/testing/selftests/kvm/include/x86_64/sev.h   | 107 ++++++++++++++++++
>   .../testing/selftests/kvm/lib/aarch64/processor.c  |  24 +++-
>   tools/testing/selftests/kvm/lib/kvm_util.c         |  67 ++++++++++--
>   tools/testing/selftests/kvm/lib/riscv/processor.c  |   9 +-
>   tools/testing/selftests/kvm/lib/s390x/processor.c  |  13 ++-
>   tools/testing/selftests/kvm/lib/sparsebit.c        |  48 ++++----
>   tools/testing/selftests/kvm/lib/ucall_common.c     |   3 +-
>   tools/testing/selftests/kvm/lib/x86_64/processor.c |  45 +++++++-
>   tools/testing/selftests/kvm/lib/x86_64/sev.c       | 114 +++++++++++++++++++
>   .../selftests/kvm/x86_64/fix_hypercall_test.c      |  27 +++--
>   .../kvm/x86_64/private_mem_conversions_test.c      |   2 +
>   .../selftests/kvm/x86_64/sev_migrate_tests.c       |  60 +++-------
>   .../testing/selftests/kvm/x86_64/sev_smoke_test.c  |  88 +++++++++++++++
>   .../testing/selftests/kvm/x86_64/sync_regs_test.c  | 121 +++++++++++++++------
>   .../selftests/kvm/x86_64/userspace_msr_exit_test.c |  52 +++------
>   .../selftests/kvm/x86_64/vmx_pmu_caps_test.c       |  52 ++-------
>   26 files changed, 802 insertions(+), 240 deletions(-)
>   create mode 100644 tools/testing/selftests/kvm/include/aarch64/kvm_util_arch.h
>   create mode 100644 tools/testing/selftests/kvm/include/kvm_test_harness.h
>   create mode 100644 tools/testing/selftests/kvm/include/riscv/kvm_util_arch.h
>   create mode 100644 tools/testing/selftests/kvm/include/s390x/kvm_util_arch.h
>   create mode 100644 tools/testing/selftests/kvm/include/x86_64/kvm_util_arch.h
>   create mode 100644 tools/testing/selftests/kvm/include/x86_64/sev.h
>   create mode 100644 tools/testing/selftests/kvm/lib/x86_64/sev.c
>   create mode 100644 tools/testing/selftests/kvm/x86_64/sev_smoke_test.c
>