Received: by 2002:ab2:710b:0:b0:1ef:a325:1205 with SMTP id z11csp454579lql; Mon, 11 Mar 2024 07:38:34 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUQhq0qA1k2E2AWx9JuoAUsvpCvDLtrjT7b9ml7lOYL94/RuobC5hvLz1ggUGheboaG77Q1E2BfuOYAz5ZtRY6Cl7Wo8LC+s9kABmLsiQ== X-Google-Smtp-Source: AGHT+IEZz2aLIrgF61gOV6ixPb842SUbNU94YLTfbCA/b4BkGZyg6+qbjI1fEnUaXThuBEz6gICp X-Received: by 2002:a17:906:6815:b0:a45:98f3:997e with SMTP id k21-20020a170906681500b00a4598f3997emr3901017ejr.7.1710167914512; Mon, 11 Mar 2024 07:38:34 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1710167914; cv=pass; d=google.com; s=arc-20160816; b=Xh5QKXvUFeK1Twk7UnVDRqSZ0gnBZExyl2OKHBuwd/sKEKmeDtc5ooLn3j0ww7xUZK AZA6mMWbcKkEqreOQhNPbjRREnQnBLiwjXl9bKUd/x5B4oq62pXA9SFVM2wchQSIgz2S 9+ZUPKHjuNcQnQJEh6WYDqaQABsc5hmyBavubEuIF3NlGiQsz6NOhE4gdNJ2FqhqyEFe 1doty+67sRzh5Fb69vXR3U+gcwCRKhEW8knWsK2c6Bhqt5M6CKoIvFBsCuOY+rucMWoq n0yM7mISHGKgRXK1jRZYwcIebx+jJUXLeT3GhWwBppJLfMj3Mid32XyQh4ub48eIKvJt QtIA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=B13BA9QCdeALZoTVpZL3pPUk9+ARVc7Y9epMABvugvo=; fh=Op5lpeOgmsfeqBznfHLGeaWVT6K4sb/dc/7WDz2zwWE=; b=n+inxPQGdo3Oydw0wzWEB5/UtysWhvQ3Y+oIamqQsZy1nJSXv1hdKOKV8J5ETwOzYB OTsDaALslLN0wua/zJP26a51eM52uO/h1beUR6izvjiL8bk6rPpxWBMyhWk4C9K1y8jx zKjBPJubHSMfNp+achYZD8fxH1BiNrkv42YhUViC4N8A/84HksdXWVsGAIKemYHDzjCy wHxi94GWEpvWePjb2f6Vjs63iGC34pA3Z5rPbUM/FcUY89MxP82LsThO4Dd4IbQJp6IP Qb6yp+Pg6htAE0DxyoqciwwD8qf/eF/eCYRYuNfEIogDzeS7d+lqbm3PESrzx19Bhn0u 0x8g==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=XX1eeywU; arc=pass (i=1 spf=pass spfdomain=lunn.ch dkim=pass dkdomain=lunn.ch dmarc=pass fromdomain=lunn.ch); spf=pass (google.com: domain of linux-kernel+bounces-98976-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-98976-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id ji10-20020a170907980a00b00a4633d5f764si503091ejc.840.2024.03.11.07.38.34 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Mar 2024 07:38:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-98976-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=XX1eeywU; arc=pass (i=1 spf=pass spfdomain=lunn.ch dkim=pass dkdomain=lunn.ch dmarc=pass fromdomain=lunn.ch); spf=pass (google.com: domain of linux-kernel+bounces-98976-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-98976-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 212281F21F74 for ; Mon, 11 Mar 2024 14:38:34 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 35EA8405F9; Mon, 11 Mar 2024 14:38:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="XX1eeywU" Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E11143FB8F; Mon, 11 Mar 2024 14:38:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710167905; cv=none; b=a4TA104WfCF71bw3jZXJAE8VwKNHleJVwp1AQXVVQ9ZBxP3MHg84xZJ8jnfXBBTgGRl9iVDIgwJD7qL4shc7MNqKt02X9QOmtkqllm6nVXcGYw0lumX9qNp5nUyaB2JULkLiKtUtaqIE98g73qKmE+ha2ikeGbe5WzzcNXAGOxw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710167905; c=relaxed/simple; bh=oUNvmy0XwhwFNoI9rEMwHFRE7b5rGc5LDIq9FMmUvxI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=dPdxXDcWeRmbF2soCP1dcu0dnXoBRlERqI57zYa3N20Xa/4prSszL7UrIPCkMGsaGLuoFT8g40tUOGrwJm4PvAcnaB8GEavWBfqrJzllFFuOTHhDyiiRRkCqpBA8wT7LnoUuNqE+ATRRtRd57bkPKeyBP0q6536gCIoM3es0dRk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=XX1eeywU; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=B13BA9QCdeALZoTVpZL3pPUk9+ARVc7Y9epMABvugvo=; b=XX1eeywU964yOZpmresHozn1RP h/Gqy0Bzp/cWGdeLeMFkoIl3Bibn0O9DBNn4AUBn4YC2EiKBOIFpHuGbnIRE1iGYswDAgbOT3ocKk 5F3z2oKkw4NzGX5qaLkO6P9dVpWp5P9/BTWHeSh33kMxvcZszUsWA+iTJrhoMsnihItA=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1rjgnf-009yTX-0Y; Mon, 11 Mar 2024 15:38:47 +0100 Date: Mon, 11 Mar 2024 15:38:47 +0100 From: Andrew Lunn To: Elad Nachman Cc: taras.chornyi@plvision.eu, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, kory.maincent@bootlin.com, thomas.petazzoni@bootlin.com, miquel.raynal@bootlin.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/3] net: marvell: prestera: force good base mac Message-ID: <1518680f-c0b1-4dc8-be05-bd099064ac56@lunn.ch> References: <20240311135112.2642491-1-enachman@marvell.com> <20240311135112.2642491-4-enachman@marvell.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240311135112.2642491-4-enachman@marvell.com> On Mon, Mar 11, 2024 at 03:51:12PM +0200, Elad Nachman wrote: > From: Elad Nachman > > Since each switchport MAC address uses the switch base mac address > and adds the physical port number to it, > Force the last byte of the switch base mac address to be at > least 128, so when adding to it, we will not wrap around the > previous (more significant) mac address byte, resulting in a > warning message. It is not clear to me what the real problem is here. Does the hardware require that the MAC addresses always have the same upper 5 bytes? Andrew