Received: by 2002:ab2:710b:0:b0:1ef:a325:1205 with SMTP id z11csp462027lql; Mon, 11 Mar 2024 07:51:25 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVBJjmKsIud/YRU6SkLolcQ1ZQqzadnaaZgzRtFK4oSLNfw1sdHKpxpNMxCNzuyCPGBVxZWaQpYwwvJcstS1mPTcwANIDN0D/bxOzs54g== X-Google-Smtp-Source: AGHT+IFK9OMx8KZQY+lVID1llZXO2TfbDShn7mX+oFQXDVc81a/vmULCKX9/EeP6mFLaO2eKCVEp X-Received: by 2002:a05:6e02:20e9:b0:365:27ef:23d3 with SMTP id q9-20020a056e0220e900b0036527ef23d3mr8569344ilv.20.1710168685201; Mon, 11 Mar 2024 07:51:25 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1710168685; cv=pass; d=google.com; s=arc-20160816; b=k3ZBoS6qzOzITmsGbjhHRrh2BadSsR5ZtfNU0TyLnAkmBGUEFz6J5Dvqu58dVfJTuI lt3tlDyoSGTH+DdoHu8g/ZQ5PpTxEe8kaOlMMDhezhZR6vBk0XiNi1jDsTLqAiraBpNJ Il9/Q8D+KgRmNiUFockWGHBlt6ihFtQJISDNwG1JU6VMftiffL4XzAx0UdtWocysbceR 5icD15W24BZhpyKT0wfmEdaHHJR4hEmpgOnUmq5KXUnvcLC0kqtoNxKJ1KTK/9UoF8ci iBJ8kmYgYvJ6u7DCFnErRj2Cnu8h8Cb83PWfpfoHxA9fDOlW8pExSfItcP3zqkFaxX1m rlNw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date; bh=czQstxJ+6wVPm+os6tqDhJXwfX5D15KFgIoZ9hsJ6+g=; fh=FPlu27fHDu0fSTHuuUM7k87tnOtj1wIVgJb/CB2oHEE=; b=s6MrtMM8O6J1L8s743c7tOSlHO1JSp1LHJT7qH8+TR5Uo3l6FlX8dFZ42ik0Ll5DIE thK9mQUA8202Jxe4DzgYjTl9yZ8YQODWcACgBEmanvu9z033ja1ysVwrdj9HLqI8Wwqt ngujzxXxNjVdy8Zgc9Sc4j9+9dayHvTRhbFMxTe8NA3phneYD2uNjVB7bsqwBg/Y7/0g CZws8N1CBBEeYJESczZrVMelNs5xPxKOtyZhzDlJwnz5PcZf5JXYw+/VRsrGNNBc70xC Q6+uJbyVQHva62GrJO5P6Bzvyeez4wUHjG/BauCVWZ+qTqajuFKT/RV90qlxw5ZC1kOl zdUg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=arm.com dmarc=pass fromdomain=arm.com); spf=pass (google.com: domain of linux-kernel+bounces-98985-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-98985-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id n10-20020aa78a4a000000b006e688f7b061si2997407pfa.270.2024.03.11.07.51.24 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Mar 2024 07:51:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-98985-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=arm.com dmarc=pass fromdomain=arm.com); spf=pass (google.com: domain of linux-kernel+bounces-98985-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-98985-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 6E2DAB21240 for ; Mon, 11 Mar 2024 14:45:52 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id E28CD405D8; Mon, 11 Mar 2024 14:45:44 +0000 (UTC) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id D501F3FBBE for ; Mon, 11 Mar 2024 14:45:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710168344; cv=none; b=IqFKehIqIKm9eT5jYiQm9QmRoVwIS6c/tS8YPMFxxZcfcpr6lfzYVdRQbl9fK4jvU03Nwe754OmVk1YvPCGx8VtL7nh/0rGglG2nDY5l/JxpzcmsIFblCQgp73hpFUnbzTSJHy0KLw97nK/c+Cee8VpfepeKJ71StFlVt3Jb+3o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710168344; c=relaxed/simple; bh=uBHpfN0h7l6eHJcAx47Tmb4VjlizbTZis5M8Scs5vb0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=dKd2E+VcQS3xpdvI/VJgcPn1SeP5iBzEL1ho8N1s1CwCebVrB7TkrXgcDV9HM3naXp+vSsY5c0XpFQ4EkSAUtRE4YdsFk6J75Fyoc422V58z8PHfo6IHKYma0J3Bu1WU7j/lrXS4BAHDaq+uwwYCP+uWTSInxLRHsCPBTxR26yQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 9D5D7FEC; Mon, 11 Mar 2024 07:46:17 -0700 (PDT) Received: from bogus (unknown [10.57.94.75]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 5AB193F762; Mon, 11 Mar 2024 07:45:39 -0700 (PDT) Date: Mon, 11 Mar 2024 14:45:36 +0000 From: Sudeep Holla To: Jens Wiklander Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Sudeep Holla , Marc Bonnici , Olivier Deprez , Lorenzo Pieralisi Subject: Re: [PATCH v2] firmware: arm_ffa: fix ffa_notification_info_get() Message-ID: <20240311144536.za6xn2paafvegts6@bogus> References: <20240311110700.2367142-1-jens.wiklander@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240311110700.2367142-1-jens.wiklander@linaro.org> On Mon, Mar 11, 2024 at 12:07:00PM +0100, Jens Wiklander wrote: > FFA_NOTIFICATION_INFO_GET retrieves information about pending > notifications. Notifications can be either global or per VCPU. Global > notifications are reported with the partition ID only in the list of > endpoints with pending notifications. ffa_notification_info_get() > incorrectly expect no ID at all for global notifications. Fix this by > checking for 1 ID instead of 0. > LGTM, will queue it at -rc1 as fix. -- Regards, Sudeep