Received-SPF: pass (google.com: domain of linux-kernel+bounces-99147-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <42e0ff59-4c80-41ee-ba76-950db89499a1@amd.com>
Date: Mon, 11 Mar 2024 21:13:52 +0530
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH AUTOSEL 6.1 09/13] ASoC: amd: yc: add new YC platform
 variant (0x63) support
Content-Language: en-US
To: Sasha Levin <sashal@kernel.org>, linux-kernel@vger.kernel.org,
 stable@vger.kernel.org
Cc: Jiawei Wang <me@jwang.link>, Mark Brown <broonie@kernel.org>,
 lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com,
 Syed.SabaKareem@amd.com, linux-sound@vger.kernel.org
References: <20240311151354.318293-1-sashal@kernel.org>
 <20240311151354.318293-9-sashal@kernel.org>
From: "Mukunda,Vijendar" <vijendar.mukunda@amd.com>
In-Reply-To: <20240311151354.318293-9-sashal@kernel.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?TFRXSityN0RzTnB4c1UxVGlEUTVvd04yTjNJM3VuMUdmMWFNcFdycXYyT1Q0?=
 =?utf-8?B?R3h2MExITEo1NVdFMGVCd0MrU3YzN1dXODBGVWtrQXlieVhDWVoyTkZuNUJM?=
 =?utf-8?B?eGV1MUtDTmNMVVpSRmNab1M5bnFtdjVpSWxyMVo1Ni9yY0JOY3JEMlNxUlVj?=
 =?utf-8?B?QndQRmJqbGI1QVFaRG9zMlJ6dDdrQjMyaVRXbk1BeEF3blc3eitBQUtpSlNl?=
 =?utf-8?B?QUNLVFIxZVE5b3p3N042Y0xrTHE1MnVVSlRPV2FHSHdhZXBJNXg4NFpvU3VZ?=
 =?utf-8?B?Qk8zZVFXanpUbHNBZjhBTG1PelI4VUJOSmNZbWc0OUVTdnVwYTkwK0hIR3BB?=
 =?utf-8?B?eU5IRkx1bXlDMjYzK2tabWtWUHJrMFcyL1dsazN3NEVLTlN1V1RNbUdoa0dE?=
 =?utf-8?B?eVFEeDVob2pLZFZIcnltbzNCNUZLazNrVTFJYmdOOWNqUFBycWVXUFJ3K01s?=
 =?utf-8?B?Q29xQ09iaEVFd1lEUE82R1dBeHl4SUFySE9BR011WHlWazE2THVwcWZQaU1W?=
 =?utf-8?B?ZitaQTdKbUpvSDJXU1ZEUVBtdEVkME04YUd4dFk0ME9GSUd6anEzR2d1UEVi?=
 =?utf-8?B?NE41ZHZVNFVsTFlpUjB6aFNWSFN4NWRVSDlIa2x0SmlhNmNpYVplSWdCTjZ5?=
 =?utf-8?B?ZllUNTR5ZzRZUUVacnJFcmRTeW5OUlYxeUw3ZldoU2tYVGVFQnU2ZmlEbUE5?=
 =?utf-8?B?TFdPM0kzd3cra296dHR3Y2lRU2Jjb2J2RHp2MWxnWHVrbDFVUGxDVFpibWo5?=
 =?utf-8?B?UTNadDZFNUt3Q3czR2RhK29STzFhUEhaOHByd3htMFJDZWJrbEFKWU5scjB3?=
 =?utf-8?B?djZiV0l2MUtFZmFNRG44T0NDZEE4bGRtYTFKUlVuNld1alVLU2VJNHU0ZDlm?=
 =?utf-8?B?TGR2dHdoSktnQ1pyOVdjM3F1SkU3ZUsrdUhxcWtBb0lVU3pFQXZRU3ErWDVt?=
 =?utf-8?B?dFMyQ1J2blZHYTRjSUNvS2ZYODhMeUR2Y0tiWDg4Rk1ncDFvN1ZMV2cxRzA3?=
 =?utf-8?B?MjhaK282Nnk4bWpoU3lVVEExZk13WWk2Y0ZiQTdEQlQrYnhuTXo5emgyQlFJ?=
 =?utf-8?B?Mmw1Tk1EemwrUmFEZXEzbktjdGtuYkxYRFo2RCsyNzVSNmYrYURKNFo3YlFv?=
 =?utf-8?B?UkRVK0I0KzdzQWkyQ3M3aEgyZnZoTkcwS3VtME0yd0l0ak9wbXNQN2JMZ3NG?=
 =?utf-8?B?SS9QTkJRSmhBeDhNR2hvMEFyazBDMFovRE96WmlYa29UUnB5SGZ3dzVCMVlG?=
 =?utf-8?B?S3VJTXB3emtZS1ZVSG41QzdndVhYRC81Ly9RRkdCUVFCeDd0RXVDcXdWZVRu?=
 =?utf-8?B?T1A4S1RsZzd1dmhxYUlQYlFBNjJSM0ZoSjJyR0o2T0hHMzQ5eVlWcmNCZlpq?=
 =?utf-8?B?SGNHNHFGeWZuQ0FqYlZWVXhxZlNreFd6LzhWT0dTeHhXMzc3QTBrY0NpaThk?=
 =?utf-8?B?MWhMUm1mUEx5eE9QbitLVlN6U2V4cGxKck5FdjVFMXZGaEFSU3VMd1U0cDk2?=
 =?utf-8?B?WFVYSDlQM2U4L2JYUThSL0ZLUzNmQ2doRG9vQjNKMk0zblFiSjlTaGVyK05w?=
 =?utf-8?B?cktoUGE5TTNUcVg4Vi9yOFQ5cVRaZ2VQVHRLMHk4bkk5SnljVExZRzJjWmpy?=
 =?utf-8?B?UDRuSkcwOFpucmJQUmwrTmV0NVU3cGYwcVBvSmc0Y3BzWGw2Q2tlYlc3ME5M?=
 =?utf-8?B?aE4xMXl6bnRkeE5nS21ocGNTc2UvNmROMTFoVGVwUml1QjRPSzFZdkxaZjYx?=
 =?utf-8?B?UVYzRkVhRnE1b3VyV2tXWTVhYjJocHp5cmltb1VaU2JSdzZUa3llVnN6N1Zk?=
 =?utf-8?B?cXQwcHFtdGQ3SUpnVkt4UmF0ZVdwTWt5a0tEamVNWTYrZ29PMWRJWUFEYUNQ?=
 =?utf-8?B?NWlXeHNhZ0JoYWRmcHMwRlhGSU45NmhTS2toczdNcDluRmtyZVFqY3A2RmpE?=
 =?utf-8?B?dTFVcGdNUlZIUElvK3ZQZm5tYlMxOER2Y21lUjAzN2w0ZEczSndXcDVNYm0y?=
 =?utf-8?B?elF6L09rL1J2M2NIa21hNXlPTFB2eHRYRlYva3J2SnZnOUtycUdrWXlYYXda?=
 =?utf-8?B?TDFlc3ZrRHRxR0swWVk2aklES2tsejE4Sy8xbmoreksyaytMODVrZDBGWTdD?=
 =?utf-8?Q?P2iQ6nvFa68ZtfAerU4E2Z93u?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 59f58556-c882-4cd4-516b-08dc41e212af
X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB4123.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Mar 2024 15:44:01.5074
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: cKfJZ31z2IJ7MfO8Q7PiLRcVNMn9W7V6rLFgl5XgTpJt3eLdj61t5pUf4BpwYeBthm6tN4LWH+t+v4jP5JrVcA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV8PR12MB9336

On 11/03/24 20:43, Sasha Levin wrote:
> From: Jiawei Wang <me@jwang.link>
>
> [ Upstream commit 316a784839b21b122e1761cdca54677bb19a47fa ]
>
> The Lenovo 21J2 (ThinkBook 16 G5+ APO) has this new variant,
> as detected with lspci:
>
> 64:00.5 Multimedia controller: Advanced Micro Devices, Inc. [AMD]
>         ACP/ACP3X/ACP6x Audio Coprocessor (rev 63)
>
> Signed-off-by: Jiawei Wang <me@jwang.link>
> Link: https://msgid.link/r/20240228073914.232204-1-me@jwang.link
> Signed-off-by: Mark Brown <broonie@kernel.org>
> Signed-off-by: Sasha Levin <sashal@kernel.org>

This patch has to be reverted.
Pci revision id 0x63 corresponds to Pink Sardine (PS) platform.
Its not yellow corp platform.
Already PS platform ACP driver with PDM controller support available in mainline
kernel.
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/tree/sound/soc/amd/ps?h=v6.7.9

> ---
>  sound/soc/amd/yc/pci-acp6x.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/sound/soc/amd/yc/pci-acp6x.c b/sound/soc/amd/yc/pci-acp6x.c
> index 77c5fa1f7af14..81dc32f70de21 100644
> --- a/sound/soc/amd/yc/pci-acp6x.c
> +++ b/sound/soc/amd/yc/pci-acp6x.c
> @@ -156,6 +156,7 @@ static int snd_acp6x_probe(struct pci_dev *pci,
>  	/* Yellow Carp device check */
>  	switch (pci->revision) {
>  	case 0x60:
> +	case 0x63:
>  	case 0x6f:
>  		break;
>  	default: