Received-SPF: pass (google.com: domain of linux-kernel+bounces-99166-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <5b05f924-9077-4e68-9925-248470154a90@oracle.com>
Date: Mon, 11 Mar 2024 10:59:43 -0500
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 2/2] scsi: target: iscsi: don't warn of R/W when no data
Content-Language: en-US
To: lduncan@suse.com, target-devel@vger.kernel.org
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, dbond@suse.com,
        hare@suse.de, cleech@redhat.com
References: <cover.1701540918.git.lduncan@suse.com>
 <437f863520874ee386b6882ef749bf8d988839ca.1701540918.git.lduncan@suse.com>
From: michael.christie@oracle.com
In-Reply-To: <437f863520874ee386b6882ef749bf8d988839ca.1701540918.git.lduncan@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?SzAyeVZyTk5xelA1Y3dkaUV1RXBUenZCVjkrb1NMQzV1OUVEZDJkalNaaXFl?=
 =?utf-8?B?OXVLT01XS3Z2UktMTUpZSGZkWW1NVzFaakFtTDgweWxLTW5JbTNZTHNCRkNs?=
 =?utf-8?B?RUVlYXhMaVQyRVRhK2lxQldFU2NoQjlLK0s4bStwZ1BnY2JXRDBZRHI0bjVj?=
 =?utf-8?B?TGp1YUgxNi9rMzl2Rk5GL0lFRFd0cmtEUGJGbGNNR1BnQlA3dE5aNHJkS3o0?=
 =?utf-8?B?a091WTZ4dEdTZFVxdjkrNlRYajhpN1pUelg1cy9PSU54c042dVB6Mld0dGx1?=
 =?utf-8?B?KytLMUU1QzFaVmh6VnFFeU9Wa1BKdGlGcEF6anlzUEYzaitpVUprU05yeDVE?=
 =?utf-8?B?a3hBdW1OS09uaXA4MEtaVFRYL3lNdVBvWmZ4UmVudTFiQkU4dHJTQ292NUc1?=
 =?utf-8?B?MS91Unh1cllzSzh4bkhDN3NvQVI1a3YyTlRzNS9ORWhPcHF2dXI1UlFqR2Ez?=
 =?utf-8?B?OHRxaGN3eFVPTkp3b1lBakZUVlJ1Yy8xSUJ1ZHVjbWFYejFOOVJHaVpWUHBH?=
 =?utf-8?B?MWFZOHcvNENPeHJxa0NLbmV3VmdlT3Z3Tk1yZkxPaklFZEUydFBqUFdLWmht?=
 =?utf-8?B?VFZiZ0FZOUNoNUVTd3NRTkVSVU1NbngrTTJFUis0Um9URFlPbFlaWlROTXhh?=
 =?utf-8?B?bmZzbytQQThXYVR6U084OHdOd2N5aHRiZVNJRTc2YlpxT280YU9OcW80d0JC?=
 =?utf-8?B?MDZCMkpLejVzSGU5NUY0amMrTlljdi9ZbnR0SU9udVZwRThjaG1oSlViUzhy?=
 =?utf-8?B?QjlSNzIwUnAwR3pBWTQ4TURxQ1l4TVFnS0hqWC9lWElYeTZXc1VaZUo0dFJn?=
 =?utf-8?B?a3pnRXVrbEp1UlJxYks5NSt4Y0s4UW5Yc2QwQnBHanNkODBNUTkrd3A5bktw?=
 =?utf-8?B?SWp0NzN6Z1FqTWVHWGRwanVpc3hOcjBORnJRMUVTbFJCTjB6QklSaTRVNU1r?=
 =?utf-8?B?bzh1SHh2U0ViQ3N2MGIxejRadHFrOURabm14NDFNVzR3U0JRL1JzTWxjaHcy?=
 =?utf-8?B?TmpyM2tneHJoYVZhRGpwZit3TzlGZWZSUXlpaUZ5TDlOakRmaFdMU3F4TUZl?=
 =?utf-8?B?OG42NWtrbnQxVjVxY0VVMVkzN09zTnJ1UUJXeG5EdkpYZnJaaTBvQ2FMdDVT?=
 =?utf-8?B?V3ArZ3lRTFZ4UXl2SFhKemFnOUFXSm9Fcng0N01TUEh2OE8zRTBlWnA1MHA5?=
 =?utf-8?B?QS9JN3kxMkU1anZVdkxZMmJQYW9MbElzYk9ta2hJYXlFNm1lTExOMDVlYy9x?=
 =?utf-8?B?dGNKY2swaTFNMUlxRFZidGpEQkQvanB3bE50VitrcitmSHAzTTFvVUJYQWsw?=
 =?utf-8?B?Z1RodktqV1RVN09MbjdMcllubnRKakhiejM0bzlON2Z3SDJqclZZS3p3Wk9Y?=
 =?utf-8?B?QmxDeUNCbnRzYTFmMlZKTlRhc0NkRFdpYlJTcGhobVhlTWNxMG1IYjZGbUR0?=
 =?utf-8?B?QmF3aDQ1RFlUdDBxcVZiSy8wOVdvSjNHL3N3MmtmMU1XUVoxQTE0TXNDQXNa?=
 =?utf-8?B?RnU0ZnJKcXhwTW1XVHpRamk0MXY2Z1V5Q3ErNTdpZ2xzUlVMQ2hVYXZBaHBw?=
 =?utf-8?B?dFcxYUd2WjZtak5TdnpqUVhwZ1lpbGNEQmRSQW1XQTNNbTNMMnZtMGxUVlht?=
 =?utf-8?B?ajNGcmcyUkpseUNuOGNoL2l5U0hGS09LNDI4a3E0ZmJBbWdwTm1TUTQ3LzlL?=
 =?utf-8?B?aktMTzIzQ2Y4TnF3WEtIVUp3TmsrWWx0TXBTeDBDWXp5d2xwdUx6YXhFZWk3?=
 =?utf-8?B?dmpWcm9rdHljUEdkSlEzZ0JCZnVoamgxWDVQMW5tYlJOL09aUnFhNFFrOFhQ?=
 =?utf-8?B?cVczRHpFUmNGTnFGa1NKalU4SHBaVXNtZnV1bEdvS3JzSmR1dXpXbWhyVDIr?=
 =?utf-8?B?Q3plbDFLeFZCb21JU3NEd0FMbHpzTWRsNkh0OUUrV1J3dzdQK3JtSm40ejI4?=
 =?utf-8?B?d0NBTmVHWXk5N1pIYU1peW80ZURzZ0NQUk5CcWlLYzFYaHV2R0ZSclRrSFky?=
 =?utf-8?B?MHZQcTdoczhndWtod3JwZHRqbDRpakNTTHJzb2x0K1QrR1V2NjR6SzlIYU5I?=
 =?utf-8?B?OEhTSnFGSGhveURsbUFVbm41YXgybVA1aXdkcWJ5WlpwdXJpSFJRMHQ2dTQx?=
 =?utf-8?B?WmJhZG44dndkZkV4Wm4wN0JSODVnOWU0c0xBQWo2QW50YXJQU3FsWEFRTmFu?=
 =?utf-8?B?cWc9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	vwGKwZsrd7cd+iYXHRr0ydRGyiwEP5zONIwasgWltn3O6M7RZExguPTPSOJjAH90JDEMABPUpBejdNa6R9wrCv8iOlyNXviXSeaOC0AxYmuS/A4kQ84WL7qg/1cf2o/16Z5RzQJHi4oUmUDvXfxCs++YCGhtc674WEQxNIGq+7fnpD2fXvPGxEODx6232Hk3ujYsOdxeKCM8WoAuwHkn+XO6Dfq7KLvkZ+HyjcyYNxATlhPaW4KEoIan1vvSG29JdqS+1VCEUoLKOxEpDIgS8lEmPIdJNciSLd89vHq772IFIP/YZ0Rrwl2SdDu5l/hEXzH7QP4bOzoZaAyMJNzhSXYZftWEavjtE+61f9wMIi7FPc8y20KrQEQVcqRKR38WdTYEdSt0zgAwRBw0DlbAaQb8GstEGd1suOXL0pEXGi5pcGt0nXijII/n8HOwcWfCQmuJEgi04iQx+ZuwX6kIazUtm5CNOgmNAS/tswYfvFg6vhqmZcTezeQuAc+pyubZm/+55SYGKw2cQS5ZZ0tYaAsCM/DXWjwYZQ5tWmGeejpwGtSorHJE0+gF21n0l6ofi6EHzlxSGMiZhPJnShk+PEqHYkaBZProjfCodgpPwuE=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9a45d70d-7ecd-42a8-8751-08dc41e445a2
X-MS-Exchange-CrossTenant-AuthSource: CY8PR10MB7243.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Mar 2024 15:59:45.7615
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: CRr5C0utA29wpsclMKtxrX/KyZBu0EbRT1SNmA010AyPnNrGMvwCAYQDp9RP6BeJhRgG4G1Ygw/wdRM8tZjQxdpL2e+gToCPCjGgeHhqDrQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR10MB4273
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-03-11_10,2024-03-11_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 spamscore=0
 mlxlogscore=999 bulkscore=0 phishscore=0 malwarescore=0 mlxscore=0
 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2311290000 definitions=main-2403110121
X-Proofpoint-GUID: cfbwrVrEAsqb-_CqStGx5NbzhcliHHJi
X-Proofpoint-ORIG-GUID: cfbwrVrEAsqb-_CqStGx5NbzhcliHHJi

On 12/7/23 11:42 AM, lduncan@suse.com wrote:
> From: Lee Duncan <lduncan@suse.com>
> 
> The LIO target code has a warning about setting the
> read and/or write header bits with a PDU that has zero
> transfer length, even though the code mentions that the
> SPEC (RFC 3720) allows this, and that some initiators
> set these bits. But in practice such initiators end up
> flooding the logs with thousands of warning messages for
> IO that is allowed.
> 

I've never seen us hit this. What initiator is doing this and what is 
the command they are sending?

Is it also related to the first patch? Is some initiator sending 
something like a TUR with the immediate bit set during some sort of 
stall/timeout?