Received-SPF: pass (google.com: domain of linux-kernel+bounces-99179-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Precedence: bulk
MIME-Version: 1.0
References: <1707524971-146908-1-git-send-email-quic_obabatun@quicinc.com> <1707524971-146908-4-git-send-email-quic_obabatun@quicinc.com>
In-Reply-To: <1707524971-146908-4-git-send-email-quic_obabatun@quicinc.com>
From: Rob Herring <robh+dt@kernel.org>
Date: Mon, 11 Mar 2024 10:02:16 -0600
Message-ID: <CAL_Jsq+LUVZF40vrf-3p77DLk5XLOgA0RF9duUHUthyUk5r7OQ@mail.gmail.com>
Subject: Re: [PATCH 3/3] sh: Call paging_init() earlier in the init sequence
To: Oreoluwa Babatunde <quic_obabatun@quicinc.com>
Cc: chenhuacai@kernel.org, jonas@southpole.se, 
	stefan.kristiansson@saunalahti.fi, shorne@gmail.com, 
	ysato@users.sourceforge.jp, dalias@libc.org, glaubitz@physik.fu-berlin.de, 
	frowand.list@gmail.com, linux-openrisc@vger.kernel.org, 
	loongarch@lists.linux.dev, linux-sh@vger.kernel.org, 
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, kernel@quicinc.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, Feb 9, 2024 at 5:29=E2=80=AFPM Oreoluwa Babatunde
<quic_obabatun@quicinc.com> wrote:
>
> The unflatten_device_tree() function contains a call to
> memblock_alloc(). This is a problem because this allocation is done
> before any of the reserved memory is set aside in paging_init().
> This means that there is a possibility for memblock to allocate from
> any of the memory regions that are supposed to be set aside as reserved.
>
> Hence, move the call to paging_init() to be earlier in the init
> sequence so that the reserved memory regions are set aside before any
> allocations are done using memblock.
>
> Signed-off-by: Oreoluwa Babatunde <quic_obabatun@quicinc.com>
> ---
>  arch/sh/kernel/setup.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Rob Herring <robh@kernel.org>