Received-SPF: pass (google.com: domain of linux-kernel+bounces-99203-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <33b7a57e-1df8-47ee-94d7-aa646a9e923c@amd.com>
Date: Mon, 11 Mar 2024 11:16:47 -0500
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 01/14] x86/sev: Rename snp_init() in the
 boot/compressed/sev.c file
Content-Language: en-US
To: Borislav Petkov <bp@alien8.de>
Cc: linux-kernel@vger.kernel.org, x86@kernel.org,
 Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
 Dave Hansen <dave.hansen@linux.intel.com>, "H. Peter Anvin" <hpa@zytor.com>,
 Andy Lutomirski <luto@kernel.org>, Peter Zijlstra <peterz@infradead.org>,
 Dan Williams <dan.j.williams@intel.com>, Michael Roth
 <michael.roth@amd.com>, Ashish Kalra <ashish.kalra@amd.com>
References: <cover.1709922929.git.thomas.lendacky@amd.com>
 <d558343480a78b53ac419ce67fc9f13d631672a4.1709922929.git.thomas.lendacky@amd.com>
 <20240310212521.GBZe4lQWwIQSBsaCLc@fat_crate.local>
From: Tom Lendacky <thomas.lendacky@amd.com>
Autocrypt: addr=thomas.lendacky@amd.com; keydata=
 xsFNBFaNZYkBEADxg5OW/ajpUG7zgnUQPsMqWPjeAxtu4YH3lCUjWWcbUgc2qDGAijsLTFv1
 kEbaJdblwYs28z3chM7QkfCGMSM29JWR1fSwPH18WyAA84YtxfPD8bfb1Exwo0CRw1RLRScn
 6aJhsZJFLKyVeaPO1eequEsFQurRhLyAfgaH9iazmOVZZmxsGiNRJkQv4YnM2rZYi+4vWnxN
 1ebHf4S1puN0xzQsULhG3rUyV2uIsqBFtlxZ8/r9MwOJ2mvyTXHzHdJBViOalZAUo7VFt3Fb
 aNkR5OR65eTL0ViQiRgFfPDBgkFCSlaxZvc7qSOcrhol160bK87qn0SbYLfplwiXZY/b/+ez
 0zBtIt+uhZJ38HnOLWdda/8kuLX3qhGL5aNz1AeqcE5TW4D8v9ndYeAXFhQI7kbOhr0ruUpA
 udREH98EmVJsADuq0RBcIEkojnme4wVDoFt1EG93YOnqMuif76YGEl3iv9tYcESEeLNruDN6
 LDbE8blkR3151tdg8IkgREJ+dK+q0p9UsGfdd+H7pni6Jjcxz8mjKCx6wAuzvArA0Ciq+Scg
 hfIgoiYQegZjh2vF2lCUzWWatXJoy7IzeAB5LDl/E9vz72cVD8CwQZoEx4PCsHslVpW6A/6U
 NRAz6ShU77jkoYoI4hoGC7qZcwy84mmJqRygFnb8dOjHI1KxqQARAQABzSZUb20gTGVuZGFj
 a3kgPHRob21hcy5sZW5kYWNreUBhbWQuY29tPsLBmQQTAQoAQwIbIwcLCQgHAwIBBhUIAgkK
 CwQWAgMBAh4BAheAAhkBFiEE3Vil58OMFCw3iBv13v+a5E8wTVMFAmWDAegFCRKq1F8ACgkQ
 3v+a5E8wTVOG3xAAlLuT7f6oj+Wud8dbYCeZhEX6OLfyXpZgvFoxDu62OLGxwVGX3j5SMk0w
 IXiJRjde3pW+Rf1QWi/rbHoaIjbjmSGXvwGw3Gikj/FWb02cqTIOxSdqf7fYJGVzl2dfsAuj
 aW1Aqt61VhuKEoHzIj8hAanlwg2PW+MpB2iQ9F8Z6UShjx1PZ1rVsDAZ6JdJiG1G/UBJGHmV
 kS1G70ZqrqhA/HZ+nHgDoUXNqtZEBc9cZA9OGNWGuP9ao9b+bkyBqnn5Nj+n4jizT0gNMwVQ
 h5ZYwW/T6MjA9cchOEWXxYlcsaBstW7H7RZCjz4vlH4HgGRRIpmgz29Ezg78ffBj2q+eBe01
 7AuNwla7igb0mk2GdwbygunAH1lGA6CTPBlvt4JMBrtretK1a4guruUL9EiFV2xt6ls7/YXP
 3/LJl9iPk8eP44RlNHudPS9sp7BiqdrzkrG1CCMBE67mf1QWaRFTUDPiIIhrazpmEtEjFLqP
 r0P7OC7mH/yWQHvBc1S8n+WoiPjM/HPKRQ4qGX1T2IKW6VJ/f+cccDTzjsrIXTUdW5OSKvCG
 6p1EFFxSHqxTuk3CQ8TSzs0ShaSZnqO1LBU7bMMB1blHy9msrzx7QCLTw6zBfP+TpPANmfVJ
 mHJcT3FRPk+9MrnvCMYmlJ95/5EIuA1nlqezimrwCdc5Y5qGBbbOwU0EVo1liQEQAL7ybY01
 hvEg6pOh2G1Q+/ZWmyii8xhQ0sPjvEXWb5MWvIh7RxD9V5Zv144EtbIABtR0Tws7xDObe7bb
 r9nlSxZPur+JDsFmtywgkd778G0nDt3i7szqzcQPOcR03U7XPDTBJXDpNwVV+L8xvx5gsr2I
 bhiBQd9iX8kap5k3I6wfBSZm1ZgWGQb2mbiuqODPzfzNdKr/MCtxWEsWOAf/ClFcyr+c/Eh2
 +gXgC5Keh2ZIb/xO+1CrTC3Sg9l9Hs5DG3CplCbVKWmaL1y7mdCiSt2b/dXE0K1nJR9ZyRGO
 lfwZw1aFPHT+Ay5p6rZGzadvu7ypBoTwp62R1o456js7CyIg81O61ojiDXLUGxZN/BEYNDC9
 n9q1PyfMrD42LtvOP6ZRtBeSPEH5G/5pIt4FVit0Y4wTrpG7mjBM06kHd6V+pflB8GRxTq5M
 7mzLFjILUl9/BJjzYBzesspbeoT/G7e5JqbiLWXFYOeg6XJ/iOCMLdd9RL46JXYJsBZnjZD8
 Rn6KVO7pqs5J9K/nJDVyCdf8JnYD5Rq6OOmgP/zDnbSUSOZWrHQWQ8v3Ef665jpoXNq+Zyob
 pfbeihuWfBhprWUk0P/m+cnR2qeE4yXYl4qCcWAkRyGRu2zgIwXAOXCHTqy9TW10LGq1+04+
 LmJHwpAABSLtr7Jgh4erWXi9mFoRABEBAAHCwXwEGAEKACYCGwwWIQTdWKXnw4wULDeIG/Xe
 /5rkTzBNUwUCZYMCBQUJEqrUfAAKCRDe/5rkTzBNU7pAD/9MUrEGaaiZkyPSs/5Ax6PNmolD
 h0+Q8Sl4Hwve42Kjky2GYXTjxW8vP9pxtk+OAN5wrbktZb3HE61TyyniPQ5V37jto8mgdslC
 zZsMMm2WIm9hvNEvTk/GW+hEvKmgUS5J6z+R5mXOeP/vX8IJNpiWsc7X1NlJghFq3A6Qas49
 CT81ua7/EujW17odx5XPXyTfpPs+/dq/3eR3tJ06DNxnQfh7FdyveWWpxb/S2IhWRTI+eGVD
 ah54YVJcD6lUdyYB/D4Byu4HVrDtvVGUS1diRUOtDP2dBJybc7sZWaIXotfkUkZDzIM2m95K
 oczeBoBdOQtoHTJsFRqOfC9x4S+zd0hXklViBNQb97ZXoHtOyrGSiUCNXTHmG+4Rs7Oo0Dh1
 UUlukWFxh5vFKSjr4uVuYk7mcx80rAheB9sz7zRWyBfTqCinTrgqG6HndNa0oTcqNI9mDjJr
 NdQdtvYxECabwtPaShqnRIE7HhQPu8Xr9adirnDw1Wruafmyxnn5W3rhJy06etmP0pzL6frN
 y46PmDPicLjX/srgemvLtHoeVRplL9ATAkmQ7yxXc6wBSwf1BYs9gAiwXbU1vMod0AXXRBym
 0qhojoaSdRP5XTShfvOYdDozraaKx5Wx8X+oZvvjbbHhHGPL2seq97fp3nZ9h8TIQXRhO+aY
 vFkWitqCJg==
In-Reply-To: <20240310212521.GBZe4lQWwIQSBsaCLc@fat_crate.local>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?WGphUXVlczhDOWVBejJ4V1BuYzllejNadS81ZFhLUmtvWXUvU2xYL1UrNkN1?=
 =?utf-8?B?a0EzMlI4eTFuQkU0ZjVaNUJrNWt0b3RoRWNQWnd6czVsZ212WUlpd0VqVlFh?=
 =?utf-8?B?dk92a0FwalYybkxzTHJBVEo0YjZFbm9zTHA5QkJPeWJkanJLazdnbFZYNzdV?=
 =?utf-8?B?aFZ2aGxFT0V4UnR1R1c1eVFySXYwdDRiNlBHQzc5bGxYb08zL3AxeitzS1F5?=
 =?utf-8?B?YmZkMGpJdDNReWNyY1VhcEtmYU53TTE0dVJtTGhaTXAxZ0Q5dDRiVG80UjFK?=
 =?utf-8?B?MVR5MDV3SU5rQnJxdS83L0FuMllOOXVGN1VQbndWWURNMXJ4NjNPSk9RQ3pF?=
 =?utf-8?B?aWlJTno1KzlXdzVmYzkrY1pqN0srRnhHaGxyVlg4QVdRazJieXlPT25Ramg2?=
 =?utf-8?B?L2FjS1ZLR241cm94a3dMdDJkbHBKY09JQ2Y1aWtPZ2E3WWc3MFZyTUNMdDNG?=
 =?utf-8?B?SEMvalZXd0JQZEhCcURva2lJemZRdy95SUxCMVpZTXIyUWtlbGNyTmZYNkdr?=
 =?utf-8?B?a2dSMGx2TmwrZlQrV2p0SzNiQlA5ajBVdjJhQy9GVmRzK3pEZEcvbVpxbmI5?=
 =?utf-8?B?b2hQMDhQY1BFejhXRGhPZkdTRDB6ZXJIenZad2FuZ3VJRTZTUGJMR3ZZcDZq?=
 =?utf-8?B?Q0ppZzlYekdjMS9pYkVjaTlsN1NlZUxkVWoxYlZvN0hWa1dxamRSMzl5VlJr?=
 =?utf-8?B?UU9zbkdxL21ONCtuOEI5RThsSnE1NnhFdC9MMDJvSWl0ckI3UlhIOTlZMUVB?=
 =?utf-8?B?clJZYUFqMGcyZngxdks4THFIRzE5RVhvVlFSV0RhMkk4THB0bVkreENLQVRE?=
 =?utf-8?B?aTR1NnJpYTF5RmNsTGdBS3IrQkdIbW90dFl3MGFKTW96MDNST09SeEFIV1kz?=
 =?utf-8?B?N25GS2RZSFNYR0VuMTVFSFhvY2VNVWpheTdKOWd2MGtYSm5GdFBub05uS3VQ?=
 =?utf-8?B?RTVGUWZIc0V2OC9xTEc4RHFLSVhhTWttRXFyUGJrRlB3SmVuSjZHZTUwRGZi?=
 =?utf-8?B?ZVRsTDQ2ci9pZW9DbTBUaFM2d29qZGRGTFhEb0J4VXRLZEE2ZjJmQ2tVRWxD?=
 =?utf-8?B?QU9zaXlYVUF4TEthVTV1S2hNbEQ3KzFpL3l1c3VlR0RKTnhxVUFYbitDZWVw?=
 =?utf-8?B?Z3E2YTcyT0NoNkpvT1gzVHpCRW9Ucm5OSzJxYWZYVzk1SlFJbjlVeDNTeGM1?=
 =?utf-8?B?SW0yU3h0RUIrdUJWOTl0bGVjUDlPRGI0dFhrVGJoUGQ2eU1ldUVXbndFRGRw?=
 =?utf-8?B?YzhpWHVGdnovV2JmQU1pQzFYQ1NjS1FTWW1aTk5IU2hjWWpUOWlBZEpBc2lG?=
 =?utf-8?B?T1FyMHJhRCtaeWMxdmpWa2J0RE5DTFpxSG5QbzBFb1VYUGdWNTk4MkZEaEFh?=
 =?utf-8?B?Z2gzM1NZTTVjaWpYVVRieGpuTllsN002dWNFZXc3Rjlwa2VoYTJjMVJscXQ2?=
 =?utf-8?B?Smk1am9CVGRuN3krNDlHMzFwM1N4bXBDdnlxdjkyVTJOckNPYWpKMTN0YW1M?=
 =?utf-8?B?N0RIeXo1SlJxQmFMS2YvbTFPdVlrRGpnNTJZM1FjV2J0ZE0zaDN4R0p1N29p?=
 =?utf-8?B?OXNsc21ZWUJPYkRPdVFSZ1dXTU1nVWQ1MHIrdi9rdktaa2JhbUNHRGh3RTdL?=
 =?utf-8?B?RGVzck5OWlJCNU5INXVwdnJGdzdBWG1JaEsrZWlYRUIvWm5DNmtBM1lZa1ZC?=
 =?utf-8?B?RWFVY0hFL1lQQnZ0Q3lUcU5sVkxkY1YxdFJsSFBzQk9SR0hUcHZvdjJBK0Nq?=
 =?utf-8?B?WDhiMmczZjh3ZzE5VlVNdzFVeDUyOE1SL2ZDYVZraDR2bWZ6WGVmTENUMlRS?=
 =?utf-8?B?dUpTM0k3czZLWktRaEs2TnFLcVdBUC9SaWhsU2hrS2tsZE5TeitSZXIvbHhh?=
 =?utf-8?B?SXgwdGduQ01yNmpLdHYvamQwNVg5TXJHaE91ZFdEblB4R0lKM21CYUhFdFlv?=
 =?utf-8?B?bEFNNzQ2VnM0NjZJNlpuRHZvU3Y1VEY2eDFDaitXUk9WcTJ1dFlMQkFEMUE4?=
 =?utf-8?B?QUhzZVVES1F5YnA1b1lnQzR1b2Z2b1FLZlVmNThNRlJ5ZEpaMmMwZExTQWc5?=
 =?utf-8?B?UGo3ZkxTdGVaRkJlb3l1RmM1NXd2UzZoUGRwQnU4Q01vdHk1eVVoYVhzL1Iy?=
 =?utf-8?Q?EdAgwAZNcTV5b3MjXeWZfBh9/?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 780c29b7-8c77-4557-0a75-08dc41e6a753
X-MS-Exchange-CrossTenant-AuthSource: BL1PR12MB5732.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Mar 2024 16:16:48.6536
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Bxzn1FmQrduxTyWzFrG8T6EMhRu84mv41QyvNT2vySC0hm/m4fFDQsw7X+F7ACO0AZDUxDrdyviB9aXznNsb9g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB7747


On 3/10/24 16:25, Borislav Petkov wrote:
> On Fri, Mar 08, 2024 at 12:35:16PM -0600, Tom Lendacky wrote:
>> @@ -478,7 +557,7 @@ void sev_enable(struct boot_params *bp)
>>   	 * Setup/preliminary detection of SNP. This will be sanity-checked
>>   	 * against CPUID/MSR values later.
>>   	 */
>> -	snp = snp_init(bp);
>> +	snp = snp_setup(bp);
> 
> So if you call the compressed/sev.c version early_snp_init() or
> boot_snp_init() or something similar, you know immediately when it is

Yep, makes sense. Will change it.

Thanks,
Tom

> called vs having to grep the tree to figure out which is which - was
> snp_setup() early or was it in the kernel proper.  And so on...
>