Received-SPF: pass (google.com: domain of linux-kernel+bounces-99239-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <685a957d-5ce4-4165-aa6d-71570866b9d4@gmail.com>
Date: Mon, 11 Mar 2024 10:26:56 -0600
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [BUG net-next] fcnal-test.sh: 4 (four) tests FAIL
Content-Language: en-US
To: Jakub Kicinski <kuba@kernel.org>,
 Mirsad Todorovac <mirsad.todorovac@alu.unizg.hr>
Cc: netdev@vger.kernel.org, Guillaume Nault <gnault@redhat.com>,
 "David S. Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>,
 Paolo Abeni <pabeni@redhat.com>, Shuah Khan <shuah@kernel.org>,
 linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
References: <9f24a9c3-4813-4518-9cc4-3923c11981cd@alu.unizg.hr>
 <20240311091751.5c4f2947@kernel.org>
From: David Ahern <dsahern@gmail.com>
In-Reply-To: <20240311091751.5c4f2947@kernel.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 3/11/24 10:17 AM, Jakub Kicinski wrote:
> On Sat, 9 Mar 2024 19:45:15 +0100 Mirsad Todorovac wrote:
>> In the vanilla net-next tree build of v6.8-rc7-2348-g75c2946db360, with up-to-date
>> iproute2 built tools, fcnal-test.sh reports certain failures:
>>
>> --------------------------------------------------------------------------------------
>> # TEST: ping local, VRF bind - VRF IP                                           [FAIL]
>> # TEST: ping local, device bind - ns-A IP                                       [FAIL]
>> # TEST: ping local, VRF bind - VRF IP                                           [FAIL]
>> # TEST: ping local, device bind - ns-A IP                                       [FAIL]
>> --------------------------------------------------------------------------------------
> 
> Adding David A to CC.
> 
> It rings a bell. We also build ping from source when running the tests
> locally, I have in my notes "AWS iputils are buggy, use iputils.git"
> but unfortunately I didn't make a note which tests were failing without
> it. David might remember..

yes, please update ping -- make sure it has proper support for
SO_BINDTODEVICE.

It's a bug in versions of iputils ping. It sets the BINDTODEVICE and
then resets it because the source address is not set on the command line
(it should not be required - they are separate intents).