Received-SPF: pass (google.com: domain of linux-kernel+bounces-99320-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Precedence: bulk
MIME-Version: 1.0
References: <cover.1710133771.git.sandipan.das@amd.com> <e100c902fd9e1e4f58e3a9c175d572962a9cdd50.1710133771.git.sandipan.das@amd.com>
In-Reply-To: <e100c902fd9e1e4f58e3a9c175d572962a9cdd50.1710133771.git.sandipan.das@amd.com>
From: Ian Rogers <irogers@google.com>
Date: Mon, 11 Mar 2024 10:43:35 -0700
Message-ID: <CAP-5=fU=gO49ASVVLUbT5bFPoOE3qi3+xJqvRD3tA=upVUT_aQ@mail.gmail.com>
Subject: Re: [PATCH 2/4] perf vendor events amd: Add Zen 5 uncore events
To: Sandipan Das <sandipan.das@amd.com>
Cc: linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, 
	peterz@infradead.org, mingo@redhat.com, acme@kernel.org, namhyung@kernel.org, 
	mark.rutland@arm.com, alexander.shishkin@linux.intel.com, jolsa@kernel.org, 
	adrian.hunter@intel.com, eranian@google.com, ravi.bangoria@amd.com, 
	ananth.narayan@amd.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Sun, Mar 10, 2024 at 10:24=E2=80=AFPM Sandipan Das <sandipan.das@amd.com=
> wrote:
>
> Add uncore events taken from Section 1.5 "L3 Cache Performance Monitor
> Counters" and Section 2 "UMC Performance Monitors" of the Performance
> Monitor Counters for AMD Family 1Ah Model 00h-0Fh Processors document
> available at the link below. This constitutes events which capture L3
> cache and UMC command activity.

Why do the L3 uncore PMU events go in the same topic as the core/cpu
events, but the memory controller events not? Could they both go in
separate files to make better use of the topic?

Thanks,
Ian

> Link: https://bugzilla.kernel.org/attachment.cgi?id=3D305974
> Signed-off-by: Sandipan Das <sandipan.das@amd.com>
> ---
>  .../pmu-events/arch/x86/amdzen5/cache.json    | 175 ++++++++++++++++++
>  .../arch/x86/amdzen5/memory-controller.json   | 101 ++++++++++

[ ... snip ... ]