Received: by 2002:ab2:710b:0:b0:1ef:a325:1205 with SMTP id z11csp602634lql; Mon, 11 Mar 2024 11:36:57 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVfDcuSTPHf54JUTx7Lba6oSuanPeGoSvqoHihxbvNh5d2SuAhmfAQQwcofk5Pxzjjhk+Avd6XziqLpUB5tKi8sjgIs+foxLlFkWXxbww== X-Google-Smtp-Source: AGHT+IFz7OfSp0zpTsd4FmiU9MBozJK/q/ae4VfNSl9WecxTT4hp4jsbKK20AyPROfboLBMQtSkk X-Received: by 2002:a05:620a:46a9:b0:788:358a:9b83 with SMTP id bq41-20020a05620a46a900b00788358a9b83mr14602740qkb.26.1710182217693; Mon, 11 Mar 2024 11:36:57 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1710182217; cv=pass; d=google.com; s=arc-20160816; b=fxVh79+Xt2lrLvweND2vPvtSHhROvHrUpj3m1xVa0IQmxfk56W3oeb19GPJ08dn3EH 8G6jK+iZw78znJtfFvP8nF56cPvnEcgSgn/iyxBO0dzxBJDSPy28epwGTDtbg72Nn79Y GD8PZqr7weMiWDLRoVkh1GBbRXXVBfpQ2vqtxt3gM+fkNxe7Hkxwi6oKUijr4aqpSVk4 8vK8DsYBJ3Q/vmt4mpg2DIDKyjoxd/S/LAkumThlVsuB8yH1BzhY1X5ba+r5OQuexA4Y eq1gCHMaAEDE/V1VcGdmj54VkwHV4OKPyFTywaoWofFIhmVd7hp7KzqEnixeGl+nHSf+ XOTQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:dkim-signature; bh=Jei4j646X+qAfUBer/BW9QqCwZVGvbPajQsPIyjkMCg=; fh=ss6nomEqfcDAeO0I6E8j0jRQDmmbubVW8/MMBR7DpzU=; b=ZAgOKKtlxng95g/ZBKVMQtUaeQfAQO3P6eY+DEn4ZH+SHb1w/sNeZOVc2O5UOGWPZL /EZNPMwOSa2Mh9bWUab9tOqULTTHX699ZZGPZ3QG5saehx2k0OcOWL/ZVBJzTcPHtSHS 3JjJ4zyzslfDHisoDILm9zZohAnFXViSoDQFjDjyGzjDtWh8FGCyxlJkfNYNViqIxaik bSXnWP5WlhYNYL1ogglYBZk317a195RdSUy2GpzzH3Uq4yDOs3hT0K3dRJ9TD1hCKYQH /TD03by4Sy1B0cNL6lZ3jXBLeM8nf5P61UY/eCwW4zC3okayzrfRVmzTZlMYtcwT/95Z i7IQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@acm.org header.s=mr01 header.b=KDm0NJ3M; arc=pass (i=1 spf=pass spfdomain=acm.org dkim=pass dkdomain=acm.org dmarc=pass fromdomain=acm.org); spf=pass (google.com: domain of linux-kernel+bounces-99373-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-99373-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=acm.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id x26-20020ae9f81a000000b007887100ff01si1986636qkh.286.2024.03.11.11.36.57 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Mar 2024 11:36:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-99373-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@acm.org header.s=mr01 header.b=KDm0NJ3M; arc=pass (i=1 spf=pass spfdomain=acm.org dkim=pass dkdomain=acm.org dmarc=pass fromdomain=acm.org); spf=pass (google.com: domain of linux-kernel+bounces-99373-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-99373-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=acm.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 4F3441C20E03 for ; Mon, 11 Mar 2024 18:36:57 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 2DE5056440; Mon, 11 Mar 2024 18:35:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=acm.org header.i=@acm.org header.b="KDm0NJ3M" Received: from 009.lax.mailroute.net (009.lax.mailroute.net [199.89.1.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C913654FB7; Mon, 11 Mar 2024 18:35:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=199.89.1.12 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710182151; cv=none; b=Q2O7pK+cLwiiTDolpSSPLxMs1Dcdi+rrD6EiBxkMn+/EENTc0HBjjJNLNHrh8LukFM46M6zyJgfO58RxSShFiubnxmxsURxXxFclk6rYw215CKNX6mEas1ocwuGsDoNZ3wevM58BWfe+Cf0gGeW6+5VOTFRytRFlApUyZ9ffFhw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710182151; c=relaxed/simple; bh=1qqTjwiqgN85QvoiAJaeXNcYRAKfZNdrXjznxqp5uzg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=eNs1my3/1UPM9dZegF/nKiL0xYef1zpokhSv4Osxsowx7S10EYqg3mhdqY6zyIZWCmlK3LNekdYGBMXQC/0JRUaoOMeZQz71LjfNY4G8nLiujrzOqh+UgtcEHVH7SI41+rEOD8tz5RjGDmk8usA33s5bgFjDAa1O8TwCqT7rHT8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=acm.org; spf=pass smtp.mailfrom=acm.org; dkim=pass (2048-bit key) header.d=acm.org header.i=@acm.org header.b=KDm0NJ3M; arc=none smtp.client-ip=199.89.1.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=acm.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=acm.org Received: from localhost (localhost [127.0.0.1]) by 009.lax.mailroute.net (Postfix) with ESMTP id 4TtlpF2QrLzlgVnY; Mon, 11 Mar 2024 18:35:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=acm.org; h= content-transfer-encoding:content-type:content-type:in-reply-to :from:from:references:content-language:subject:subject :user-agent:mime-version:date:date:message-id:received:received; s=mr01; t=1710182147; x=1712774148; bh=Jei4j646X+qAfUBer/BW9QqC wZVGvbPajQsPIyjkMCg=; b=KDm0NJ3MH7y4Eu4RVntOJLioFNM+2UQI28pqbztV zT2lNOLbQjyr12SLe1aiIFHe/D+ih3IBIIcnEKL9UT2Kjo94tboz+XyzHyRFrIcG l8NQcE+q4s8nBU2ZJPWeDU0+W331sDDxN3hMr0ZxV47bWR5Wiy1lOsa+aF3CLfn7 iweVQpK1v41BLCWbQ9KDJuKaEzE405jNecUjl19EpqgB+CHA1CqGomUWmElY15pe JZE07RcR840GGUvcYrM3+UoyJfQSTmQoOTFSlXZCVvee7uH2sKGnyp79Iw3ppRNs 4IGOt8ZdpZgTrJDp8LVDxuX6Vqk6FV9Lt1Kb6EnNYj/Ufw== X-Virus-Scanned: by MailRoute Received: from 009.lax.mailroute.net ([127.0.0.1]) by localhost (009.lax [127.0.0.1]) (mroute_mailscanner, port 10029) with LMTP id 8AVUPSADpCp8; Mon, 11 Mar 2024 18:35:47 +0000 (UTC) Received: from [192.168.51.14] (c-73-231-117-72.hsd1.ca.comcast.net [73.231.117.72]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: bvanassche@acm.org) by 009.lax.mailroute.net (Postfix) with ESMTPSA id 4TtlpB6fD6zlgVnW; Mon, 11 Mar 2024 18:35:46 +0000 (UTC) Message-ID: <0aca7640-e6e1-4ab6-93a1-d4fea1683c6f@acm.org> Date: Mon, 11 Mar 2024 11:35:45 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/4] scsi: ufs: Re-use exec_dev_cmd Content-Language: en-US To: Avri Altman , "James E . J . Bottomley" , "Martin K . Petersen" Cc: Bean Huo , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org References: <20240309081104.5006-1-avri.altman@wdc.com> <20240309081104.5006-3-avri.altman@wdc.com> From: Bart Van Assche In-Reply-To: <20240309081104.5006-3-avri.altman@wdc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 3/9/24 00:11, Avri Altman wrote: > Move out the actual command issue from exec_dev_cmd so it can be used > elsewhere. While at it, remove a redundant "lrbp->cmd = NULL" > assignment. > > Also, the device management commands that are originated from the > ufs-bsg code path, are being traced now, which wasn't the case before. Reviewed-by: Bart Van Assche