Received-SPF: pass (google.com: domain of linux-kernel+bounces-99436-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Mon, 11 Mar 2024 11:45:39 -0700
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Ilpo =?iso-8859-1?Q?J=E4rvinen?= <ilpo.jarvinen@linux.intel.com>
Cc: Ike Panhc <ike.pan@canonical.com>, Hans de Goede <hdegoede@redhat.com>,
	Philipp Jungkamp <p.jungkamp@gmx.net>, Gergo Koteles <soyer@irl.hu>,
	platform-driver-x86@vger.kernel.org,
	LKML <linux-kernel@vger.kernel.org>, linux-input@vger.kernel.org
Subject: Re: [PATCH 0/2] map Fn + R key on newer Yogas and Legions
Message-ID: <Ze9RU8Mbnl-w8ZUL@google.com>
References: <cover.1708399689.git.soyer@irl.hu>
 <170895405312.2243.4199399921923370447.b4-ty@linux.intel.com>
 <Ze0PSaOQSJMxL_Ln@google.com>
 <269b8adf-426a-b614-5450-383cde095c75@linux.intel.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <269b8adf-426a-b614-5450-383cde095c75@linux.intel.com>

On Mon, Mar 11, 2024 at 12:53:36PM +0200, Ilpo J?rvinen wrote:
> On Sat, 9 Mar 2024, Dmitry Torokhov wrote:
> 
> > On Mon, Feb 26, 2024 at 03:27:33PM +0200, Ilpo J?rvinen wrote:
> > > On Tue, 20 Feb 2024 04:39:34 +0100, Gergo Koteles wrote:
> > > 
> > > > This patch series adds a new KEY_FN_R input event code and map the
> > > > Fn + R key to it in the ideapad-laptop driver.
> > > > 
> > > > It affects two WMI keycodes and I couldn't try the 0x0a, but I couldn't
> > > > find any indication that the refresh rate toggle should not be Fn + R.
> > > > 
> > > > Regards,
> > > > Gergo
> > > > 
> > > > [...]
> > > 
> > > 
> > > Thank you for your contribution, it has been applied to my local
> > > review-ilpo branch. Note it will show up in the public
> > > platform-drivers-x86/review-ilpo branch only once I've pushed my
> > > local branch there, which might take a while.
> > > 
> > > The list of commits applied:
> > > [1/2] Input: allocate keycode for Fn + R
> > >       commit: 4e45fa464aeef4e803412b5dcce73aad48c94b0e
> > 
> > I am sorry for the delay, but instead of defining a generic name we should define
> > a proper keycode for concrete action even if nothing is printed on a
> > particular key on a particular device.
> > 
> > Please drop this patch.
> 
> Dropping them at this point would bit of a hassle due to backmerges of
> fixes branch.

You should really wait applying patches affecting other parts of the
kernel as well as UAPI until all maintainers responsible for them agree
with the changes.

Thanks.

-- 
Dmitry