Received-SPF: pass (google.com: domain of linux-kernel+bounces-99451-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <5f6b7fad-5ad3-44a0-9e10-3e1c13109abd@gmail.com>
Date: Mon, 11 Mar 2024 20:12:51 +0100
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] staging: cfg80211: Remove parentheses prism2_get_station
To: Julia Lawall <julia.lawall@inria.fr>,
 "Felix N. Kimbu" <felixkimbu1@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
 linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
 outreachy@lists.linux.dev
References: <Ze8LBf6xSjCRt4rd@MOLeToid>
 <4936c555-2c53-d421-126c-48804a26887d@inria.fr>
Content-Language: en-US
From: Philipp Hortmann <philipp.g.hortmann@gmail.com>
In-Reply-To: <4936c555-2c53-d421-126c-48804a26887d@inria.fr>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 3/11/24 18:05, Julia Lawall wrote:
> 
> 
> On Mon, 11 Mar 2024, Felix N. Kimbu wrote:
> 
>> Remove unnecessary parentheses around 'wlandev->msdstate != WLAN_MSD_RUNNING'
>> in static int prism2_get_station(...)
> 
> You don't need the name of the function in the subject line.  That
> information doesn't help understand the patch.
> 
> julia

Hi Julia,

I think we do not need the function name in the subject but we need 
something to distinguish between the patches. The subject line needs to 
be a little unique. Otherwise we will have 100 patches like "[PATCH] 
staging: cfg80211: Remove parentheses" when we are unlucky. Any better 
proposal for a Subject uniqueness is welcome.

Function name for this purpose is OK for me.

Thanks for your support.

Bye Philipp


> 
>>
>> This change ensures adherence to coding style guidelines.
>>
>> Signed-off-by: Felix N. Kimbu <felixkimbu1@gmail.com>
>> ---
>>   drivers/staging/wlan-ng/cfg80211.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/staging/wlan-ng/cfg80211.c b/drivers/staging/wlan-ng/cfg80211.c
>> index 471bb310176f..7451fd2bb580 100644
>> --- a/drivers/staging/wlan-ng/cfg80211.c
>> +++ b/drivers/staging/wlan-ng/cfg80211.c
>> @@ -247,7 +247,7 @@ static int prism2_get_station(struct wiphy *wiphy, struct net_device *dev,
>>
>>   	memset(sinfo, 0, sizeof(*sinfo));
>>
>> -	if (!wlandev || (wlandev->msdstate != WLAN_MSD_RUNNING))
>> +	if (!wlandev || wlandev->msdstate != WLAN_MSD_RUNNING)
>>   		return -EOPNOTSUPP;
>>
>>   	/* build request message */
>> --
>> 2.34.1
>>
>>
>>
>