Received-SPF: pass (google.com: domain of linux-kernel+bounces-99487-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Mon, 11 Mar 2024 16:53:03 -0300
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Anne Macedo <retpolanne@posteo.net>
Cc: Namhyung Kim <namhyung@kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>, Mark Rutland <mark.rutland@arm.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Jiri Olsa <jolsa@kernel.org>, Ian Rogers <irogers@google.com>,
	Adrian Hunter <adrian.hunter@intel.com>,
	linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] perf lock contention: skip traceiter functions
Message-ID: <Ze9hH5UzmnkFrTmB@x1>
References: <20240309132710.1055941-1-retpolanne@posteo.net>
 <CAM9d7cjhiua5rBj=CTDJJC-XJN6PzKxQ5DsooJGEz0QcQAry7w@mail.gmail.com>
 <m2il1sbocg.fsf@posteo.net>
 <m24jdcbmg3.fsf@posteo.net>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <m24jdcbmg3.fsf@posteo.net>

On Mon, Mar 11, 2024 at 07:25:16PM +0000, Anne Macedo wrote:
> Anne Macedo <retpolanne@posteo.net> writes:
> > Namhyung Kim <namhyung@kernel.org> writes:
> >> I think it depends on the kernel version and configuration.  I remember
> >> I saw a different symbol on old kernels.  But it'd be hard to handle all
> >> the cases.  Let's have a single trace text section in the struct machine
> >> and use __traceiter_contention_begin only.  If it's not found you can
> >> fallback to trace_contention_begin.
 
> However, if we fallback to trace_contention_begin, we won't be able to
> filter out both __traceiter_contention_begin and trace_contention_begin
> at the same time.

I think for ARM we need to skip both, no? I.e. I agree with Anne.

- Arnaldo