Received-SPF: pass (google.com: domain of linux-kernel+bounces-99535-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Mon, 11 Mar 2024 21:46:38 +0100 (CET)
From: Julia Lawall <julia.lawall@inria.fr>
To: Philipp Hortmann <philipp.g.hortmann@gmail.com>
cc: "Felix N. Kimbu" <felixkimbu1@gmail.com>, 
    Greg Kroah-Hartman <gregkh@linuxfoundation.org>, 
    linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, 
    outreachy@lists.linux.dev
Subject: Re: [PATCH] staging: cfg80211: Remove parentheses
 prism2_get_station
In-Reply-To: <5f6b7fad-5ad3-44a0-9e10-3e1c13109abd@gmail.com>
Message-ID: <alpine.DEB.2.22.394.2403112146230.3216@hadrien>
References: <Ze8LBf6xSjCRt4rd@MOLeToid> <4936c555-2c53-d421-126c-48804a26887d@inria.fr> <5f6b7fad-5ad3-44a0-9e10-3e1c13109abd@gmail.com>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII


On Mon, 11 Mar 2024, Philipp Hortmann wrote:

> On 3/11/24 18:05, Julia Lawall wrote:
> >
> >
> > On Mon, 11 Mar 2024, Felix N. Kimbu wrote:
> >
> > > Remove unnecessary parentheses around 'wlandev->msdstate !=
> > > WLAN_MSD_RUNNING'
> > > in static int prism2_get_station(...)
> >
> > You don't need the name of the function in the subject line.  That
> > information doesn't help understand the patch.
> >
> > julia
>
> Hi Julia,
>
> I think we do not need the function name in the subject but we need something
> to distinguish between the patches. The subject line needs to be a little
> unique. Otherwise we will have 100 patches like "[PATCH] staging: cfg80211:
> Remove parentheses" when we are unlucky. Any better proposal for a Subject
> uniqueness is welcome.
>
> Function name for this purpose is OK for me.

OK, no problem.

thanks,
julia

>
> Thanks for your support.
>
> Bye Philipp
>
>
> >
> > >
> > > This change ensures adherence to coding style guidelines.
> > >
> > > Signed-off-by: Felix N. Kimbu <felixkimbu1@gmail.com>
> > > ---
> > >   drivers/staging/wlan-ng/cfg80211.c | 2 +-
> > >   1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/staging/wlan-ng/cfg80211.c
> > > b/drivers/staging/wlan-ng/cfg80211.c
> > > index 471bb310176f..7451fd2bb580 100644
> > > --- a/drivers/staging/wlan-ng/cfg80211.c
> > > +++ b/drivers/staging/wlan-ng/cfg80211.c
> > > @@ -247,7 +247,7 @@ static int prism2_get_station(struct wiphy *wiphy,
> > > struct net_device *dev,
> > >
> > >   	memset(sinfo, 0, sizeof(*sinfo));
> > >
> > > -	if (!wlandev || (wlandev->msdstate != WLAN_MSD_RUNNING))
> > > +	if (!wlandev || wlandev->msdstate != WLAN_MSD_RUNNING)
> > >   		return -EOPNOTSUPP;
> > >
> > >   	/* build request message */
> > > --
> > > 2.34.1
> > >
> > >
> > >
> >
>
>